linux-next: build warning after merge of the slab tree

linux-next: build warning after merge of the slab tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

After merging the slab tree, today's linux-next build (powerpc
allnoconfig) produced this warning:

mm/slub.c: In function 'slab_free':
mm/slub.c:2124: warning: label 'redo' defined but not used

Introduced by commit 8a5ec0ba42c4 ("Lockless (and preemptless) fastpaths
for slub").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the slab tree

[Christoph Lameter]

On Mon, 14 Mar 2011, Stephen Rothwell wrote:

> mm/slub.c: In function 'slab_free':
> mm/slub.c:2124: warning: label 'redo' defined but not used
>
> Introduced by commit 8a5ec0ba42c4 ("Lockless (and preemptless) fastpaths
> for slub").
---

Subject: slub: Dont define useless label in the !CONFIG_CMPXCHG_LOCAL case

The redo label needs #ifdeffery.

Signed-off-by: Christoph Lameter <cl@linux.com>

 mm/slub.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-next/mm/slub.c
===================================================================
--- linux-next.orig/mm/slub.c	2011-03-15 12:41:41.000000000 -0500
+++ linux-next/mm/slub.c	2011-03-15 12:43:06.000000000 -0500
@@ -2119,9 +2119,11 @@ static __always_inline void slab_free(st

 #ifndef CONFIG_CMPXCHG_LOCAL
 	local_irq_save(flags);
-#endif

+#else
 redo:
+#endif
+
 	/*
 	 * Determine the currently cpus per cpu slab.
 	 * The cpu may change afterward. However that does not matter since

linux-next: build warning after merge of the slab tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi all,

After merging the slab tree, today's linux-next build (i386_defconfig)
produced this warning:

mm/slab_common.c: In function 'kmem_cache_create':
mm/slab_common.c:101:1: warning: label 'oops' defined but not used [-Wunused-label]

Introduced by commit 20cea9683ecc ("mm, sl[aou]b: Move kmem_cache_create
mutex handling to common code") from the slab tree.  The label is only
used when CONFIG_DEBUG_VM is defined.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build warning after merge of the slab tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

After merging the slab tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/mm_types.h:399: warning: Function parameter or struct member '_unused_slab_obj_ext' not described in 'folio'

Introduced by commit

  05d5996d4b9b ("mm/memcg: alignment memcg_data define condition")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the slab tree

[Vlastimil Babka]

On 7/15/24 9:06 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the slab tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/mm_types.h:399: warning: Function parameter or struct member '_unused_slab_obj_ext' not described in 'folio'
> 
> Introduced by commit
> 
>   05d5996d4b9b ("mm/memcg: alignment memcg_data define condition")

Added, the htmldocs description, thanks.

linux-next: build warning after merge of the slab tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

After merging the slab tree, today's linux-next build (htmldocs) produced
this warning:

include/linux/slab.h:244: warning: Cannot understand  * @align: The required alignment for the objects.
 on line 244 - I thought it was a doc line

Introduced by commit

  0c64b97ac116 ("slab: add struct kmem_cache_args")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the slab tree

[Vlastimil Babka]

On 9/6/24 10:33, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the slab tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> include/linux/slab.h:244: warning: Cannot understand  * @align: The required alignment for the objects.
>  on line 244 - I thought it was a doc line
> 
> Introduced by commit
> 
>   0c64b97ac116 ("slab: add struct kmem_cache_args")

Thanks, fixed it up:

 /**
+ * struct kmem_cache_args - Less common arguments for kmem_cache_create()
  * @align: The required alignment for the objects.

linux-next: build warning after merge of the slab tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

Hi all,

After merging the slab tree, today's linux-next build (htmldocs) produced
this warning:

WARNING: mm/slub.c:7088 function parameter 'objp' not described in 'ksize'

Introduced by commit

  1e8eb4117f27 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the slab tree

[Vlastimil Babka]

On 1/14/26 05:13, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the slab tree, today's linux-next build (htmldocs) produced
> this warning:
> 
> WARNING: mm/slub.c:7088 function parameter 'objp' not described in 'ksize'
> 
> Introduced by commit
> 
>   1e8eb4117f27 ("mm/slab: move [__]ksize and slab_ksize() to mm/slub.c")
> 
Fixed, thanks.