From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christian Brauner <brauner@kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>
Cc: Dongliang Cui <dongliang.cui@unisoc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yuezhang Mo <Yuezhang.Mo@sony.com>,
Zhiguo Niu <zhiguo.niu@unisoc.com>
Subject: linux-next: manual merge of the vfs-brauner tree with the exfat tree
Date: Mon, 12 Aug 2024 08:10:46 +1000 [thread overview]
Message-ID: <20240812081046.369bbba5@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1959 bytes --]
Hi all,
Today's linux-next merge of the vfs-brauner tree got a conflict in:
fs/exfat/inode.c
between commits:
3e491faa7648 ("exfat: do not fallback to buffered write")
98ad7b9012b5 ("exfat: Implement sops->shutdown and ioctl")
from the exfat tree and commits:
a225800f322a ("fs: Convert aops->write_end to take a folio")
1da86618bdce ("fs: Convert aops->write_begin to take a folio")
from the vfs-brauner tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/exfat/inode.c
index 7d43a0942911,05f0e07b01d0..000000000000
--- a/fs/exfat/inode.c
+++ b/fs/exfat/inode.c
@@@ -428,11 -452,7 +428,10 @@@ static int exfat_write_begin(struct fil
{
int ret;
+ if (unlikely(exfat_forced_shutdown(mapping->host->i_sb)))
+ return -EIO;
+
- *pagep = NULL;
- ret = block_write_begin(mapping, pos, len, pagep, exfat_get_block);
+ ret = block_write_begin(mapping, pos, len, foliop, exfat_get_block);
if (ret < 0)
exfat_write_failed(mapping, pos+len);
@@@ -448,7 -468,15 +447,7 @@@ static int exfat_write_end(struct file
struct exfat_inode_info *ei = EXFAT_I(inode);
int err;
- err = generic_write_end(file, mapping, pos, len, copied, pagep, fsdata);
+ err = generic_write_end(file, mapping, pos, len, copied, folio, fsdata);
-
- if (ei->i_size_aligned < i_size_read(inode)) {
- exfat_fs_error(inode->i_sb,
- "invalid size(size(%llu) > aligned(%llu)\n",
- i_size_read(inode), ei->i_size_aligned);
- return -EIO;
- }
-
if (err < len)
exfat_write_failed(mapping, pos+len);
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-08-11 22:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 22:10 Stephen Rothwell [this message]
2024-08-12 0:54 ` linux-next: manual merge of the vfs-brauner tree with the exfat tree Namjae Jeon
2024-09-16 22:22 ` Stephen Rothwell
2024-09-17 6:44 ` Namjae Jeon
-- strict thread matches above, loose matches on Subject: below --
2026-03-27 17:35 Mark Brown
2026-03-28 1:01 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812081046.369bbba5@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Yuezhang.Mo@sony.com \
--cc=brauner@kernel.org \
--cc=dongliang.cui@unisoc.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=willy@infradead.org \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox