From: Luis Chamberlain <mcgrof@kernel.org>
To: brauner@kernel.org, djwong@kernel.org, sfr@canb.auug.org.au
Cc: p.raghav@samsung.com, dchinner@redhat.com, mcgrof@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-next@vger.kernel.org
Subject: [PATCH] iomap: remove set_memor_ro() on zero page
Date: Mon, 26 Aug 2024 14:26:32 -0700 [thread overview]
Message-ID: <20240826212632.2098685-1-mcgrof@kernel.org> (raw)
Stephen reported a boot failure on ppc power8 system where
set_memor_ro() on the new zero page failed [0]. Christophe Leroy
further clarifies we can't use this on on linear memory on ppc, and
so instead of special casing this just for PowerPC [2] remove the
call as suggested by Darrick.
[0] https://lore.kernel.org/all/20240826175931.1989f99e@canb.auug.org.au/T/#u
[1] https://lore.kernel.org/all/b0fe75b4-c1bb-47f7-a7c3-2534b31c1780@csgroup.eu/
[2] https://lore.kernel.org/all/ZszrJkFOpiy5rCma@bombadil.infradead.org/
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
This applies to the vfs.blocksize branch on the vfs tree.
fs/iomap/direct-io.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index c02b266bba52..f637aa0706a3 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -11,7 +11,6 @@
#include <linux/iomap.h>
#include <linux/backing-dev.h>
#include <linux/uio.h>
-#include <linux/set_memory.h>
#include <linux/task_io_accounting_ops.h>
#include "trace.h"
@@ -781,8 +780,6 @@ static int __init iomap_dio_init(void)
if (!zero_page)
return -ENOMEM;
- set_memory_ro((unsigned long)page_address(zero_page),
- 1U << IOMAP_ZERO_PAGE_ORDER);
return 0;
}
fs_initcall(iomap_dio_init);
--
2.43.0
next reply other threads:[~2024-08-26 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 21:26 Luis Chamberlain [this message]
2024-08-27 4:07 ` [PATCH] iomap: remove set_memor_ro() on zero page Christoph Hellwig
2024-08-27 5:55 ` Darrick J. Wong
2024-08-27 6:26 ` Stephen Rothwell
2024-08-27 7:56 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826212632.2098685-1-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=brauner@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=p.raghav@samsung.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox