From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Helge Deller <deller@gmx.de>
Cc: "Jocelyn Falempe" <jfalempe@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: linux-next: manual merge of the fbdev tree with Linus' tree
Date: Tue, 24 Sep 2024 11:16:07 +1000 [thread overview]
Message-ID: <20240924111607.75ffc555@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]
Hi all,
Today's linux-next merge of the fbdev tree got a conflict in:
drivers/video/fbdev/core/fbcon.c
between commits:
d20a9f568f99 ("fbcon: Add an option to disable fbcon in panic")
1c1ed27ee117 ("fbcon: Use oops_in_progress instead of panic_cpu")
from Linus' tree and commit:
4baa6a5e164b ("fbcon: fbcon_is_inactive() -> fbcon_is_active()")
from the fbdev tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc drivers/video/fbdev/core/fbcon.c
index 2e093535884b,7e6be2a8850b..000000000000
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@@ -272,19 -267,7 +269,19 @@@ static int fbcon_get_rotate(struct fb_i
return (ops) ? ops->rotate : 0;
}
+static bool fbcon_skip_panic(struct fb_info *info)
+{
+/* panic_cpu is not exported, and can't be used if built as module. Use
+ * oops_in_progress instead, but non-fatal oops won't be printed.
+ */
+#if defined(MODULE)
+ return (info->skip_panic && unlikely(oops_in_progress));
+#else
+ return (info->skip_panic && unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID));
+#endif
+}
+
- static inline int fbcon_is_inactive(struct vc_data *vc, struct fb_info *info)
+ static inline bool fbcon_is_active(struct vc_data *vc, struct fb_info *info)
{
struct fbcon_ops *ops = info->fbcon_par;
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-09-24 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 1:16 Stephen Rothwell [this message]
2024-09-24 8:29 ` linux-next: manual merge of the fbdev tree with Linus' tree Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2019-06-24 1:42 Stephen Rothwell
2019-06-11 0:37 Stephen Rothwell
2018-06-13 23:40 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924111607.75ffc555@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=deller@gmx.de \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox