public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Christian Brauner <brauner@kernel.org>
Cc: Bill O'Donnell <bodonnel@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: Fixes tag needs some work in the vfs-brauner tree
Date: Wed, 16 Oct 2024 08:10:03 +1100	[thread overview]
Message-ID: <20241016081003.23b90c5c@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

Hi all,

In commit

  51ceeb1a8142 ("efs: fix the efs new mount api implementation")

Fixes tag

  Fixes: 39a6c668e4 efs: convert efs to use the new mount api.

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags together at the end fo
the commit message.

Thus:

Fixes: 39a6c668e4e7 ("efs: convert efs to use the new mount api")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2024-10-15 21:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 21:10 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-09-08 21:45 linux-next: Fixes tag needs some work in the vfs-brauner tree Stephen Rothwell
2023-11-07 21:02 Stephen Rothwell
2023-11-08  8:16 ` Christian Brauner
2023-08-14 22:57 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016081003.23b90c5c@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=bodonnel@redhat.com \
    --cc=brauner@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox