[PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Philipp Zabel]

Silence the following warnings when building the LAN966x device tree
overlay:

drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
The referenced commit is in the reset tree.
---
 drivers/misc/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 885b22989580..d6d1d3ff4ef1 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -72,6 +72,7 @@ obj-$(CONFIG_TPS6594_PFSM)	+= tps6594-pfsm.o
 obj-$(CONFIG_NSM)		+= nsm.o
 obj-$(CONFIG_MARVELL_CN10K_DPI)	+= mrvl_cn10k_dpi.o
 lan966x-pci-objs		:= lan966x_pci.o
+DTC_FLAGS_lan966x_pci		:= -Wno-interrupts_property -Wno-simple_bus_reg -Wno-avoid_unnecessary_addr_size
 lan966x-pci-objs		+= lan966x_pci.dtbo.o
 obj-$(CONFIG_MCHP_LAN966X_PCI)	+= lan966x-pci.o
 obj-y				+= keba/
-- 
2.39.5

Re: [PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Rob Herring]

On Fri, Oct 25, 2024 at 9:54 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> Silence the following warnings when building the LAN966x device tree
> overlay:
>
> drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent

> drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property

These nodes should be moved out of the simple-bus.

> drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property

For this one,  dtc should be fixed to also look for child "ranges" property.

Aren't these other ones all W=1 warnings?

Rob

Re: [PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Philipp Zabel]

On Fr, 2024-10-25 at 10:40 -0500, Rob Herring wrote:
> On Fri, Oct 25, 2024 at 9:54 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > 
> > Silence the following warnings when building the LAN966x device tree
> > overlay:
> > 
> > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> 
> > drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> > drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> > drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
> 
> These nodes should be moved out of the simple-bus.

Ah, thank you. Hervé, can you send a follow-up to fix these?

> > drivers/misc/lan966x_pci.dtso:18.15-165.5: Warning (avoid_unnecessary_addr_size): /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> 
> For this one,  dtc should be fixed to also look for child "ranges" property.

Gave it a shot:

https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@pengutronix.de/T/#u


> Aren't these other ones all W=1 warnings?

My bad, you are right. I'll drop them from this patch.

regards
Philipp

Re: [PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Herve Codina]

Hi All,

On Fri, 25 Oct 2024 18:17:30 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:

> On Fr, 2024-10-25 at 10:40 -0500, Rob Herring wrote:
> > On Fri, Oct 25, 2024 at 9:54 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:  
> > > 
> > > Silence the following warnings when building the LAN966x device tree
> > > overlay:
> > > 
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent  
> >   
> > > drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> > > drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> > > drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property  
> > 
> > These nodes should be moved out of the simple-bus.  
> 
> Ah, thank you. Hervé, can you send a follow-up to fix these?

Yes, I will do.
Is it ok for you if I send the patch on Monday morning?

Best regards,
Hervé

Re: [PATCH] misc: Silence warnings when building the LAN966x device tree overlay

[Philipp Zabel]

On Fr, 2024-10-25 at 18:38 +0200, Herve Codina wrote:
> Hi All,
> 
> On Fri, 25 Oct 2024 18:17:30 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
> 
> > On Fr, 2024-10-25 at 10:40 -0500, Rob Herring wrote:
> > > On Fri, Oct 25, 2024 at 9:54 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:  
> > > > 
> > > > Silence the following warnings when building the LAN966x device tree
> > > > overlay:
> > > > 
> > > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent  
> > >   
> > > > drivers/misc/lan966x_pci.dtso:42.22-46.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> > > > drivers/misc/lan966x_pci.dtso:48.22-52.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> > > > drivers/misc/lan966x_pci.dtso:54.22-58.7: Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property  
> > > 
> > > These nodes should be moved out of the simple-bus.  
> > 
> > Ah, thank you. Hervé, can you send a follow-up to fix these?
> 
> Yes, I will do.
> Is it ok for you if I send the patch on Monday morning?

Ok, I'll silence the warning until then.

regards
Philipp