* [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay
@ 2024-10-25 16:17 Philipp Zabel
2024-10-25 16:38 ` Herve Codina
2024-10-25 16:53 ` Philipp Zabel
0 siblings, 2 replies; 5+ messages in thread
From: Philipp Zabel @ 2024-10-25 16:17 UTC (permalink / raw)
To: Stephen Rothwell, Herve Codina, Rob Herring
Cc: linux-kernel, linux-next, Arnd Bergmann, Greg Kroah-Hartman,
Philipp Zabel
Silence the following warning when building the LAN966x device tree overlay:
drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
The referenced commit is in the reset tree.
Changes in v2:
- Do not handle W=1 warnings.
- Link to v1: https://lore.kernel.org/all/20241025145353.1620806-1-p.zabel@pengutronix.de/
---
drivers/misc/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
index 885b22989580..196fb730817e 100644
--- a/drivers/misc/Makefile
+++ b/drivers/misc/Makefile
@@ -72,6 +72,7 @@ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
obj-$(CONFIG_NSM) += nsm.o
obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
lan966x-pci-objs := lan966x_pci.o
+DTC_FLAGS_lan966x_pci := -Wno-interrupts_property
lan966x-pci-objs += lan966x_pci.dtbo.o
obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
obj-y += keba/
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay
2024-10-25 16:17 [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay Philipp Zabel
@ 2024-10-25 16:38 ` Herve Codina
2024-10-25 16:53 ` Philipp Zabel
1 sibling, 0 replies; 5+ messages in thread
From: Herve Codina @ 2024-10-25 16:38 UTC (permalink / raw)
To: Philipp Zabel
Cc: Stephen Rothwell, Rob Herring, linux-kernel, linux-next,
Arnd Bergmann, Greg Kroah-Hartman
On Fri, 25 Oct 2024 18:17:39 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Silence the following warning when building the LAN966x device tree overlay:
>
> drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
> Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay
2024-10-25 16:17 [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay Philipp Zabel
2024-10-25 16:38 ` Herve Codina
@ 2024-10-25 16:53 ` Philipp Zabel
2024-10-25 17:21 ` Herve Codina
1 sibling, 1 reply; 5+ messages in thread
From: Philipp Zabel @ 2024-10-25 16:53 UTC (permalink / raw)
To: Stephen Rothwell, Herve Codina, Rob Herring
Cc: linux-kernel, linux-next, Arnd Bergmann, Greg Kroah-Hartman
On Fr, 2024-10-25 at 18:17 +0200, Philipp Zabel wrote:
> Silence the following warning when building the LAN966x device tree overlay:
>
> drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
> Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> The referenced commit is in the reset tree.
> Changes in v2:
> - Do not handle W=1 warnings.
> - Link to v1: https://lore.kernel.org/all/20241025145353.1620806-1-p.zabel@pengutronix.de/
> ---
> drivers/misc/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> index 885b22989580..196fb730817e 100644
> --- a/drivers/misc/Makefile
> +++ b/drivers/misc/Makefile
> @@ -72,6 +72,7 @@ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
> obj-$(CONFIG_NSM) += nsm.o
> obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
> lan966x-pci-objs := lan966x_pci.o
> +DTC_FLAGS_lan966x_pci := -Wno-interrupts_property
> lan966x-pci-objs += lan966x_pci.dtbo.o
> obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
> obj-y += keba/
Applied to reset/next to silence the warning until lan966x_pci.dtso is
fixed:
[1/1] misc: Silence warning when building the LAN966x device tree overlay
https://git.pengutronix.de/cgit/pza/linux/commit/?id=68152eff5240
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay
2024-10-25 16:53 ` Philipp Zabel
@ 2024-10-25 17:21 ` Herve Codina
2024-10-26 11:34 ` Herve Codina
0 siblings, 1 reply; 5+ messages in thread
From: Herve Codina @ 2024-10-25 17:21 UTC (permalink / raw)
To: Philipp Zabel
Cc: Stephen Rothwell, Rob Herring, linux-kernel, linux-next,
Arnd Bergmann, Greg Kroah-Hartman
On Fri, 25 Oct 2024 18:53:46 +0200
Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Fr, 2024-10-25 at 18:17 +0200, Philipp Zabel wrote:
> > Silence the following warning when building the LAN966x device tree overlay:
> >
> > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> >
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Link: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
> > Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > The referenced commit is in the reset tree.
> > Changes in v2:
> > - Do not handle W=1 warnings.
> > - Link to v1: https://lore.kernel.org/all/20241025145353.1620806-1-p.zabel@pengutronix.de/
> > ---
> > drivers/misc/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> > index 885b22989580..196fb730817e 100644
> > --- a/drivers/misc/Makefile
> > +++ b/drivers/misc/Makefile
> > @@ -72,6 +72,7 @@ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
> > obj-$(CONFIG_NSM) += nsm.o
> > obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
> > lan966x-pci-objs := lan966x_pci.o
> > +DTC_FLAGS_lan966x_pci := -Wno-interrupts_property
> > lan966x-pci-objs += lan966x_pci.dtbo.o
> > obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
> > obj-y += keba/
>
> Applied to reset/next to silence the warning until lan966x_pci.dtso is
> fixed:
This warning 'Missing interrupt-parent' cannot be solved in dtso.
I cannot reference the interrupt controller (PCI device node itself) which
is outside the dtso. This PCI device node is the node on which the dtso
is applied.
I think the patch you did is the correct one for this warning.
Related to other warnings mentionned in v1:
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
I will update the dtso and send the related patch.
Best regards,
Hervé
>
> [1/1] misc: Silence warning when building the LAN966x device tree overlay
> https://git.pengutronix.de/cgit/pza/linux/commit/?id=68152eff5240
>
> regards
> Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay
2024-10-25 17:21 ` Herve Codina
@ 2024-10-26 11:34 ` Herve Codina
0 siblings, 0 replies; 5+ messages in thread
From: Herve Codina @ 2024-10-26 11:34 UTC (permalink / raw)
To: Philipp Zabel
Cc: Stephen Rothwell, Rob Herring, linux-kernel, linux-next,
Arnd Bergmann, Greg Kroah-Hartman
Hi Philipp,
On Fri, 25 Oct 2024 19:21:17 +0200
Herve Codina <herve.codina@bootlin.com> wrote:
> On Fri, 25 Oct 2024 18:53:46 +0200
> Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> > On Fr, 2024-10-25 at 18:17 +0200, Philipp Zabel wrote:
> > > Silence the following warning when building the LAN966x device tree overlay:
> > >
> > > drivers/misc/lan966x_pci.dtso:34.23-40.7: Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Link: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.au/
> > > Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device")
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > > ---
> > > The referenced commit is in the reset tree.
> > > Changes in v2:
> > > - Do not handle W=1 warnings.
> > > - Link to v1: https://lore.kernel.org/all/20241025145353.1620806-1-p.zabel@pengutronix.de/
> > > ---
> > > drivers/misc/Makefile | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
> > > index 885b22989580..196fb730817e 100644
> > > --- a/drivers/misc/Makefile
> > > +++ b/drivers/misc/Makefile
> > > @@ -72,6 +72,7 @@ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
> > > obj-$(CONFIG_NSM) += nsm.o
> > > obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
> > > lan966x-pci-objs := lan966x_pci.o
> > > +DTC_FLAGS_lan966x_pci := -Wno-interrupts_property
> > > lan966x-pci-objs += lan966x_pci.dtbo.o
> > > obj-$(CONFIG_MCHP_LAN966X_PCI) += lan966x-pci.o
> > > obj-y += keba/
> >
> > Applied to reset/next to silence the warning until lan966x_pci.dtso is
> > fixed:
>
> This warning 'Missing interrupt-parent' cannot be solved in dtso.
> I cannot reference the interrupt controller (PCI device node itself) which
> is outside the dtso. This PCI device node is the node on which the dtso
> is applied.
>
> I think the patch you did is the correct one for this warning.
Thought about a way to remove the 'Missing interrupt-parent' warning
modifying the dtso. I will propose a patch on Monday.
If accepted, it will replace your patch.
Best regards,
Hervé
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-26 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25 16:17 [PATCH v2] misc: Silence warning when building the LAN966x device tree overlay Philipp Zabel
2024-10-25 16:38 ` Herve Codina
2024-10-25 16:53 ` Philipp Zabel
2024-10-25 17:21 ` Herve Codina
2024-10-26 11:34 ` Herve Codina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox