Missing signoffs in the ext3 tree

Missing signoffs in the ext3 tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Hi,

Commits

  74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
  8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")

are missing a Signed-off-by from their authors.

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missing signoffs in the ext3 tree

[Jan Kara]

Hi!

On Fri 06-12-24 10:22:31, Mark Brown wrote:
> Commits
> 
>   74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
>   8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")

Thanks for noticing Mark.

Al, care to provide your signed-off-by for the
"fs: get rid of __FMODE_NONOTIFY kludge"? Amir then massaged the details
but you were indeed the original author of big part of the patch. Thanks!

Amir, I'm not sure about the authorship of "fanotify: don't skip extra
event info if no info_mode is set". Was it you or actually Josef?

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: Missing signoffs in the ext3 tree

[Amir Goldstein]

On Fri, Dec 6, 2024 at 3:46 PM Jan Kara <jack@suse.cz> wrote:
>
> Hi!
>
> On Fri 06-12-24 10:22:31, Mark Brown wrote:
> > Commits
> >
> >   74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
> >   8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")
>
> Thanks for noticing Mark.
>
> Al, care to provide your signed-off-by for the
> "fs: get rid of __FMODE_NONOTIFY kludge"? Amir then massaged the details
> but you were indeed the original author of big part of the patch. Thanks!
>
> Amir, I'm not sure about the authorship of "fanotify: don't skip extra
> event info if no info_mode is set". Was it you or actually Josef?

I do not know if I sent out a sketch, but looks like Josef was the
author of the patch in its current form:
https://lore.kernel.org/linux-fsdevel/adfd31f369528c9958922d901fbe8eba48dfe496.1721403041.git.josef@toxicpanda.com/
we passed the branch back and forth so many times that I might have
changed authorship by mistake,
so best fix authorship.

Thanks,
Amir.

Re: Missing signoffs in the ext3 tree

[Jan Kara]

On Fri 06-12-24 15:52:49, Amir Goldstein wrote:
> On Fri, Dec 6, 2024 at 3:46 PM Jan Kara <jack@suse.cz> wrote:
> >
> > Hi!
> >
> > On Fri 06-12-24 10:22:31, Mark Brown wrote:
> > > Commits
> > >
> > >   74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
> > >   8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")
> >
> > Thanks for noticing Mark.
> >
> > Al, care to provide your signed-off-by for the
> > "fs: get rid of __FMODE_NONOTIFY kludge"? Amir then massaged the details
> > but you were indeed the original author of big part of the patch. Thanks!
> >
> > Amir, I'm not sure about the authorship of "fanotify: don't skip extra
> > event info if no info_mode is set". Was it you or actually Josef?
> 
> I do not know if I sent out a sketch, but looks like Josef was the
> author of the patch in its current form:
> https://lore.kernel.org/linux-fsdevel/adfd31f369528c9958922d901fbe8eba48dfe496.1721403041.git.josef@toxicpanda.com/
> we passed the branch back and forth so many times that I might have
> changed authorship by mistake,
> so best fix authorship.

Thanks, done!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: Missing signoffs in the ext3 tree

[Al Viro]

On Fri, Dec 06, 2024 at 03:46:06PM +0100, Jan Kara wrote:
> Hi!
> 
> On Fri 06-12-24 10:22:31, Mark Brown wrote:
> > Commits
> > 
> >   74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
> >   8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")
> 
> Thanks for noticing Mark.
> 
> Al, care to provide your signed-off-by for the
> "fs: get rid of __FMODE_NONOTIFY kludge"? Amir then massaged the details
> but you were indeed the original author of big part of the patch. Thanks!

Patch appears to match what I have in a local branch + fix for braino caught
by Amir, so...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Re: Missing signoffs in the ext3 tree

[Jan Kara]

On Fri 06-12-24 17:28:28, Al Viro wrote:
> On Fri, Dec 06, 2024 at 03:46:06PM +0100, Jan Kara wrote:
> > Hi!
> > 
> > On Fri 06-12-24 10:22:31, Mark Brown wrote:
> > > Commits
> > > 
> > >   74094f677916e ("fanotify: don't skip extra event info if no info_mode is set")
> > >   8adc64d022177 ("fs: get rid of __FMODE_NONOTIFY kludge")
> > 
> > Thanks for noticing Mark.
> > 
> > Al, care to provide your signed-off-by for the
> > "fs: get rid of __FMODE_NONOTIFY kludge"? Amir then massaged the details
> > but you were indeed the original author of big part of the patch. Thanks!
> 
> Patch appears to match what I have in a local branch + fix for braino caught
> by Amir, so...
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Thanks! Branch updated & pushed out (and my for_next branch as well).

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR