* [PATCH] platform/x86: alienware-wmi: Fix zone attribute declaration
@ 2025-01-14 17:40 Kurt Borja
2025-01-15 14:45 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Kurt Borja @ 2025-01-14 17:40 UTC (permalink / raw)
To: platform-driver-x86
Cc: oe-kbuild-all, Ilpo Järvinen, Armin Wolf, Mario Limonciello,
hdegoede, Dell.Client.Kernel, linux-kernel, linux-next,
Kurt Borja, kernel test robot
Statically declare `zone*` attributes.
Fixes: 7c605f6460e8 ("platform/x86: alienware-wmi: Improve rgb-zones group creation")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501142200.ezULWY9P-lkp@intel.com/
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
drivers/platform/x86/dell/alienware-wmi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
index b4b43f3e3fd9..d7f577e0d146 100644
--- a/drivers/platform/x86/dell/alienware-wmi.c
+++ b/drivers/platform/x86/dell/alienware-wmi.c
@@ -518,7 +518,7 @@ static ssize_t zone00_store(struct device *dev, struct device_attribute *attr,
return zone_store(dev, attr, buf, count, 0);
}
-DEVICE_ATTR_RW(zone00);
+static DEVICE_ATTR_RW(zone00);
static ssize_t zone01_show(struct device *dev, struct device_attribute *attr,
char *buf)
@@ -532,7 +532,7 @@ static ssize_t zone01_store(struct device *dev, struct device_attribute *attr,
return zone_store(dev, attr, buf, count, 1);
}
-DEVICE_ATTR_RW(zone01);
+static DEVICE_ATTR_RW(zone01);
static ssize_t zone02_show(struct device *dev, struct device_attribute *attr,
char *buf)
@@ -546,7 +546,7 @@ static ssize_t zone02_store(struct device *dev, struct device_attribute *attr,
return zone_store(dev, attr, buf, count, 2);
}
-DEVICE_ATTR_RW(zone02);
+static DEVICE_ATTR_RW(zone02);
static ssize_t zone03_show(struct device *dev, struct device_attribute *attr,
char *buf)
@@ -560,7 +560,7 @@ static ssize_t zone03_store(struct device *dev, struct device_attribute *attr,
return zone_store(dev, attr, buf, count, 3);
}
-DEVICE_ATTR_RW(zone03);
+static DEVICE_ATTR_RW(zone03);
/*
* Lighting control state device attribute (Global)
base-commit: 58126788aa7726c0e91de6b25e6e332fa06089ab
--
2.48.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: alienware-wmi: Fix zone attribute declaration
2025-01-14 17:40 [PATCH] platform/x86: alienware-wmi: Fix zone attribute declaration Kurt Borja
@ 2025-01-15 14:45 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2025-01-15 14:45 UTC (permalink / raw)
To: Kurt Borja
Cc: platform-driver-x86, oe-kbuild-all, Armin Wolf, Mario Limonciello,
Hans de Goede, Dell.Client.Kernel, LKML, linux-next,
kernel test robot
On Tue, 14 Jan 2025, Kurt Borja wrote:
> Statically declare `zone*` attributes.
>
> Fixes: 7c605f6460e8 ("platform/x86: alienware-wmi: Improve rgb-zones group creation")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501142200.ezULWY9P-lkp@intel.com/
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/dell/alienware-wmi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c
> index b4b43f3e3fd9..d7f577e0d146 100644
> --- a/drivers/platform/x86/dell/alienware-wmi.c
> +++ b/drivers/platform/x86/dell/alienware-wmi.c
> @@ -518,7 +518,7 @@ static ssize_t zone00_store(struct device *dev, struct device_attribute *attr,
> return zone_store(dev, attr, buf, count, 0);
> }
>
> -DEVICE_ATTR_RW(zone00);
> +static DEVICE_ATTR_RW(zone00);
>
> static ssize_t zone01_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> @@ -532,7 +532,7 @@ static ssize_t zone01_store(struct device *dev, struct device_attribute *attr,
> return zone_store(dev, attr, buf, count, 1);
> }
>
> -DEVICE_ATTR_RW(zone01);
> +static DEVICE_ATTR_RW(zone01);
>
> static ssize_t zone02_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> @@ -546,7 +546,7 @@ static ssize_t zone02_store(struct device *dev, struct device_attribute *attr,
> return zone_store(dev, attr, buf, count, 2);
> }
>
> -DEVICE_ATTR_RW(zone02);
> +static DEVICE_ATTR_RW(zone02);
>
> static ssize_t zone03_show(struct device *dev, struct device_attribute *attr,
> char *buf)
> @@ -560,7 +560,7 @@ static ssize_t zone03_store(struct device *dev, struct device_attribute *attr,
> return zone_store(dev, attr, buf, count, 3);
> }
>
> -DEVICE_ATTR_RW(zone03);
> +static DEVICE_ATTR_RW(zone03);
>
> /*
> * Lighting control state device attribute (Global)
>
> base-commit: 58126788aa7726c0e91de6b25e6e332fa06089ab
>
Thanks. I've folded this into the original commit in the review-ilpo-next
branch.
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-15 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-14 17:40 [PATCH] platform/x86: alienware-wmi: Fix zone attribute declaration Kurt Borja
2025-01-15 14:45 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox