From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78A22641CE; Tue, 11 Feb 2025 22:32:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739313121; cv=none; b=ENtPEpITIW0KoRgk5ELaFRt2JT+h0rfGWu3vIu/QYg8Y26yW11DObGwE1n059mLPRDWuq0mqZAkMnDjId/Y9cfpaj+dgDbw0tXtilI+60w6RlJL2U6j9BFwhLsrCzQnacB0V9pDy83Q3daAGyy/e6EDuH83jiGcWanosdtVl700= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739313121; c=relaxed/simple; bh=nNdMjvufG1KwK6bx+D+n9kZhJLtmEZprQWWJSdNVqIs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jj+N4zlpYbLlLivjqztNJ7/ZHayBg1U9JR+Fpexl/xukLkFIOA3I32B87Go1vyHXx3wOyLrEfPVEy0XFenHvQogc7GsNarrSXJwuMywmHXcgHkWpehjZfgNYxqC1zYkEuB8i7zT5uvCGm3TtBEmSGr9u8bUTfvsCr8jtF3zJknw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=upjUIQDy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="upjUIQDy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58049C4CEDD; Tue, 11 Feb 2025 22:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739313120; bh=nNdMjvufG1KwK6bx+D+n9kZhJLtmEZprQWWJSdNVqIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=upjUIQDyR5fFG7FqliMYTHUesOUc7TbFtEYOd8Haus6tJOtyRuCmhYeejce15ZAYm lq7zxyEt0xMnsC5lQGidtt4wYM7UDPvYseFegNz/BrigboHwJenTXzTiDpjmmtLHTC vqOTYTO2RSGu4AImUVEw2CMwB86TWPmgPxZc29Zedk5xMEdP7Vh6CdGCaUELaDVeIb 8Es83Eu9DAX+7JJaWganAA/5YVE8EdSE6EFihiBsclIiDceTHOCMxK0GOyYyFmCeJz cDtJqk4+bwqW531lqsgW0OeJMfveEWSosCMxTvjTo4evuVYZHPugFov2MlvLdn619l 2kkkriaqNnFgA== Date: Tue, 11 Feb 2025 14:31:59 -0800 From: "Darrick J. Wong" To: Stephen Rothwell Cc: David Chinner , Carlos Maiolino , linux-xfs@vger.kernel.org, Linux Kernel Mailing List , Linux Next Mailing List Subject: Re: linux-next: Fixes tag needs some work in the xfs tree Message-ID: <20250211223159.GF3028674@frogsfrogsfrogs> References: <20250212082141.26dc0ad8@canb.auug.org.au> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212082141.26dc0ad8@canb.auug.org.au> On Wed, Feb 12, 2025 at 08:21:41AM +1100, Stephen Rothwell wrote: > Hi all, > > In commit > > bc0651d93a7b ("xfs: fix online repair probing when CONFIG_XFS_ONLINE_REPAIR=n") > > Fixes tag > > Fixes: 48a72f60861f79 ("xfs: don't complain about unfixed metadata when repairs were injected") > > has these problem(s): > > - Subject does not match target commit subject > Just use > git log -1 --format='Fixes: %h ("%s")' > > maybe you meant > > Fixes: 48a72f60861f ("xfs: refactor repair forcing tests into a repair.c helper") > > or > > Fixes: 8336a64eb75c ("xfs: don't complain about unfixed metadata when repairs were injected") Yes, 8336a64eb75c. This patch has been on the list for a month now, and nobody complained. Probably because people aren't good at distinguishing one sequence of hexadecimal from another. Could we /please/ have a bot to warn about these annotation problems when patches are on the list for review, rather than a month later after it finally enters for-next, without any of the authors, reviewers, or maintainers having noticed? Maybe the rest of you are all excellent at this, and I should just fuck off and quit. --D > -- > Cheers, > Stephen Rothwell