* [PATCH 01/10] exportfs: add module description
@ 2025-03-24 17:32 Arnd Bergmann
2025-03-24 17:32 ` [PATCH 02/10] ASN.1: " Arnd Bergmann
` (9 more replies)
0 siblings, 10 replies; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Chuck Lever,
Jeff Layton
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Amir Goldstein,
Christian Brauner, NeilBrown, linux-fsdevel, linux-nfs,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Every loadable module should have a description, to avoid a warning such as:
WARNING: modpost: missing MODULE_DESCRIPTION() in fs/exportfs/exportfs.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/exportfs/expfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c
index b5845c4846b8..8a5f42c620af 100644
--- a/fs/exportfs/expfs.c
+++ b/fs/exportfs/expfs.c
@@ -608,4 +608,5 @@ struct dentry *exportfs_decode_fh(struct vfsmount *mnt, struct fid *fid,
}
EXPORT_SYMBOL_GPL(exportfs_decode_fh);
+MODULE_DESCRIPTION("Code mapping from inodes to NFS file handles");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 02/10] ASN.1: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-04-06 18:21 ` Geert Uytterhoeven
2025-03-24 17:32 ` [PATCH 03/10] samples/livepatch: add module descriptions Arnd Bergmann
` (8 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This is needed to avoid a build warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/asn1_decoder.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/asn1_decoder.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/asn1_decoder.c b/lib/asn1_decoder.c
index 13da529e2e72..5738ae286b41 100644
--- a/lib/asn1_decoder.c
+++ b/lib/asn1_decoder.c
@@ -518,4 +518,5 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder,
}
EXPORT_SYMBOL_GPL(asn1_ber_decoder);
+MODULE_DESCRIPTION("Decoder for ASN.1 BER/DER/CER encoded bytestream");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 03/10] samples/livepatch: add module descriptions
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
2025-03-24 17:32 ` [PATCH 02/10] ASN.1: " Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-25 10:01 ` Petr Mladek
2025-03-24 17:32 ` [PATCH 04/10] fpga: tests: " Arnd Bergmann
` (7 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Josh Poimboeuf,
Jiri Kosina, Miroslav Benes, Petr Mladek
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Joe Lawrence,
Christophe Leroy, Easwar Hariharan, live-patching, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Every module should have a description, so add one for each of these modules.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
samples/livepatch/livepatch-callbacks-busymod.c | 1 +
samples/livepatch/livepatch-callbacks-demo.c | 1 +
samples/livepatch/livepatch-callbacks-mod.c | 1 +
samples/livepatch/livepatch-sample.c | 1 +
samples/livepatch/livepatch-shadow-fix1.c | 1 +
samples/livepatch/livepatch-shadow-fix2.c | 1 +
6 files changed, 6 insertions(+)
diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c
index 69105596e72e..4d6030739fcb 100644
--- a/samples/livepatch/livepatch-callbacks-busymod.c
+++ b/samples/livepatch/livepatch-callbacks-busymod.c
@@ -56,4 +56,5 @@ static void livepatch_callbacks_mod_exit(void)
module_init(livepatch_callbacks_mod_init);
module_exit(livepatch_callbacks_mod_exit);
+MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks");
MODULE_LICENSE("GPL");
diff --git a/samples/livepatch/livepatch-callbacks-demo.c b/samples/livepatch/livepatch-callbacks-demo.c
index 11c3f4357812..9e69d9caed25 100644
--- a/samples/livepatch/livepatch-callbacks-demo.c
+++ b/samples/livepatch/livepatch-callbacks-demo.c
@@ -192,5 +192,6 @@ static void livepatch_callbacks_demo_exit(void)
module_init(livepatch_callbacks_demo_init);
module_exit(livepatch_callbacks_demo_exit);
+MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks");
MODULE_LICENSE("GPL");
MODULE_INFO(livepatch, "Y");
diff --git a/samples/livepatch/livepatch-callbacks-mod.c b/samples/livepatch/livepatch-callbacks-mod.c
index 2a074f422a51..d1851b471ad9 100644
--- a/samples/livepatch/livepatch-callbacks-mod.c
+++ b/samples/livepatch/livepatch-callbacks-mod.c
@@ -38,4 +38,5 @@ static void livepatch_callbacks_mod_exit(void)
module_init(livepatch_callbacks_mod_init);
module_exit(livepatch_callbacks_mod_exit);
+MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks, support module");
MODULE_LICENSE("GPL");
diff --git a/samples/livepatch/livepatch-sample.c b/samples/livepatch/livepatch-sample.c
index cd76d7ebe598..5263a2f31c48 100644
--- a/samples/livepatch/livepatch-sample.c
+++ b/samples/livepatch/livepatch-sample.c
@@ -66,5 +66,6 @@ static void livepatch_exit(void)
module_init(livepatch_init);
module_exit(livepatch_exit);
+MODULE_DESCRIPTION("Kernel Live Patching Sample Module");
MODULE_LICENSE("GPL");
MODULE_INFO(livepatch, "Y");
diff --git a/samples/livepatch/livepatch-shadow-fix1.c b/samples/livepatch/livepatch-shadow-fix1.c
index f3f153895d6c..cbf68ca40097 100644
--- a/samples/livepatch/livepatch-shadow-fix1.c
+++ b/samples/livepatch/livepatch-shadow-fix1.c
@@ -168,5 +168,6 @@ static void livepatch_shadow_fix1_exit(void)
module_init(livepatch_shadow_fix1_init);
module_exit(livepatch_shadow_fix1_exit);
+MODULE_DESCRIPTION("Live patching demo for shadow variables");
MODULE_LICENSE("GPL");
MODULE_INFO(livepatch, "Y");
diff --git a/samples/livepatch/livepatch-shadow-fix2.c b/samples/livepatch/livepatch-shadow-fix2.c
index 361046a4f10c..b99122cb221f 100644
--- a/samples/livepatch/livepatch-shadow-fix2.c
+++ b/samples/livepatch/livepatch-shadow-fix2.c
@@ -128,5 +128,6 @@ static void livepatch_shadow_fix2_exit(void)
module_init(livepatch_shadow_fix2_init);
module_exit(livepatch_shadow_fix2_exit);
+MODULE_DESCRIPTION("Live patching demo for shadow variables");
MODULE_LICENSE("GPL");
MODULE_INFO(livepatch, "Y");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 04/10] fpga: tests: add module descriptions
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
2025-03-24 17:32 ` [PATCH 02/10] ASN.1: " Arnd Bergmann
2025-03-24 17:32 ` [PATCH 03/10] samples/livepatch: add module descriptions Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-25 17:06 ` Marco Pagani
2025-03-24 17:32 ` [PATCH 05/10] xenbus: add module description Arnd Bergmann
` (6 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Moritz Fischer,
Wu Hao, Xu Yilun
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Tom Rix,
Marco Pagani, Russ Weight, linux-fpga, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-bridge-test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-mgr-test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-region-test.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/fpga/tests/fpga-bridge-test.c | 1 +
drivers/fpga/tests/fpga-mgr-test.c | 1 +
drivers/fpga/tests/fpga-region-test.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c
index b9ab29809e96..124ba40e32b1 100644
--- a/drivers/fpga/tests/fpga-bridge-test.c
+++ b/drivers/fpga/tests/fpga-bridge-test.c
@@ -170,4 +170,5 @@ static struct kunit_suite fpga_bridge_suite = {
kunit_test_suite(fpga_bridge_suite);
+MODULE_DESCRIPTION("KUnit test for the FPGA Bridge");
MODULE_LICENSE("GPL");
diff --git a/drivers/fpga/tests/fpga-mgr-test.c b/drivers/fpga/tests/fpga-mgr-test.c
index 9cb37aefbac4..8748babb0504 100644
--- a/drivers/fpga/tests/fpga-mgr-test.c
+++ b/drivers/fpga/tests/fpga-mgr-test.c
@@ -330,4 +330,5 @@ static struct kunit_suite fpga_mgr_suite = {
kunit_test_suite(fpga_mgr_suite);
+MODULE_DESCRIPTION("KUnit test for the FPGA Manager");
MODULE_LICENSE("GPL");
diff --git a/drivers/fpga/tests/fpga-region-test.c b/drivers/fpga/tests/fpga-region-test.c
index 6a108cafded8..020ceac48509 100644
--- a/drivers/fpga/tests/fpga-region-test.c
+++ b/drivers/fpga/tests/fpga-region-test.c
@@ -214,4 +214,5 @@ static struct kunit_suite fpga_region_suite = {
kunit_test_suite(fpga_region_suite);
+MODULE_DESCRIPTION("KUnit test for the FPGA Region");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 05/10] xenbus: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (2 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 04/10] fpga: tests: " Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-27 16:43 ` Jürgen Groß
2025-03-24 17:32 ` [PATCH 06/10] zlib: " Arnd Bergmann
` (5 subsequent siblings)
9 siblings, 1 reply; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Juergen Gross,
Stefano Stabellini
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Oleksandr Tyshchenko,
xen-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xenbus/xenbus_probe_frontend.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/xen/xenbus/xenbus_probe_frontend.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
index fcb335bb7b18..8b75f8234baf 100644
--- a/drivers/xen/xenbus/xenbus_probe_frontend.c
+++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
@@ -513,4 +513,5 @@ static int __init boot_wait_for_devices(void)
late_initcall(boot_wait_for_devices);
#endif
+MODULE_DESCRIPTION("Frontend for Xen bus probe");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 06/10] zlib: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (3 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 05/10] xenbus: add module description Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-24 17:32 ` [PATCH 07/10] ucs2_string: " Arnd Bergmann
` (4 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/zlib_inflate/zlib_inflate.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/zlib_inflate/inflate_syms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/zlib_inflate/inflate_syms.c b/lib/zlib_inflate/inflate_syms.c
index 9720114c0672..b8996d90e8bc 100644
--- a/lib/zlib_inflate/inflate_syms.c
+++ b/lib/zlib_inflate/inflate_syms.c
@@ -18,4 +18,5 @@ EXPORT_SYMBOL(zlib_inflateEnd);
EXPORT_SYMBOL(zlib_inflateReset);
EXPORT_SYMBOL(zlib_inflateIncomp);
EXPORT_SYMBOL(zlib_inflate_blob);
+MODULE_DESCRIPTION("Data decompression using the deflation algorithm");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 07/10] ucs2_string: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (4 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 06/10] zlib: " Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-24 17:32 ` [PATCH 08/10] kunit: add module description for backtrace suppression test Arnd Bergmann
` (3 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/ucs2_string.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/ucs2_string.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ucs2_string.c b/lib/ucs2_string.c
index 9308bcfb2ad5..dfb4f2358cab 100644
--- a/lib/ucs2_string.c
+++ b/lib/ucs2_string.c
@@ -165,4 +165,5 @@ ucs2_as_utf8(u8 *dest, const ucs2_char_t *src, unsigned long maxlength)
}
EXPORT_SYMBOL(ucs2_as_utf8);
+MODULE_DESCRIPTION("UCS2 string handling");
MODULE_LICENSE("GPL v2");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 08/10] kunit: add module description for backtrace suppression test
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (5 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 07/10] ucs2_string: " Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-24 17:32 ` [PATCH 09/10] mm/kasan: add module decription Arnd Bergmann
` (2 subsequent siblings)
9 siblings, 0 replies; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Brendan Higgins,
David Gow, Guenter Roeck, Kees Cook, Alessandro Carminati,
Dan Carpenter
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Rae Moar,
linux-kselftest, kunit-dev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The module was added but has no description:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/kunit/backtrace-suppression-test.o
Fixes: ebf1c420422a ("kunit: add test cases for backtrace warning suppression")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/kunit/backtrace-suppression-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/kunit/backtrace-suppression-test.c b/lib/kunit/backtrace-suppression-test.c
index 8b4125af2481..1ceb30c736d7 100644
--- a/lib/kunit/backtrace-suppression-test.c
+++ b/lib/kunit/backtrace-suppression-test.c
@@ -102,3 +102,4 @@ static struct kunit_suite backtrace_suppression_test_suite = {
kunit_test_suites(&backtrace_suppression_test_suite);
MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit test for suppressing warning tracebacks");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 09/10] mm/kasan: add module decription
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (6 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 08/10] kunit: add module description for backtrace suppression test Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-24 22:00 ` Andrey Konovalov
2025-03-24 17:32 ` [PATCH 10/10] kunit: slub: add module description Arnd Bergmann
2025-03-25 14:58 ` (subset) [PATCH 01/10] exportfs: " Christian Brauner
9 siblings, 1 reply; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada, Andrey Ryabinin
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Alexander Potapenko,
Andrey Konovalov, Dmitry Vyukov, Vincenzo Frascino,
Sabyrzhan Tasbolatov, Marco Elver, Nihar Chaithanya, Jann Horn,
Peter Zijlstra, kasan-dev, linux-mm, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in mm/kasan/kasan_test.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
mm/kasan/kasan_test_c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
index 59d673400085..710684ffe302 100644
--- a/mm/kasan/kasan_test_c.c
+++ b/mm/kasan/kasan_test_c.c
@@ -2130,4 +2130,5 @@ static struct kunit_suite kasan_kunit_test_suite = {
kunit_test_suite(kasan_kunit_test_suite);
+MODULE_DESCRIPTION("kunit test case for kasan");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH 10/10] kunit: slub: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (7 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 09/10] mm/kasan: add module decription Arnd Bergmann
@ 2025-03-24 17:32 ` Arnd Bergmann
2025-03-25 14:58 ` (subset) [PATCH 01/10] exportfs: " Christian Brauner
9 siblings, 0 replies; 18+ messages in thread
From: Arnd Bergmann @ 2025-03-24 17:32 UTC (permalink / raw)
To: Jeff Johnson, Andrew Morton, Masahiro Yamada
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Vlastimil Babka,
Rae Moar, Pei Xiao, Feng Tang, Guenter Roeck, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Modules without a description now cause a warning:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/tests/slub_kunit.o
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/tests/slub_kunit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/tests/slub_kunit.c b/lib/tests/slub_kunit.c
index d47c472b0520..848b682a2d70 100644
--- a/lib/tests/slub_kunit.c
+++ b/lib/tests/slub_kunit.c
@@ -325,4 +325,5 @@ static struct kunit_suite test_suite = {
};
kunit_test_suite(test_suite);
+MODULE_DESCRIPTION("Kunit tests for slub allocator");
MODULE_LICENSE("GPL");
--
2.39.5
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH 09/10] mm/kasan: add module decription
2025-03-24 17:32 ` [PATCH 09/10] mm/kasan: add module decription Arnd Bergmann
@ 2025-03-24 22:00 ` Andrey Konovalov
0 siblings, 0 replies; 18+ messages in thread
From: Andrey Konovalov @ 2025-03-24 22:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jeff Johnson, Andrew Morton, Masahiro Yamada, Andrey Ryabinin,
Stephen Rothwell, linux-next, Arnd Bergmann, Alexander Potapenko,
Dmitry Vyukov, Vincenzo Frascino, Sabyrzhan Tasbolatov,
Marco Elver, Nihar Chaithanya, Jann Horn, Peter Zijlstra,
kasan-dev, linux-mm, linux-kernel
On Mon, Mar 24, 2025 at 6:34 PM 'Arnd Bergmann' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Modules without a description now cause a warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in mm/kasan/kasan_test.o
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> mm/kasan/kasan_test_c.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c
> index 59d673400085..710684ffe302 100644
> --- a/mm/kasan/kasan_test_c.c
> +++ b/mm/kasan/kasan_test_c.c
> @@ -2130,4 +2130,5 @@ static struct kunit_suite kasan_kunit_test_suite = {
>
> kunit_test_suite(kasan_kunit_test_suite);
>
> +MODULE_DESCRIPTION("kunit test case for kasan");
> MODULE_LICENSE("GPL");
> --
> 2.39.5
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
But just in case you end up sending a v2, let's change the text to
"KUnit tests for checking KASAN bug-detection capabilities".
Thank you!
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 03/10] samples/livepatch: add module descriptions
2025-03-24 17:32 ` [PATCH 03/10] samples/livepatch: add module descriptions Arnd Bergmann
@ 2025-03-25 10:01 ` Petr Mladek
2025-03-25 15:03 ` Jeff Johnson
0 siblings, 1 reply; 18+ messages in thread
From: Petr Mladek @ 2025-03-25 10:01 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jeff Johnson, Andrew Morton, Masahiro Yamada, Josh Poimboeuf,
Jiri Kosina, Miroslav Benes, Stephen Rothwell, linux-next,
Arnd Bergmann, Joe Lawrence, Christophe Leroy, Easwar Hariharan,
live-patching, linux-kernel
On Mon 2025-03-24 18:32:28, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Every module should have a description, so add one for each of these modules.
>
> --- a/samples/livepatch/livepatch-callbacks-busymod.c
> +++ b/samples/livepatch/livepatch-callbacks-busymod.c
> @@ -56,4 +56,5 @@ static void livepatch_callbacks_mod_exit(void)
>
> module_init(livepatch_callbacks_mod_init);
> module_exit(livepatch_callbacks_mod_exit);
> +MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks");
This is another support module similar to livepatch-callbacks-mod.c.
I would use the same description, here:
MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks, support module");
> MODULE_LICENSE("GPL");
> diff --git a/samples/livepatch/livepatch-callbacks-demo.c b/samples/livepatch/livepatch-callbacks-demo.c
> index 11c3f4357812..9e69d9caed25 100644
> --- a/samples/livepatch/livepatch-callbacks-demo.c
> +++ b/samples/livepatch/livepatch-callbacks-demo.c
> @@ -192,5 +192,6 @@ static void livepatch_callbacks_demo_exit(void)
>
> module_init(livepatch_callbacks_demo_init);
> module_exit(livepatch_callbacks_demo_exit);
> +MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks");
> MODULE_LICENSE("GPL");
> MODULE_INFO(livepatch, "Y");
> diff --git a/samples/livepatch/livepatch-callbacks-mod.c b/samples/livepatch/livepatch-callbacks-mod.c
> index 2a074f422a51..d1851b471ad9 100644
> --- a/samples/livepatch/livepatch-callbacks-mod.c
> +++ b/samples/livepatch/livepatch-callbacks-mod.c
> @@ -38,4 +38,5 @@ static void livepatch_callbacks_mod_exit(void)
>
> module_init(livepatch_callbacks_mod_init);
> module_exit(livepatch_callbacks_mod_exit);
> +MODULE_DESCRIPTION("Live patching demo for (un)patching callbacks, support module");
> MODULE_LICENSE("GPL");
The rest looks good. With the above change:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks a lot for fixing this.
Arnd, should I push this via the livepatch tree or would you prefer to push
the entire patchset together? Both ways work for me.
Best Regards,
Petr
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH 01/10] exportfs: add module description
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
` (8 preceding siblings ...)
2025-03-24 17:32 ` [PATCH 10/10] kunit: slub: add module description Arnd Bergmann
@ 2025-03-25 14:58 ` Christian Brauner
9 siblings, 0 replies; 18+ messages in thread
From: Christian Brauner @ 2025-03-25 14:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Christian Brauner, Stephen Rothwell, linux-next, Arnd Bergmann,
Amir Goldstein, NeilBrown, linux-fsdevel, linux-nfs, linux-kernel,
Jeff Johnson, Andrew Morton, Masahiro Yamada, Chuck Lever,
Jeff Layton
On Mon, 24 Mar 2025 18:32:26 +0100, Arnd Bergmann wrote:
> Every loadable module should have a description, to avoid a warning such as:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in fs/exportfs/exportfs.o
>
>
I've removed mentioning of NFS from the module description because
exportfs is now used for a lot more.
---
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[01/10] exportfs: add module description
https://git.kernel.org/vfs/vfs/c/e3206c4aa06f
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 03/10] samples/livepatch: add module descriptions
2025-03-25 10:01 ` Petr Mladek
@ 2025-03-25 15:03 ` Jeff Johnson
0 siblings, 0 replies; 18+ messages in thread
From: Jeff Johnson @ 2025-03-25 15:03 UTC (permalink / raw)
To: Petr Mladek, Arnd Bergmann
Cc: Andrew Morton, Masahiro Yamada, Josh Poimboeuf, Jiri Kosina,
Miroslav Benes, Stephen Rothwell, linux-next, Arnd Bergmann,
Joe Lawrence, Christophe Leroy, Easwar Hariharan, live-patching,
linux-kernel
On 3/25/2025 3:01 AM, Petr Mladek wrote:
> Arnd, should I push this via the livepatch tree or would you prefer to push
> the entire patchset together? Both ways work for me.
My past experience was to let individual maintainers take the ones that apply
to their trees, and then Andrew can pick up the stragglers.
/jeff
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 04/10] fpga: tests: add module descriptions
2025-03-24 17:32 ` [PATCH 04/10] fpga: tests: " Arnd Bergmann
@ 2025-03-25 17:06 ` Marco Pagani
2025-04-25 4:27 ` Xu Yilun
0 siblings, 1 reply; 18+ messages in thread
From: Marco Pagani @ 2025-03-25 17:06 UTC (permalink / raw)
To: Arnd Bergmann, Jeff Johnson, Andrew Morton, Masahiro Yamada,
Moritz Fischer, Wu Hao, Xu Yilun
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Tom Rix,
Marco Pagani, Russ Weight, linux-fpga, linux-kernel
On 2025-03-24 18:32, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Modules without a description now cause a warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-bridge-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-mgr-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-region-test.o
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marco Pagani <marco.pagani@linux.dev>
> ---
> drivers/fpga/tests/fpga-bridge-test.c | 1 +
> drivers/fpga/tests/fpga-mgr-test.c | 1 +
> drivers/fpga/tests/fpga-region-test.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c
> index b9ab29809e96..124ba40e32b1 100644
> --- a/drivers/fpga/tests/fpga-bridge-test.c
> +++ b/drivers/fpga/tests/fpga-bridge-test.c
> @@ -170,4 +170,5 @@ static struct kunit_suite fpga_bridge_suite = {
>
> kunit_test_suite(fpga_bridge_suite);
>
> +MODULE_DESCRIPTION("KUnit test for the FPGA Bridge");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/fpga/tests/fpga-mgr-test.c b/drivers/fpga/tests/fpga-mgr-test.c
> index 9cb37aefbac4..8748babb0504 100644
> --- a/drivers/fpga/tests/fpga-mgr-test.c
> +++ b/drivers/fpga/tests/fpga-mgr-test.c
> @@ -330,4 +330,5 @@ static struct kunit_suite fpga_mgr_suite = {
>
> kunit_test_suite(fpga_mgr_suite);
>
> +MODULE_DESCRIPTION("KUnit test for the FPGA Manager");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/fpga/tests/fpga-region-test.c b/drivers/fpga/tests/fpga-region-test.c
> index 6a108cafded8..020ceac48509 100644
> --- a/drivers/fpga/tests/fpga-region-test.c
> +++ b/drivers/fpga/tests/fpga-region-test.c
> @@ -214,4 +214,5 @@ static struct kunit_suite fpga_region_suite = {
>
> kunit_test_suite(fpga_region_suite);
>
> +MODULE_DESCRIPTION("KUnit test for the FPGA Region");
> MODULE_LICENSE("GPL");
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 05/10] xenbus: add module description
2025-03-24 17:32 ` [PATCH 05/10] xenbus: add module description Arnd Bergmann
@ 2025-03-27 16:43 ` Jürgen Groß
0 siblings, 0 replies; 18+ messages in thread
From: Jürgen Groß @ 2025-03-27 16:43 UTC (permalink / raw)
To: Arnd Bergmann, Jeff Johnson, Andrew Morton, Masahiro Yamada,
Stefano Stabellini
Cc: Stephen Rothwell, linux-next, Arnd Bergmann, Oleksandr Tyshchenko,
xen-devel, linux-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 900 bytes --]
On 24.03.25 18:32, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Modules without a description now cause a warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/xen/xenbus/xenbus_probe_frontend.o
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/xen/xenbus/xenbus_probe_frontend.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/xen/xenbus/xenbus_probe_frontend.c b/drivers/xen/xenbus/xenbus_probe_frontend.c
> index fcb335bb7b18..8b75f8234baf 100644
> --- a/drivers/xen/xenbus/xenbus_probe_frontend.c
> +++ b/drivers/xen/xenbus/xenbus_probe_frontend.c
> @@ -513,4 +513,5 @@ static int __init boot_wait_for_devices(void)
> late_initcall(boot_wait_for_devices);
> #endif
>
> +MODULE_DESCRIPTION("Frontend for Xen bus probe");
May I suggest "Xen PV-device frontend support" instead?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 02/10] ASN.1: add module description
2025-03-24 17:32 ` [PATCH 02/10] ASN.1: " Arnd Bergmann
@ 2025-04-06 18:21 ` Geert Uytterhoeven
0 siblings, 0 replies; 18+ messages in thread
From: Geert Uytterhoeven @ 2025-04-06 18:21 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jeff Johnson, Andrew Morton, Masahiro Yamada, Stephen Rothwell,
linux-next, Arnd Bergmann, linux-kernel, Linus Torvalds
Hi Arnd,
On Mon, 24 Mar 2025 at 18:35, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is needed to avoid a build warning:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/asn1_decoder.o
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank, this fixes build issues in the m68k defconfigs
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- a/lib/asn1_decoder.c
> +++ b/lib/asn1_decoder.c
> @@ -518,4 +518,5 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder,
> }
> EXPORT_SYMBOL_GPL(asn1_ber_decoder);
>
> +MODULE_DESCRIPTION("Decoder for ASN.1 BER/DER/CER encoded bytestream");
> MODULE_LICENSE("GPL");
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 04/10] fpga: tests: add module descriptions
2025-03-25 17:06 ` Marco Pagani
@ 2025-04-25 4:27 ` Xu Yilun
0 siblings, 0 replies; 18+ messages in thread
From: Xu Yilun @ 2025-04-25 4:27 UTC (permalink / raw)
To: Marco Pagani
Cc: Arnd Bergmann, Jeff Johnson, Andrew Morton, Masahiro Yamada,
Moritz Fischer, Wu Hao, Xu Yilun, Stephen Rothwell, linux-next,
Arnd Bergmann, Tom Rix, Marco Pagani, Russ Weight, linux-fpga,
linux-kernel
On Tue, Mar 25, 2025 at 06:06:51PM +0100, Marco Pagani wrote:
>
> On 2025-03-24 18:32, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Modules without a description now cause a warning:
> >
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-bridge-test.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-mgr-test.o
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-region-test.o
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Marco Pagani <marco.pagani@linux.dev>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next.
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2025-04-25 4:32 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-24 17:32 [PATCH 01/10] exportfs: add module description Arnd Bergmann
2025-03-24 17:32 ` [PATCH 02/10] ASN.1: " Arnd Bergmann
2025-04-06 18:21 ` Geert Uytterhoeven
2025-03-24 17:32 ` [PATCH 03/10] samples/livepatch: add module descriptions Arnd Bergmann
2025-03-25 10:01 ` Petr Mladek
2025-03-25 15:03 ` Jeff Johnson
2025-03-24 17:32 ` [PATCH 04/10] fpga: tests: " Arnd Bergmann
2025-03-25 17:06 ` Marco Pagani
2025-04-25 4:27 ` Xu Yilun
2025-03-24 17:32 ` [PATCH 05/10] xenbus: add module description Arnd Bergmann
2025-03-27 16:43 ` Jürgen Groß
2025-03-24 17:32 ` [PATCH 06/10] zlib: " Arnd Bergmann
2025-03-24 17:32 ` [PATCH 07/10] ucs2_string: " Arnd Bergmann
2025-03-24 17:32 ` [PATCH 08/10] kunit: add module description for backtrace suppression test Arnd Bergmann
2025-03-24 17:32 ` [PATCH 09/10] mm/kasan: add module decription Arnd Bergmann
2025-03-24 22:00 ` Andrey Konovalov
2025-03-24 17:32 ` [PATCH 10/10] kunit: slub: add module description Arnd Bergmann
2025-03-25 14:58 ` (subset) [PATCH 01/10] exportfs: " Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).