Linux-Next discussions
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dan Williams <dan.j.williams@intel.com>,
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	<yilun.xu@intel.com>, <sameo@rivosinc.com>, <aik@amd.com>,
	<suzuki.poulose@arm.com>, <steven.price@arm.com>,
	<lukas@wunner.de>, Greg KH <greg@kroah.com>
Cc: "Cedric Xing" <cedric.xing@intel.com>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the devsec-tsm tree
Date: Thu, 8 May 2025 18:10:32 +1000	[thread overview]
Message-ID: <20250508181032.58fc7e5b@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

Hi all,

After merging the devsec-tsm tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/virt/coco/guest/tsm-mr.c: In function 'tsm_mr_create_attribute_group':
drivers/virt/coco/guest/tsm-mr.c:228:29: error: assignment to 'const struct bin_attribute * const*' from incompatible pointer type 'struct bin_attribute **' [-Wincompatible-pointer-types]
  228 |         ctx->agrp.bin_attrs = no_free_ptr(bas);
      |                             ^

Caused by commit

  29b07a7b8f41 ("tsm-mr: Add TVM Measurement Register support")

interacting with commit

  9bec944506fa ("sysfs: constify attribute_group::bin_attrs")

from the driver-core tree.

I have applied the following merge resolution for today (there must be
a better solution).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 8 May 2025 17:52:55 +1000
Subject: [PATCH] fix up for "tsm-mr: Add TVM Measurement Register support"

interacting with "sysfs: constify attribute_group::bin_attrs" from the
driver-core tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/virt/coco/guest/tsm-mr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/coco/guest/tsm-mr.c b/drivers/virt/coco/guest/tsm-mr.c
index d75b08548292..37e6650bfb6c 100644
--- a/drivers/virt/coco/guest/tsm-mr.c
+++ b/drivers/virt/coco/guest/tsm-mr.c
@@ -225,7 +225,7 @@ tsm_mr_create_attribute_group(const struct tsm_measurements *tm)
 
 	init_rwsem(&ctx->rwsem);
 	ctx->agrp.name = "measurements";
-	ctx->agrp.bin_attrs = no_free_ptr(bas);
+	ctx->agrp.bin_attrs = (const struct bin_attribute *const *)no_free_ptr(bas);
 	ctx->tm = tm;
 	return &no_free_ptr(ctx)->agrp;
 }
-- 
2.47.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2025-05-08  8:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08  8:10 Stephen Rothwell [this message]
2025-05-09  0:37 ` linux-next: build failure after merge of the devsec-tsm tree Dan Williams
2025-05-09  7:12   ` Greg KH
2025-05-12 17:40     ` Xing, Cedric
2025-05-12 18:45     ` Dan Williams
2025-05-10  7:05   ` Thomas Weißschuh
2025-05-13  4:56     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250508181032.58fc7e5b@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=aik@amd.com \
    --cc=cedric.xing@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=lukas@wunner.de \
    --cc=sameo@rivosinc.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=steven.price@arm.com \
    --cc=suzuki.poulose@arm.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox