[PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

[PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

[Paul E. McKenney]

PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

Builds with CONFIG_PREEMPT_RT=y get the following build error:

drivers/pci/pcie/bwctrl.c:56:22: error: ‘pcie_bwctrl_lbms_rwsem’ defined but not used [-Werror=unused-variable]

Therefore, remove this unused variable.  Perhaps this should be folded
into the commit shown below.

Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>

diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
index fdafa20e4587d..841ab8725aff7 100644
--- a/drivers/pci/pcie/bwctrl.c
+++ b/drivers/pci/pcie/bwctrl.c
@@ -53,7 +53,6 @@ struct pcie_bwctrl_data {
  * (using just one rwsem triggers "possible recursive locking detected"
  * warning).
  */
-static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
 static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
 
 static bool pcie_valid_speed(enum pci_bus_speed speed)

Re: [PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

On Wed, 7 May 2025, Paul E. McKenney wrote:

> PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem
> 
> Builds with CONFIG_PREEMPT_RT=y get the following build error:
> 
> drivers/pci/pcie/bwctrl.c:56:22: error: ‘pcie_bwctrl_lbms_rwsem’ defined but not used [-Werror=unused-variable]
> 
> Therefore, remove this unused variable.  Perhaps this should be folded
> into the commit shown below.
> 
> Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: <linux-pci@vger.kernel.org>
> 
> diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
> index fdafa20e4587d..841ab8725aff7 100644
> --- a/drivers/pci/pcie/bwctrl.c
> +++ b/drivers/pci/pcie/bwctrl.c
> @@ -53,7 +53,6 @@ struct pcie_bwctrl_data {
>   * (using just one rwsem triggers "possible recursive locking detected"
>   * warning).
>   */
> -static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
>  static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
>  
>  static bool pcie_valid_speed(enum pci_bus_speed speed)
> 

I've a patch which removes not only the rwsem but also the comment details 
related to it. I've just not sent it yet because lkp has been very cranky 
recently to build test things in a reasonable time.

-- 
 i.

Re: [PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

Hi Paul,

On Wed, 7 May 2025 15:04:57 -0700 "Paul E. McKenney" <paulmck@kernel.org> wrote:
>
> PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem
> 
> Builds with CONFIG_PREEMPT_RT=y get the following build error:
> 
> drivers/pci/pcie/bwctrl.c:56:22: error: ‘pcie_bwctrl_lbms_rwsem’ defined but not used [-Werror=unused-variable]
> 
> Therefore, remove this unused variable.  Perhaps this should be folded
> into the commit shown below.
> 
> Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: <linux-pci@vger.kernel.org>
> 
> diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
> index fdafa20e4587d..841ab8725aff7 100644
> --- a/drivers/pci/pcie/bwctrl.c
> +++ b/drivers/pci/pcie/bwctrl.c
> @@ -53,7 +53,6 @@ struct pcie_bwctrl_data {
>   * (using just one rwsem triggers "possible recursive locking detected"
>   * warning).
>   */
> -static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
>  static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
>  
>  static bool pcie_valid_speed(enum pci_bus_speed speed)

I added that to linux-next today and will remove it when it is no
longer needed.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem

[Paul E. McKenney]

On Thu, May 08, 2025 at 07:08:45PM +1000, Stephen Rothwell wrote:
> Hi Paul,
> 
> On Wed, 7 May 2025 15:04:57 -0700 "Paul E. McKenney" <paulmck@kernel.org> wrote:
> >
> > PCI/bwctrl: Remove unused pcie_bwctrl_lbms_rwsem
> > 
> > Builds with CONFIG_PREEMPT_RT=y get the following build error:
> > 
> > drivers/pci/pcie/bwctrl.c:56:22: error: ‘pcie_bwctrl_lbms_rwsem’ defined but not used [-Werror=unused-variable]
> > 
> > Therefore, remove this unused variable.  Perhaps this should be folded
> > into the commit shown below.
> > 
> > Fixes: 0238f352a63a ("PCI/bwctrl: Replace lbms_count with PCI_LINK_LBMS_SEEN flag")
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: <linux-pci@vger.kernel.org>
> > 
> > diff --git a/drivers/pci/pcie/bwctrl.c b/drivers/pci/pcie/bwctrl.c
> > index fdafa20e4587d..841ab8725aff7 100644
> > --- a/drivers/pci/pcie/bwctrl.c
> > +++ b/drivers/pci/pcie/bwctrl.c
> > @@ -53,7 +53,6 @@ struct pcie_bwctrl_data {
> >   * (using just one rwsem triggers "possible recursive locking detected"
> >   * warning).
> >   */
> > -static DECLARE_RWSEM(pcie_bwctrl_lbms_rwsem);
> >  static DECLARE_RWSEM(pcie_bwctrl_setspeed_rwsem);
> >  
> >  static bool pcie_valid_speed(enum pci_bus_speed speed)
> 
> I added that to linux-next today and will remove it when it is no
> longer needed.

Thank you, Stephen!

Ilpo, I look forward to seeing this patch replaced by your improved
version with better comments.

							Thanx, Paul