From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A4FE134D4; Sat, 10 May 2025 01:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=150.107.74.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746839108; cv=none; b=k0nHebENBvqUAQ0JoPuBGBFXW6sspCaPKHVx1AGnDM+f0CBT/3CCyNCLdvPSNdZZ8gczfV5U0Wr99bzvORsz1FpbFSK311kW4aNCB3XzDTyTL17neGB7Z1xY1aSw0uHvAk6zsx2gxaPHX6+NPihRlbv/k1P4p2rsnQWSJW3LVH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746839108; c=relaxed/simple; bh=msKNnWRtmNES3mhPLoAXNUbWW5k32La15cy+3ceDkho=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pdOBn/n5WyyMXAPCQDVTfUXu19FNGSPvkRV5QGwwkCwH1+izWNXYaElLYVuDU7nCumLvqySAXcc0pik7JB5F3ON4yAv5gpq9vWpVIPA4QvSWXiFOaY4i2M/JTIyuGq1XHPDx9B2tD2Mp7Q2dsYmJs8JrsCULcAzbw1HpWMo37s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au; spf=pass smtp.mailfrom=canb.auug.org.au; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b=pJP9HTEm; arc=none smtp.client-ip=150.107.74.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canb.auug.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="pJP9HTEm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=202503; t=1746839099; bh=BcDMEWZprG7/4QiD24tVvS5LuwgJ/uimoKaiXsdNfwY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pJP9HTEmz5FOEBM56qol0g5N6SUdMlFbFZpCq3ExXL/74Sz1avpmYzT0KTq2bdrGV cIRC0a+W8UtU3SQ/QluU+rLoISJzQPmI9VMVwtINra9qUcOdXYugqnZIThnmzhrrzP j0puo3324XuwgSFJzqa1RFOMTagCJ2Shmu1weWpmnAncqrB+H6i5LsA6twye3v70J2 PnkxpFIFN9X2jRIv7kIlXeRI82WD+yL3HwdFBzEc3Cakz1jTCyZ05jMEkc2TbQrP6p vOxc0gRD2vPSwSnWshNnZ9ZRPCynyZbCMD2InxVh7NknZd/OFS5X38uSVFryvpxQz1 2mdNUYWOM6C6A== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4ZvSMY6BwVz4x5k; Sat, 10 May 2025 11:04:57 +1000 (AEST) Date: Sat, 10 May 2025 11:04:55 +1000 From: Stephen Rothwell To: Alexei Starovoitov Cc: Saket Kumar Bhaskar , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , LKML , linux-arm-kernel , linux-stm32@st-md-mailman.stormreply.com, Linux-Next Mailing List , Alexei Starovoitov , Hari Bathini , Madhavan Srinivasan , Andrii Nakryiko , Daniel Borkmann , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Greg KH Subject: Re: [PATCH] selftests/bpf: Fix bpf selftest build error Message-ID: <20250510110455.10c72257@canb.auug.org.au> In-Reply-To: References: <20250509122348.649064-1-skb99@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/993WEPoqNjDikEmM0EjdhpP"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/993WEPoqNjDikEmM0EjdhpP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Alexei, On Fri, 9 May 2025 10:04:18 -0700 Alexei Starovoitov wrote: > > On Fri, May 9, 2025 at 5:24=E2=80=AFAM Saket Kumar Bhaskar wrote: > > > > On linux-next, build for bpf selftest displays an error due to > > mismatch in the expected function signature of bpf_testmod_test_read > > and bpf_testmod_test_write. > > > > Commit 97d06802d10a ("sysfs: constify bin_attribute argument of bin_att= ribute::read/write()") > > changed the required type for struct bin_attribute to const struct bin_= attribute. > > > > To resolve the error, update corresponding signature for the callback. > > > > Reported-by: Venkat Rao Bagalkote > > Closes: https://lore.kernel.org/all/e915da49-2b9a-4c4c-a34f-877f378129f= 6@linux.ibm.com/ > > Signed-off-by: Saket Kumar Bhaskar > > --- > > tools/testing/selftests/bpf/test_kmods/bpf_testmod.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c b/too= ls/testing/selftests/bpf/test_kmods/bpf_testmod.c > > index 2e54b95ad898..194c442580ee 100644 > > --- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > > +++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > > @@ -385,7 +385,7 @@ int bpf_testmod_fentry_ok; > > > > noinline ssize_t > > bpf_testmod_test_read(struct file *file, struct kobject *kobj, > > - struct bin_attribute *bin_attr, > > + const struct bin_attribute *bin_attr, > > char *buf, loff_t off, size_t len) =20 >=20 > You didn't even compile it :( >=20 > Instead of fixing the build, it breaks the build. >=20 > pw-bot: cr This patch is only needed in linux-next. It should be applied to the driver-core tree - since that includes commit 97d06802d10a. It should also have a Fixes tag referencing commit 97d06802d10a. --=20 Cheers, Stephen Rothwell --Sig_/993WEPoqNjDikEmM0EjdhpP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmgepjcACgkQAVBC80lX 0GxVWwf/ZkvwI39VdsR9Cc6eDfSrM4MHj5NBvGGV6tUNoYclSENR/DyT+68SZ798 AzGX3tpbarQ3OT/LAbWpSMAl62GzV22LVn3R5+6W/067tygXXF97X7tmEr6kPIfH csvUrXewvX7QLH0BO1MTMRHHdjlgydBY86wPmMWi7HOuxDRJhzGCeit3hWfCEdA7 OyKyOwzemjv7PrRwe/ybaZXnq2tdLYF1YNiFqUVsVrGu2WMCfnkE6nBaCT5+cUbX biLx1adyPWW5NMo4wf0gMwF24JvcS8IjcRZcL2e3UfWMhaGLGZ7EN4aOYX9bq0mL EtYXBv74Qm7vWGhjtommtPMxlU2ILg== =yAPB -----END PGP SIGNATURE----- --Sig_/993WEPoqNjDikEmM0EjdhpP--