* [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning
@ 2025-05-12 9:15 Saket Kumar Bhaskar
2025-05-12 9:23 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Saket Kumar Bhaskar @ 2025-05-12 9:15 UTC (permalink / raw)
To: gregkh
Cc: bpf, linux-kselftest, linux-kernel, linux-next, hbathini, maddy,
venkat88, sfr, alexei.starovoitov, daniel, mykolal,
yoong.siang.song, martin.lau, song, yonghong.song, john.fastabend,
kpsingh, sdf, haoluo, jolsa, shuah
On linux-next, build for bpf selftest displays a warning:
Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h'
differs from latest version at 'include/uapi/linux/if_xdp.h'.
Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers")
changed the header guard from _LINUX_IF_XDP_H to _UAPI_LINUX_IF_XDP_H
in include/uapi/linux/if_xdp.h.
To resolve the warning, update tools/include/uapi/linux/if_xdp.h
to align with the changes in include/uapi/linux/if_xdp.h
Fixes: 8066e388be48 ("net: add UAPI to the header guard in various network headers")
Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Closes: https://lore.kernel.org/all/c2bc466d-dff2-4d0d-a797-9af7f676c065@linux.ibm.com/
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
---
[RESEND]:
- Added Fixes and Tested-by tag.
- Added Greg as receipent for driver-core tree.
Original patch: https://lore.kernel.org/all/20250509123802.695574-1-skb99@linux.ibm.com/
tools/include/uapi/linux/if_xdp.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/include/uapi/linux/if_xdp.h b/tools/include/uapi/linux/if_xdp.h
index 42869770776e..44f2bb93e7e6 100644
--- a/tools/include/uapi/linux/if_xdp.h
+++ b/tools/include/uapi/linux/if_xdp.h
@@ -7,8 +7,8 @@
* Magnus Karlsson <magnus.karlsson@intel.com>
*/
-#ifndef _LINUX_IF_XDP_H
-#define _LINUX_IF_XDP_H
+#ifndef _UAPI_LINUX_IF_XDP_H
+#define _UAPI_LINUX_IF_XDP_H
#include <linux/types.h>
@@ -180,4 +180,4 @@ struct xdp_desc {
/* TX packet carries valid metadata. */
#define XDP_TX_METADATA (1 << 1)
-#endif /* _LINUX_IF_XDP_H */
+#endif /* _UAPI_LINUX_IF_XDP_H */
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning
2025-05-12 9:15 [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning Saket Kumar Bhaskar
@ 2025-05-12 9:23 ` Greg KH
2025-05-13 0:08 ` Alexei Starovoitov
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2025-05-12 9:23 UTC (permalink / raw)
To: Saket Kumar Bhaskar
Cc: bpf, linux-kselftest, linux-kernel, linux-next, hbathini, maddy,
venkat88, sfr, alexei.starovoitov, daniel, mykolal,
yoong.siang.song, martin.lau, song, yonghong.song, john.fastabend,
kpsingh, sdf, haoluo, jolsa, shuah
On Mon, May 12, 2025 at 02:45:11PM +0530, Saket Kumar Bhaskar wrote:
> On linux-next, build for bpf selftest displays a warning:
>
> Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h'
> differs from latest version at 'include/uapi/linux/if_xdp.h'.
>
> Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers")
> changed the header guard from _LINUX_IF_XDP_H to _UAPI_LINUX_IF_XDP_H
> in include/uapi/linux/if_xdp.h.
>
> To resolve the warning, update tools/include/uapi/linux/if_xdp.h
> to align with the changes in include/uapi/linux/if_xdp.h
>
> Fixes: 8066e388be48 ("net: add UAPI to the header guard in various network headers")
> Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Closes: https://lore.kernel.org/all/c2bc466d-dff2-4d0d-a797-9af7f676c065@linux.ibm.com/
> Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
> ---
>
> [RESEND]:
> - Added Fixes and Tested-by tag.
> - Added Greg as receipent for driver-core tree.
Why? Commit 8066e388be48 ("net: add UAPI to the header guard in various
network headers") is not in that tree/branch, so why do I need it?
confused,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning
2025-05-12 9:23 ` Greg KH
@ 2025-05-13 0:08 ` Alexei Starovoitov
0 siblings, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2025-05-13 0:08 UTC (permalink / raw)
To: Greg KH, Network Development, Jakub Kicinski
Cc: Saket Kumar Bhaskar, bpf, open list:KERNEL SELFTEST FRAMEWORK,
LKML, Linux-Next Mailing List, Hari Bathini, Madhavan Srinivasan,
Venkat Rao Bagalkote, Stephen Rothwell, Daniel Borkmann,
Mykola Lysenko, Song, Yoong Siang, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Stanislav Fomichev,
Hao Luo, Jiri Olsa, Shuah Khan
On Mon, May 12, 2025 at 2:23 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Mon, May 12, 2025 at 02:45:11PM +0530, Saket Kumar Bhaskar wrote:
> > On linux-next, build for bpf selftest displays a warning:
> >
> > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h'
> > differs from latest version at 'include/uapi/linux/if_xdp.h'.
> >
> > Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers")
> > changed the header guard from _LINUX_IF_XDP_H to _UAPI_LINUX_IF_XDP_H
> > in include/uapi/linux/if_xdp.h.
> >
> > To resolve the warning, update tools/include/uapi/linux/if_xdp.h
> > to align with the changes in include/uapi/linux/if_xdp.h
> >
> > Fixes: 8066e388be48 ("net: add UAPI to the header guard in various network headers")
> > Reported-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> > Closes: https://lore.kernel.org/all/c2bc466d-dff2-4d0d-a797-9af7f676c065@linux.ibm.com/
> > Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
> > Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com>
> > ---
> >
> > [RESEND]:
> > - Added Fixes and Tested-by tag.
> > - Added Greg as receipent for driver-core tree.
>
> Why? Commit 8066e388be48 ("net: add UAPI to the header guard in various
> network headers") is not in that tree/branch, so why do I need it?
Certainly not driver-core.
Please resend with [PATCH net-next] and cc netdev.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-13 0:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-12 9:15 [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning Saket Kumar Bhaskar
2025-05-12 9:23 ` Greg KH
2025-05-13 0:08 ` Alexei Starovoitov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox