linux-next: build failure after merge of the kbuild tree

linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi all,

After merging the kbuild tree, today's linux-next build (i386 defconfig)
failed like this:

ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
.vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'

Caused by commit

  c4b487ddc51f ("modpost: Create modalias for builtin modules")

I have reverted that commit, along with its parent and child, for
today.  It's parent commit

  66ef3890c628 ("modpost: Add modname to mod_device_table alias")

generated this warning in the i386 defconfig build:

scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
 1480 |         size_t typelen, modnamelen;
      |                         ^~~~~~~~~~

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH] kbuild: modpost: Fix the order of includes in .vmlinux.export.c

[Alexey Gladkov]

The linux/module.h cannot be used at the beginning of file because
linux/dynamic_debug.h adds linux/string.h and then string_32.h, where
some functions may be redefined as `__builtin_<name>` under certain
conditions.

This results in the following error (i386 defconfig):

ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
.vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'

Link: https://lore.kernel.org/all/20250730161223.63783458@canb.auug.org.au/
Fixes: c4b487ddc51f ("modpost: Create modalias for builtin modules")
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
 scripts/mod/modpost.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 67f9cd76bdd2..47c8aa2a6939 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -2070,12 +2070,12 @@ static void write_vmlinux_export_c_file(struct module *mod)
 	struct module_alias *alias, *next;
 
 	buf_printf(&buf,
-		   "#include <linux/export-internal.h>\n"
-		   "#include <linux/module.h>\n");
+		   "#include <linux/export-internal.h>\n");
 
 	add_exported_symbols(&buf, mod);
 
 	buf_printf(&buf,
+		   "#include <linux/module.h>\n"
 		   "#undef __MODULE_INFO_PREFIX\n"
 		   "#define __MODULE_INFO_PREFIX\n");
 
-- 
2.50.1

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]

Hi all,

On Wed, 30 Jul 2025 16:12:23 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the kbuild tree, today's linux-next build (i386 defconfig)
> failed like this:
> 
> ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
> .vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'
> 
> Caused by commit
> 
>   c4b487ddc51f ("modpost: Create modalias for builtin modules")
> 
> I have reverted that commit, along with its parent and child, for
> today.  It's parent commit
> 
>   66ef3890c628 ("modpost: Add modname to mod_device_table alias")
> 
> generated this warning in the i386 defconfig build:
> 
> scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
> scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
>  1480 |         size_t typelen, modnamelen;
>       |                         ^~~~~~~~~~

I am still reverting those commits.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Alexey Gladkov]

On Mon, Aug 04, 2025 at 11:25:40AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 30 Jul 2025 16:12:23 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the kbuild tree, today's linux-next build (i386 defconfig)
> > failed like this:
> > 
> > ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
> > .vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'
> > 
> > Caused by commit
> > 
> >   c4b487ddc51f ("modpost: Create modalias for builtin modules")
> > 
> > I have reverted that commit, along with its parent and child, for
> > today.  It's parent commit
> > 
> >   66ef3890c628 ("modpost: Add modname to mod_device_table alias")
> > 
> > generated this warning in the i386 defconfig build:
> > 
> > scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
> > scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
> >  1480 |         size_t typelen, modnamelen;
> >       |                         ^~~~~~~~~~
> 
> I am still reverting those commits.

I do not have my tree. Can you apply my fix for original commit instead of
revert ?

https://lore.kernel.org/all/20250730090025.2402129-1-legion@kernel.org/

-- 
Rgrds, legion

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi Alexey,

On Mon, 4 Aug 2025 09:09:19 +0200 Alexey Gladkov <legion@kernel.org> wrote:
>
> On Mon, Aug 04, 2025 at 11:25:40AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > On Wed, 30 Jul 2025 16:12:23 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:  
> > >
> > > After merging the kbuild tree, today's linux-next build (i386 defconfig)
> > > failed like this:
> > > 
> > > ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
> > > .vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'
> > > 
> > > Caused by commit
> > > 
> > >   c4b487ddc51f ("modpost: Create modalias for builtin modules")
> > > 
> > > I have reverted that commit, along with its parent and child, for
> > > today.  It's parent commit
> > > 
> > >   66ef3890c628 ("modpost: Add modname to mod_device_table alias")
> > > 
> > > generated this warning in the i386 defconfig build:
> > > 
> > > scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
> > > scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
> > >  1480 |         size_t typelen, modnamelen;
> > >       |                         ^~~~~~~~~~  
> > 
> > I am still reverting those commits.  
> 
> I do not have my tree. Can you apply my fix for original commit instead of
> revert ?
> 
> https://lore.kernel.org/all/20250730090025.2402129-1-legion@kernel.org/

I did wonder why this patch has not been applied to the kbuild tree?

I will apply that today to the linux-next merge, but it is presumably
delaying the kbuild tree being merged by Linus ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]

Hi all,

On Tue, 5 Aug 2025 08:17:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Mon, 4 Aug 2025 09:09:19 +0200 Alexey Gladkov <legion@kernel.org> wrote:
> >
> > On Mon, Aug 04, 2025 at 11:25:40AM +1000, Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > On Wed, 30 Jul 2025 16:12:23 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > >
> > > > After merging the kbuild tree, today's linux-next build (i386 defconfig)
> > > > failed like this:
> > > > 
> > > > ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
> > > > .vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'
> > > > 
> > > > Caused by commit
> > > > 
> > > >   c4b487ddc51f ("modpost: Create modalias for builtin modules")
> > > > 
> > > > I have reverted that commit, along with its parent and child, for
> > > > today.  It's parent commit
> > > > 
> > > >   66ef3890c628 ("modpost: Add modname to mod_device_table alias")
> > > > 
> > > > generated this warning in the i386 defconfig build:
> > > > 
> > > > scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
> > > > scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
> > > >  1480 |         size_t typelen, modnamelen;
> > > >       |                         ^~~~~~~~~~    
> > > 
> > > I am still reverting those commits.    
> > 
> > I do not have my tree. Can you apply my fix for original commit instead of
> > revert ?
> > 
> > https://lore.kernel.org/all/20250730090025.2402129-1-legion@kernel.org/  
> 
> I did wonder why this patch has not been applied to the kbuild tree?
> 
> I will apply that today to the linux-next merge, but it is presumably
> delaying the kbuild tree being merged by Linus ...

Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # build test

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the kbuild tree

[Alexey Gladkov]

[-- Attachment #1: Type: text/plain, Size: 2289 bytes --]

On Tue, Aug 05, 2025 at 01:33:49PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 5 Aug 2025 08:17:49 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 4 Aug 2025 09:09:19 +0200 Alexey Gladkov <legion@kernel.org> wrote:
> > >
> > > On Mon, Aug 04, 2025 at 11:25:40AM +1000, Stephen Rothwell wrote:  
> > > > Hi all,
> > > > 
> > > > On Wed, 30 Jul 2025 16:12:23 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:    
> > > > >
> > > > > After merging the kbuild tree, today's linux-next build (i386 defconfig)
> > > > > failed like this:
> > > > > 
> > > > > ld: .vmlinux.export.o: in function `__ksymtab___builtin_memcmp':
> > > > > .vmlinux.export.c:(___ksymtab+__builtin_memcmp+0x0): undefined reference to `__builtin_memcmp'
> > > > > 
> > > > > Caused by commit
> > > > > 
> > > > >   c4b487ddc51f ("modpost: Create modalias for builtin modules")
> > > > > 
> > > > > I have reverted that commit, along with its parent and child, for
> > > > > today.  It's parent commit
> > > > > 
> > > > >   66ef3890c628 ("modpost: Add modname to mod_device_table alias")
> > > > > 
> > > > > generated this warning in the i386 defconfig build:
> > > > > 
> > > > > scripts/mod/file2alias.c: In function ‘handle_moddevtable’:
> > > > > scripts/mod/file2alias.c:1480:25: warning: variable ‘modnamelen’ set but not used [-Wunused-but-set-variable]
> > > > >  1480 |         size_t typelen, modnamelen;
> > > > >       |                         ^~~~~~~~~~    
> > > > 
> > > > I am still reverting those commits.    
> > > 
> > > I do not have my tree. Can you apply my fix for original commit instead of
> > > revert ?
> > > 
> > > https://lore.kernel.org/all/20250730090025.2402129-1-legion@kernel.org/  
> > 
> > I did wonder why this patch has not been applied to the kbuild tree?
> > 
> > I will apply that today to the linux-next merge, but it is presumably
> > delaying the kbuild tree being merged by Linus ...
> 
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # build test

I noticed that this patchset is not in the tree. I somehow missed when and
why it was excluded. I thought I had submitted a fix and it had been
accepted.

Do I need to resend it to the mailing list?

-- 
Rgrds, legion


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]