public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: new objtool warnings
Date: Wed, 5 Nov 2025 11:00:14 +0100	[thread overview]
Message-ID: <20251105100014.GY4068168@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251105085637.GO4067720@noisy.programming.kicks-ass.net>

On Wed, Nov 05, 2025 at 09:56:37AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 05, 2025 at 02:30:27PM +1100, Stephen Rothwell wrote:
> 
> > These objtool messages have returned today.  No change in compiler.
> 
> Yes, Ingo also reported them on IRC, let me go investigate!

The below cures things, but I'm not quite sure why they show up now and
not before. Let me poke more.

---
diff --git a/include/linux/irq-entry-common.h b/include/linux/irq-entry-common.h
index 72e3f7a59469..6ab913e57da0 100644
--- a/include/linux/irq-entry-common.h
+++ b/include/linux/irq-entry-common.h
@@ -293,11 +293,11 @@ static __always_inline void irqentry_exit_to_user_mode_prepare(struct pt_regs *r
 static __always_inline void exit_to_user_mode(void)
 {
 	instrumentation_begin();
+	unwind_reset_info();
 	trace_hardirqs_on_prepare();
 	lockdep_hardirqs_on_prepare();
 	instrumentation_end();
 
-	unwind_reset_info();
 	user_enter_irqoff();
 	arch_exit_to_user_mode();
 	lockdep_hardirqs_on(CALLER_ADDR0);

  reply	other threads:[~2025-11-05 10:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  0:15 linux-next: new objtool warnings Stephen Rothwell
2025-11-03  9:10 ` Peter Zijlstra
2025-11-03  9:32   ` Stephen Rothwell
2025-11-03  9:38     ` Peter Zijlstra
2025-11-05  3:30       ` Stephen Rothwell
2025-11-05  8:56         ` Peter Zijlstra
2025-11-05 10:00           ` Peter Zijlstra [this message]
2025-11-05 10:02             ` Peter Zijlstra
2025-11-05 10:10               ` Peter Zijlstra
2025-11-05 17:07                 ` Nathan Chancellor
2025-11-05 19:16                   ` Peter Zijlstra
2025-11-05 20:09                     ` Nathan Chancellor
2025-11-06 11:48                       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105100014.GY4068168@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox