From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Al Viro <viro@ZenIV.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Mateusz Guzik <mjguzik@gmail.com>
Subject: linux-next: manual merge of the vfs tree with the vfs-brauner tree
Date: Fri, 21 Nov 2025 08:33:33 +1100 [thread overview]
Message-ID: <20251121083333.48687f3e@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]
Hi all,
Today's linux-next merge of the vfs tree got a conflict in:
fs/dcache.c
between commits:
31e332b911fc ("fs: add missing fences to I_NEW handling")
b4dbfd8653b3 ("Coccinelle-based conversion to use ->i_state accessors")
1e3c3784221a ("fs: rework I_NEW handling to operate without fences")
from the vfs-brauner tree and commit:
bacdf1d70bbe ("primitives for maintaining persisitency")
from the vfs tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/dcache.c
index 3204cc55b566,824d620bb563..000000000000
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@@ -1986,9 -2012,17 +2019,11 @@@ void d_instantiate_new(struct dentry *e
lockdep_annotate_inode_mutex_key(inode);
security_d_instantiate(entry, inode);
spin_lock(&inode->i_lock);
+ spin_lock(&entry->d_lock);
__d_instantiate(entry, inode);
+ spin_unlock(&entry->d_lock);
- WARN_ON(!(inode->i_state & I_NEW));
- inode->i_state &= ~I_NEW & ~I_CREATING;
- /*
- * Pairs with the barrier in prepare_to_wait_event() to make sure
- * ___wait_var_event() either sees the bit cleared or
- * waitqueue_active() check in wake_up_var() sees the waiter.
- */
- smp_mb();
+ WARN_ON(!(inode_state_read(inode) & I_NEW));
+ inode_state_clear(inode, I_NEW | I_CREATING);
inode_wake_up_bit(inode, __I_NEW);
spin_unlock(&inode->i_lock);
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2025-11-20 21:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 21:33 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-08 12:43 linux-next: manual merge of the vfs tree with the vfs-brauner tree Mark Brown
2026-04-08 17:16 ` Al Viro
2026-04-08 17:32 ` Mark Brown
2026-01-19 13:45 Mark Brown
2026-01-14 22:38 Stephen Rothwell
2025-11-20 21:47 Stephen Rothwell
2025-11-20 21:42 Stephen Rothwell
2025-11-20 21:27 Stephen Rothwell
2025-09-25 12:35 Mark Brown
2025-09-24 9:04 Mark Brown
2025-09-24 8:58 Mark Brown
2025-09-22 8:58 Mark Brown
2025-09-04 23:48 Stephen Rothwell
2025-07-07 23:38 Stephen Rothwell
2025-07-08 0:25 ` Al Viro
2025-07-08 0:45 ` Al Viro
2025-07-08 8:15 ` Christian Brauner
2025-05-16 0:02 Stephen Rothwell
2025-01-19 23:41 Stephen Rothwell
2025-01-20 9:21 ` David Howells
2023-12-19 23:41 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121083333.48687f3e@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox