public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Boqun Feng <boqun.feng@gmail.com>,
	linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
	akpm@linux-foundation.org, Nathan Chancellor <nathan@kernel.org>,
	Waiman Long <longman@redhat.com>, Ingo Molnar <mingo@redhat.com>,
	Will Deacon <will@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] locking/mutex: Initialize mutex::magic even when LOCKDEP=n
Date: Fri, 28 Nov 2025 10:55:52 +0100	[thread overview]
Message-ID: <20251128095552.GG3245006@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20251128160815.64709af7@canb.auug.org.au>

On Fri, Nov 28, 2025 at 04:08:15PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> On Tue, 25 Nov 2025 06:54:21 -0800 Boqun Feng <boqun.feng@gmail.com> wrote:
> >
> > When DEBUG_MUTEXES=y and LOCKDEP=n, mutex_lock() still checks on
> > ->magic, hence debug_mutex_init() should be called in  
> > mutex_init_generic() as well. While we are at it, decouple LOCKDEP
> > logic from debug_mutex_init(), because in this way debug_mutex_init()
> > only needs one parameter, and we now have mutex_init_lockep() for
> > LOCKDEP=y scenarios.
> > 
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/lkml/20251117202214.4f710f02@canb.auug.org.au/
> > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > Closes: https://lore.kernel.org/lkml/20251121215819.GA1374726@ax162/
> > Fixes: 3572e2edc7b6 ("locking/mutex: Redo __mutex_init()")
> > Reviewed-by: Waiman Long <longman@redhat.com>
> > Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> > ---
> > Peter,
> > 
> > Feel free to fold it into commit 3572e2edc7b6 ("locking/mutex: Redo
> > __mutex_init()"), just resend it properly so it won't fall off your
> > radar ;-)
> > 
> >  kernel/locking/mutex-debug.c | 10 +---------
> >  kernel/locking/mutex.c       |  8 +++++++-
> >  kernel/locking/mutex.h       |  5 ++---
> >  3 files changed, 10 insertions(+), 13 deletions(-)
> 
> Any chance if this being applied?  I am still seeing the boot warning.

Should be sorted now, sorry for the delay!

  reply	other threads:[~2025-11-28  9:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  9:22 linux-next: boot warning from the final tree Stephen Rothwell
2025-11-21 21:58 ` Nathan Chancellor
2025-11-21 22:33   ` Boqun Feng
2025-11-22  7:37     ` Nathan Chancellor
2025-11-23  0:50     ` Waiman Long
2025-11-24  7:45     ` Sebastian Andrzej Siewior
2025-11-25 14:54     ` [PATCH] locking/mutex: Initialize mutex::magic even when LOCKDEP=n Boqun Feng
2025-11-28  5:08       ` Stephen Rothwell
2025-11-28  9:55         ` Peter Zijlstra [this message]
2025-11-28 10:29           ` Stephen Rothwell
2025-11-28  9:36       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251128095552.GG3245006@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=boqun.feng@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox