Re: linux-next: Fixes tag needs some work in the mm-hotfixes tree

Peter Xu
2022-08-07T23:01:32Z

On Mon, Aug 08, 2022 at 07:19:41AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> b2f4c6e29531 ("mm/smaps: don't access young/dirty bit if pte unpresent")
>
> Fixes tag
>
> Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31)
>
> has these problem(s):
>
> - Subject has leading but no trailing quotes
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Please do not include the date part - it adds nothing.

The date confused the script. I'd only rely on the 1st column (which
should definitely be the commit ID) normally for Fixes, but will remember
to use the general format in the future..

Thanks.

--
Peter Xu