* Re: [PATCH] drm/gem: Fix kerneldoc warnings
2025-12-17 17:24 [PATCH] drm/gem: Fix kerneldoc warnings Loïc Molinari
@ 2025-12-17 18:09 ` Randy Dunlap
2025-12-18 9:00 ` Boris Brezillon
2025-12-18 10:09 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2025-12-17 18:09 UTC (permalink / raw)
To: Loïc Molinari, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Stephen Rothwell, Boris Brezillon, Linux Kernel Mailing List,
DRI Devel Mailing List, Intel Graphics Mailing List,
Linux Next Mailing List, Collabora Kernel Mailing List
On 12/17/25 9:24 AM, Loïc Molinari wrote:
> Fix incorrect parameters in drm_gem_shmem_init() and missing " *" on
> empty lines in drm_gem_get_huge_mnt().
>
> Signed-off-by: Loïc Molinari <loic.molinari@collabora.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 7 +++++--
> include/drm/drm_gem.h | 4 ++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 29174ab58ff3..fbd1164174b0 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -94,9 +94,12 @@ static int __drm_gem_shmem_init(struct drm_device *dev, struct drm_gem_shmem_obj
> }
>
> /**
> - * drm_gem_shmem_init - Initialize an allocated object.
> + * drm_gem_shmem_init - Initialize an allocated object of the given size
> * @dev: DRM device
> - * @obj: The allocated shmem GEM object.
> + * @shmem: shmem GEM object to initialize
> + * @size: Size of the object to initialize
> + *
> + * This function initializes an allocated shmem GEM object.
> *
> * Returns:
> * 0 on success, or a negative error code on failure.
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index f4da8ed0d630..86f5846154f7 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -508,11 +508,11 @@ static inline int drm_gem_huge_mnt_create(struct drm_device *dev,
> /**
> * drm_gem_get_huge_mnt - Get the huge tmpfs mountpoint used by a DRM device
> * @dev: DRM device
> -
> + *
> * This function gets the huge tmpfs mountpoint used by DRM device @dev. A huge
> * tmpfs mountpoint is used instead of `shm_mnt` after a successful call to
> * drm_gem_huge_mnt_create() when CONFIG_TRANSPARENT_HUGEPAGE is enabled.
> -
> + *
> * Returns:
> * The huge tmpfs mountpoint in use, NULL otherwise.
> */
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/gem: Fix kerneldoc warnings
2025-12-17 17:24 [PATCH] drm/gem: Fix kerneldoc warnings Loïc Molinari
2025-12-17 18:09 ` Randy Dunlap
@ 2025-12-18 9:00 ` Boris Brezillon
2025-12-18 10:09 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2025-12-18 9:00 UTC (permalink / raw)
To: Loïc Molinari
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Stephen Rothwell, Linux Kernel Mailing List,
DRI Devel Mailing List, Intel Graphics Mailing List,
Linux Next Mailing List, Collabora Kernel Mailing List
On Wed, 17 Dec 2025 18:24:04 +0100
Loïc Molinari <loic.molinari@collabora.com> wrote:
> Fix incorrect parameters in drm_gem_shmem_init() and missing " *" on
> empty lines in drm_gem_get_huge_mnt().
>
Fixes: 6e0b1b82017b ("drm/gem: Add huge tmpfs mountpoint helpers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/dri-devel/20251216115605.4babbce0@canb.auug.org.au/
> Signed-off-by: Loïc Molinari <loic.molinari@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 7 +++++--
> include/drm/drm_gem.h | 4 ++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 29174ab58ff3..fbd1164174b0 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -94,9 +94,12 @@ static int __drm_gem_shmem_init(struct drm_device *dev, struct drm_gem_shmem_obj
> }
>
> /**
> - * drm_gem_shmem_init - Initialize an allocated object.
> + * drm_gem_shmem_init - Initialize an allocated object of the given size
> * @dev: DRM device
> - * @obj: The allocated shmem GEM object.
> + * @shmem: shmem GEM object to initialize
> + * @size: Size of the object to initialize
> + *
> + * This function initializes an allocated shmem GEM object.
> *
> * Returns:
> * 0 on success, or a negative error code on failure.
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index f4da8ed0d630..86f5846154f7 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -508,11 +508,11 @@ static inline int drm_gem_huge_mnt_create(struct drm_device *dev,
> /**
> * drm_gem_get_huge_mnt - Get the huge tmpfs mountpoint used by a DRM device
> * @dev: DRM device
> -
> + *
> * This function gets the huge tmpfs mountpoint used by DRM device @dev. A huge
> * tmpfs mountpoint is used instead of `shm_mnt` after a successful call to
> * drm_gem_huge_mnt_create() when CONFIG_TRANSPARENT_HUGEPAGE is enabled.
> -
> + *
> * Returns:
> * The huge tmpfs mountpoint in use, NULL otherwise.
> */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/gem: Fix kerneldoc warnings
2025-12-17 17:24 [PATCH] drm/gem: Fix kerneldoc warnings Loïc Molinari
2025-12-17 18:09 ` Randy Dunlap
2025-12-18 9:00 ` Boris Brezillon
@ 2025-12-18 10:09 ` Boris Brezillon
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2025-12-18 10:09 UTC (permalink / raw)
To: Loïc Molinari
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Stephen Rothwell, Linux Kernel Mailing List,
DRI Devel Mailing List, Intel Graphics Mailing List,
Linux Next Mailing List, Collabora Kernel Mailing List
On Wed, 17 Dec 2025 18:24:04 +0100
Loïc Molinari <loic.molinari@collabora.com> wrote:
> Fix incorrect parameters in drm_gem_shmem_init() and missing " *" on
> empty lines in drm_gem_get_huge_mnt().
>
> Signed-off-by: Loïc Molinari <loic.molinari@collabora.com>
Queued to drm-misc-next.
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 7 +++++--
> include/drm/drm_gem.h | 4 ++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 29174ab58ff3..fbd1164174b0 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -94,9 +94,12 @@ static int __drm_gem_shmem_init(struct drm_device *dev, struct drm_gem_shmem_obj
> }
>
> /**
> - * drm_gem_shmem_init - Initialize an allocated object.
> + * drm_gem_shmem_init - Initialize an allocated object of the given size
> * @dev: DRM device
> - * @obj: The allocated shmem GEM object.
> + * @shmem: shmem GEM object to initialize
> + * @size: Size of the object to initialize
> + *
> + * This function initializes an allocated shmem GEM object.
> *
> * Returns:
> * 0 on success, or a negative error code on failure.
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index f4da8ed0d630..86f5846154f7 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -508,11 +508,11 @@ static inline int drm_gem_huge_mnt_create(struct drm_device *dev,
> /**
> * drm_gem_get_huge_mnt - Get the huge tmpfs mountpoint used by a DRM device
> * @dev: DRM device
> -
> + *
> * This function gets the huge tmpfs mountpoint used by DRM device @dev. A huge
> * tmpfs mountpoint is used instead of `shm_mnt` after a successful call to
> * drm_gem_huge_mnt_create() when CONFIG_TRANSPARENT_HUGEPAGE is enabled.
> -
> + *
> * Returns:
> * The huge tmpfs mountpoint in use, NULL otherwise.
> */
^ permalink raw reply [flat|nested] 4+ messages in thread