Re: linux-next: Build failure after merge of the tip tree

Borislav Petkov
2023-04-19T18:50:15Z

On Wed, Apr 19, 2023 at 07:21:36PM +0100, broonie@kernel.org wrote:
> Hi all,
>
> After merging the rcu tree, today's linux-next build (arm64 defconfig)
> failed like this:
>
> /tmp/next/build/mm/migrate.c: In function 'remove_migration_pte':
> /tmp/next/build/mm/migrate.c:222:31: error: too few arguments to function 'pte_mkwrite'
> 222 | pte = pte_mkwrite(pte);
> | ^~~~~~~~~~~
> In file included from /tmp/next/build/include/linux/pgtable.h:6,
> from /tmp/next/build/include/linux/mm.h:29,
> from /tmp/next/build/include/linux/migrate.h:5,
> from /tmp/next/build/mm/migrate.c:16:
> /tmp/next/build/arch/arm64/include/asm/pgtable.h:190:21: note: declared here
> 190 | static inline pte_t pte_mkwrite(pte_t pte, struct vm_area_struct *vma)
> | ^~~~~~~~~~~
>
> Caused by commit
>
> 717f95b494ac36 ("mm: don't check VMA write permissions if the PTE/PMD indicates write permissions")
>
> from the mm tree interacting with
>
> 74fd30bd28e4c7 ("mm: Make pte_mkwrite() take a VMA")
>
> from the tip tree. I've applied the fixup below

Thanks for letting us know - we'll keep this in mind when sending the
piles of patches to Linus next week.

--
Regards/Gruss,
Boris.