Re: linux-next: build failure after merge of the tip tree

Stephen Rothwell
2025-04-28T07:19:26Z

[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]

Hi all,

On Thu, 24 Apr 2025 22:03:05 +0530 Athira Rajeev <atrajeev@linux.ibm.com> wrote:
>
> > On 24 Apr 2025, at 8:07 PM, Athira Rajeev <atrajeev@linux.ibm.com> wrote:
> >
> >> On 22 Apr 2025, at 3:26 PM, Shrikanth Hegde <sshegde@linux.ibm.com> wrote:
> >>
> >> On 4/22/25 12:05, Stephen Rothwell wrote:
> >>
> >>> On Thu, 17 Apr 2025 13:49:59 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>>>
> >>>> On Tue, 15 Apr 2025 13:35:18 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>>>>
> >>>>> After merging the tip tree, today's linux-next build (native perf)
> >>>>> failed like this:
> >>>>>
> >>>>> diff: tools/arch/x86/include/asm/amd/ibs.h: No such file or directory
> >>>>> In file included from util/amd-sample-raw.c:12:
> >>>>> tools/include/../../arch/x86/include/asm/amd/ibs.h:10:10: fatal error: asm/msr-index.h: No such file or directory
> >>>>> 10 | #include <asm/msr-index.h>
> >>>>> | ^~~~~~~~~~~~~~~~~
> >>>>> compilation terminated.
> >>>>>
> >>>>> Maybe caused by commit
> >>>>>
> >>>>> 3846389c03a8 ("x86/platform/amd: Move the <asm/amd-ibs.h> header to <asm/amd/ibs.h>")
> >>>>> or associated commits?
>
> Posted the fix in mailing here: https://lore.kernel.org/linux-perf-users/20250424163033.6601-1-atrajeev@linux.ibm.com/T/#u
> Please share feedback if it fixes the compilation issue.

OK, so to progress things ...

Just reverting the changes to tools/perf in commit

3846389c03a8 ("x86/platform/amd: Move the <asm/amd-ibs.h> header to <asm/amd/ibs.h>")

Allows perf to build again on ppc64el (and gets rid of the warning), so
is that a reasonable thing to do - and leave the tools perf update to
the perf guys?

If so, can that partial revert be added to the tip tree, please?
--
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]