Re: linux-next: build failure after merge of the tip tree

Ingo Molnar
2011-02-17T17:11:48Z

* Michal Marek <mmarek@suse.cz> wrote:

> @@ -340,9 +342,16 @@ static void parse_dep_file(void *map, size_t len)
> if (strrcmp(s, "include/generated/autoconf.h") &&
> strrcmp(s, "arch/um/include/uml-config.h") &&
> strrcmp(s, ".ver")) {
> - printf(" %s \\\n", s);
> + /* Do not output the first dependency (the
> + * source file), so that kbuild is not confused
> + * if a .c file is rewritten into .S or vice
> + * versa.
> + */

Just a really minor nitpick, please use the standard comment style:

/*
* Comment .....
* ...... goes here.
*/

specified in Documentation/CodingStyle.

Thanks,

Ingo