From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F491A0B15; Sat, 30 May 2026 10:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780137030; cv=none; b=lKkaKuDmXpXo0ffgUwixW+oCCY1q72trg7ry5ekxfCsA/wbADBnV5aOKn06RyrdfaY6iCpodmT3CNtwkRjZiCuHFZ4SyyCXqLugnm5Vr4ZvxyuYpTAKpqMe75QN7g9y/vO87y1TDrwFqgn0WK/UIKkgS6uPaONmYh0i72LLxCog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780137030; c=relaxed/simple; bh=NwNvM42/n4zB9cab+HVq7KTKcoLj4KX8MUmltLuhme0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gsRGX+BcHm5hFuxPmLeabXsxxwHPHcfEzGLiADFWnsLrjP1loo1v0rvXsq4D2+p4FMYfor7O2q3oW5YAQ11FhS9wQTZn96G9TNEOT4y7iMRPNXqe1g+8tZGkB/HhJT/Qhc2y3QNTytWLVBBN03ZA5t9frSNBr5Vrveau0OG/yjE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tkJl43J6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tkJl43J6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 602691F00893; Sat, 30 May 2026 10:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780137029; bh=sExTVAQNfp+Wvo2s9CnxcQhquuzTS07EAHg0HbugqnQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=tkJl43J6KN7al+GZVz/U4pTfTdL5xtk3o4WUFibEJRWxc+kieSeSr02EMAEaiOCzP j6s8d1BNTmkohPyhixTwWp0GV6lWwhYkHnHWXZfruSscfYe1+67MTrX/N+p8MosUNQ DA/n5BBcVQgptN0aBu/mdckR3qmzFvxKpddqv9j8= Date: Sat, 30 May 2026 12:29:34 +0200 From: Greg Kroah-Hartman To: Dominik Karol =?utf-8?Q?Pi=C4=85tkowski?= Cc: Mark Brown , Hongling Zeng , Hongling Zeng , "linux-next@vger.kernel.org" , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [REGRESSION] Introduced double release_region in gpib/cb7210 Message-ID: <2026053027-follow-hurried-162b@gregkh> References: Precedence: bulk X-Mailing-List: linux-next@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 29, 2026 at 07:23:14PM +0000, Dominik Karol Piątkowski wrote: > Hi, > > There are currently two patches [1][2] called: > > gpib: cb7210: Fix region leak when request_irq fails > > in linux-next that came from char-misc-next. Patch [1] introduces double > release_region (if cb_isa_attach fails, cb_isa_detach is called and it already > takes care of cleanup) and patch [2] introduces release_region on region we > never obtained. > > cb_isa_attach is set as attach and cb_isa_detach is set as detach in > cb_isa_(un)accel_interface and cb_isa_interface. The only place where I see > attach is called, is in common/iblib.c, in ibonline function. If attach fails > there, detach is called, where a proper cleanup is performed (and it includes > things like nec7210_board_reset for cb7120). AFAIK, the same approach is used > for the rest of gpib. > > Please revert these patches. > > Additionally, patch [2] was cc'd to stable@vger.kernel.org - hence adding it > to cc for this email as well. > > Thanks, > Dominik Karol > > > [1] https://patch.msgid.link/20260503093036.283546-1-zenghongling@kylinos.cn > [2] https://patch.msgid.link/20260518022939.16881-1-zenghongling@kylinos.cn > Now reverted