From: Lukasz Luba <lukasz.luba@arm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org
Subject: Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model
Date: Tue, 15 Dec 2020 10:44:52 +0000 [thread overview]
Message-ID: <2110a2c5-50ac-7cc9-57e8-eb22dde5bb32@arm.com> (raw)
In-Reply-To: <20201215194811.0505c1c5@canb.auug.org.au>
On 12/15/20 8:48 AM, Stephen Rothwell wrote:
> Hi Daniel,
>
> On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>>
>> The devfreq cooling device has been converted to use the energy model.
>>
>> Add the dependency on the ENERGY_MODEL option to reflect this change
>> and prevent build failure if the option is not set.
>>
>> Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> drivers/thermal/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 7edc8dc6bbab..ee62d51ef351 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL
>> bool "Generic device cooling support"
>> depends on PM_DEVFREQ
>> depends on PM_OPP
>> + depends on ENERGY_MODEL
>> help
>> This implements the generic devfreq cooling mechanism through
>> frequency reduction for devices using devfreq.
>
> Looks good to me.
>
My apologies. I've tested it on odroidxu3 with
exynos_defconfig which has the energy model set.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Regards,
Lukasz
next prev parent reply other threads:[~2020-12-15 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 1:58 linux-next: build failure after merge of the thermal tree Stephen Rothwell
2020-12-15 8:35 ` [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model Daniel Lezcano
2020-12-15 8:41 ` Daniel Lezcano
2020-12-15 8:48 ` Stephen Rothwell
2020-12-15 10:44 ` Lukasz Luba [this message]
2020-12-15 15:42 ` [PATCH] thermal: devfreq_cooling: fix the build when !ENERGY_MODEL Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2110a2c5-50ac-7cc9-57e8-eb22dde5bb32@arm.com \
--to=lukasz.luba@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox