From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B87C4361B for ; Tue, 15 Dec 2020 10:46:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 164362220F for ; Tue, 15 Dec 2020 10:46:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727065AbgLOKp6 (ORCPT ); Tue, 15 Dec 2020 05:45:58 -0500 Received: from foss.arm.com ([217.140.110.172]:32798 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726512AbgLOKpt (ORCPT ); Tue, 15 Dec 2020 05:45:49 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 681B91FB; Tue, 15 Dec 2020 02:44:55 -0800 (PST) Received: from [10.57.22.20] (unknown [10.57.22.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 383143F66E; Tue, 15 Dec 2020 02:44:54 -0800 (PST) Subject: Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model To: Stephen Rothwell , Daniel Lezcano Cc: rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org References: <20201215125806.31495950@canb.auug.org.au> <20201215083520.601988-1-daniel.lezcano@linaro.org> <20201215194811.0505c1c5@canb.auug.org.au> From: Lukasz Luba Message-ID: <2110a2c5-50ac-7cc9-57e8-eb22dde5bb32@arm.com> Date: Tue, 15 Dec 2020 10:44:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20201215194811.0505c1c5@canb.auug.org.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 12/15/20 8:48 AM, Stephen Rothwell wrote: > Hi Daniel, > > On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano wrote: >> >> The devfreq cooling device has been converted to use the energy model. >> >> Add the dependency on the ENERGY_MODEL option to reflect this change >> and prevent build failure if the option is not set. >> >> Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM") > > Reported-by: Stephen Rothwell > >> Signed-off-by: Daniel Lezcano >> --- >> drivers/thermal/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 7edc8dc6bbab..ee62d51ef351 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL >> bool "Generic device cooling support" >> depends on PM_DEVFREQ >> depends on PM_OPP >> + depends on ENERGY_MODEL >> help >> This implements the generic devfreq cooling mechanism through >> frequency reduction for devices using devfreq. > > Looks good to me. > My apologies. I've tested it on odroidxu3 with exynos_defconfig which has the energy model set. Reviewed-by: Lukasz Luba Regards, Lukasz