From: Arnd Bergmann <arnd@arndb.de>
To: kernel-build-reports@lists.linaro.org
Cc: Pawel Moll <pawel.moll@arm.com>,
arm@kernel.org, linaro-kernel@lists.linaro.org,
linux-next@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] bus: arm-ccn: Use hrtimer_start()
Date: Wed, 13 May 2015 17:32:05 +0200 [thread overview]
Message-ID: <2646197.ZVRR8xztig@wuerfel> (raw)
In-Reply-To: <1431530484-3389-1-git-send-email-pawel.moll@arm.com>
On Wednesday 13 May 2015 16:21:24 Pawel Moll wrote:
> diff --git a/drivers/bus/arm-ccn.c b/drivers/bus/arm-ccn.c
> index df5f307..7d9879e 100644
> --- a/drivers/bus/arm-ccn.c
> +++ b/drivers/bus/arm-ccn.c
> @@ -921,9 +921,8 @@ static void arm_ccn_pmu_event_start(struct perf_event *event, int flags)
> * attribute).
> */
> if (!ccn->irq)
> - __hrtimer_start_range_ns(&ccn->dt.hrtimer,
> - arm_ccn_pmu_timer_period(), 0,
> - HRTIMER_MODE_REL_PINNED, 0);
> + hrtimer_start(&ccn->dt.hrtimer, arm_ccn_pmu_timer_period(),
> + HRTIMER_MODE_REL_PINNED);
>
> /* Set the DT bus input, engaging the counter */
> arm_ccn_pmu_xp_dt_config(event, 1);
Is this correct by itself, or do we need to pull in the branch that
contains c6eb3f70d44828 ("hrtimer: Get rid of hrtimer softirq")
from Thomas? The other similar patches that Thomas did contain a
comment about the conversion being safe after hrtimer_start()
no longer uses a softirq, but it is still in use in 4.1-rc3.
Arnd
next prev parent reply other threads:[~2015-05-13 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 11:34 next-20150513 build: 2 failures 47 warnings (next-20150513) Build bot for Mark Brown
2015-05-13 14:51 ` Build failures in -next due to use of __hrtimer_start_range_ns arm-ccn.c Mark Brown
2015-05-13 15:08 ` Pawel Moll
2015-05-13 15:13 ` Thomas Gleixner
2015-05-13 15:21 ` [PATCH] bus: arm-ccn: Use hrtimer_start() Pawel Moll
2015-05-13 15:32 ` Arnd Bergmann [this message]
2015-05-13 15:47 ` Pawel Moll
2015-05-13 16:19 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2646197.ZVRR8xztig@wuerfel \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox