From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: linux-next: manual merge of the creds tree Date: Fri, 07 Nov 2008 15:04:48 +0000 Message-ID: <27012.1226070288@redhat.com> References: <20081107184934.8ad8b6ca.sfr@canb.auug.org.au> Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51336 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752242AbYKGPFA (ORCPT ); Fri, 7 Nov 2008 10:05:00 -0500 In-Reply-To: <20081107184934.8ad8b6ca.sfr@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: dhowells@redhat.com, James Morris , linux-next@vger.kernel.org, Eric Paris Stephen Rothwell wrote: > + read_lock_irq(&tasklist_lock); > + psig = current->parent->sighand; > + spin_lock_irqsave(&psig->siglock, flags); There's no point using spin_lock_irqsave(): you've already disabled interrupts with read_lock_irq(). Similarly: > + spin_unlock_irqrestore(&psig->siglock, flags); > + read_unlock_irq(&tasklist_lock); spin_unlock_irqrestore() here is never going to re-enable interrupts. Apart from that, it looks okay. My tree and James's tree definitely need to meet before you see them. David