Re: [PATCH v4 3/3] platform/x86: Use i2c adapter name to fix build errors

Ilpo Järvinen
2025-06-10T08:42:08Z

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

On Mon, 9 Jun 2025, Pratap Nirujogi wrote:

> Use adapater->name inplace of adapter->owner->name to fix
> build issues when CONFIG_MODULES is not defined.
>
> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
> ---
> drivers/platform/x86/amd/amd_isp4.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
> index 0cc01441bcbb..9f291aeb35f1 100644
> --- a/drivers/platform/x86/amd/amd_isp4.c
> +++ b/drivers/platform/x86/amd/amd_isp4.c
> @@ -11,6 +11,7 @@
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
> +#include <linux/soc/amd/isp4_misc.h>
> #include <linux/string.h>
> #include <linux/types.h>
> #include <linux/units.h>
> @@ -151,7 +152,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>
> static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
> {
> - return !strcmp(adap->owner->name, "i2c_designware_amdisp");
> + return !strcmp(adap->name, AMDISP_I2C_ADAP_NAME);
> }
>
> static void instantiate_isp_i2c_client(struct amdisp_platform *isp4_platform,

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Andi, do you want to take this fix series through i2c tree or do you
prefer me to take them through pdx86 tree?

--
i.