public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: Benjamin Tissoires <bentiss@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the hid tree
Date: Mon, 2 Mar 2026 18:52:33 +0100	[thread overview]
Message-ID: <2b186b8c-c0e9-44d9-ba40-9eeef69e4391@linux.dev> (raw)
In-Reply-To: <aaWzSAThxAb7nEuw@beelink>


On 3/2/26 16:58, Benjamin Tissoires wrote:
> On Mar 02 2026, Mark Brown wrote:
>> Hi all,
>>
>> After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
>> failed like this:
>>
>> /tmp/next/build/drivers/hid/hid-asus.c: In function 'asus_has_report_id':
>> /tmp/next/build/drivers/hid/hid-asus.c:732:22: error: unused variable 'err' [-Werror=unused-variable]
>>   732 |         int t, f, u, err = 0;
>>       |                      ^~~
>> /tmp/next/build/drivers/hid/hid-asus.c:732:19: error: unused variable 'u' [-Werror=unused-variable]
>>   732 |         int t, f, u, err = 0;
>>       |                   ^
>> /tmp/next/build/drivers/hid/hid-asus.c:732:16: error: unused variable 'f' [-Werror=unused-variable]
>>   732 |         int t, f, u, err = 0;
>>       |                ^
>> cc1: all warnings being treated as errors
>>
>>
>> Caused by commit
>>
>>   Fixes: 0919db9f35832 (HID: asus: always fully initialize devices)
>>
>> I have used the tree from next-20260226 instead.
> Thanks for the report.
>
> I've queued a fix on top of the current for-7.1/asus branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git/commit/?h=for-7.1/asus&id=7b2f88cc9dd4c2b9f3d6f5377b45ed9c90fd2fe9
>
> Denis, if you disagree with the fix, please shout.
Hi,

Thank you for that, but I think we are duplicating work here: I spotted it and sent a fix already inside this:
https://lore.kernel.org/all/20260228144626.1661530-1-denis.benato@linux.dev/ the fix is is 3/7.
> Cheers,
> Benjamin
>
>

  reply	other threads:[~2026-03-02 17:52 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 13:56 linux-next: build failure after merge of the hid tree Mark Brown
2026-03-02 15:58 ` Benjamin Tissoires
2026-03-02 17:52   ` Denis Benato [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-09 23:43 Stephen Rothwell
2025-02-10 22:07 ` Jiri Kosina
2025-02-11  3:15   ` Kate Hsuan
2025-01-10  6:52 Stephen Rothwell
2024-07-01  8:51 Stephen Rothwell
2024-07-01 12:43 ` Benjamin Tissoires
2024-06-20 13:55 Mark Brown
2024-05-07  1:06 Stephen Rothwell
2024-05-07  7:22 ` Kenny Levinsen
2024-04-11  0:51 Stephen Rothwell
2024-04-11  7:17 ` Benjamin Tissoires
2024-02-28  3:56 Stephen Rothwell
2022-07-25  0:40 Stephen Rothwell
2022-07-25  9:42 ` Jiri Kosina
2022-07-27  1:11   ` Stephen Rothwell
2021-12-03  7:01 Stephen Rothwell
2021-12-03  8:09 ` Greg Kroah-Hartman
2021-05-27  5:26 Stephen Rothwell
2021-05-27  8:14 ` Jiri Kosina
2021-05-27  8:25   ` Hans de Goede
2021-05-27 13:22     ` Naresh Kamboju
2021-05-27 13:42     ` Jiri Kosina
2019-10-04  0:28 Stephen Rothwell
2019-10-04  6:55 ` Hans de Goede
2016-12-11 23:59 Stephen Rothwell
2016-12-12  8:50 ` Jiri Kosina
2012-06-29  2:47 Stephen Rothwell
2012-06-29 13:03 ` Jiri Kosina
2011-12-19  1:34 Stephen Rothwell
2011-12-19  8:21 ` Jiri Kosina
2011-11-29  1:00 Stephen Rothwell
2011-11-29  1:30 ` Jeremy Fitzhardinge
2011-06-08  3:03 Stephen Rothwell
2011-06-08  7:26 ` Stefan Kriwanek
2011-06-08  7:50   ` Jiri Kosina
2011-04-07  1:06 Stephen Rothwell
2011-04-07 13:00 ` Alan Ott
2011-04-08 23:54 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b186b8c-c0e9-44d9-ba40-9eeef69e4391@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=benjamin.tissoires@redhat.com \
    --cc=bentiss@kernel.org \
    --cc=broonie@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox