Re: [PATCH] crypto: jitterentropy - avoid compiler warnings

Geert Uytterhoeven
2015-06-23T18:15:06Z

Hi Stephan,

On Tue, Jun 23, 2015 at 4:18 PM, Stephan Mueller <smueller@chronox.de> wrote:
> may I ask that you check that the following patch compiles without errors or warnings on your systems?
>
> Though, when I test that patch with the AVR32 cross compiler, I get a warning about the code being not relaxable.
>
> Thank you very much.
>
> ---8<---
> The core of the Jitter RNG is intended to be compiled with -O0. To
> ensure that the Jitter RNG can be compiled on all architectures,
> separate out the RNG core into a stand-alone C file that can be compiled
> with -O0 which does not depend on any kernel include file.
>
> As no kernel includes can be used in the C file implementing the core
> RNG, any dependencies on kernel code must be extracted.
>
> A second file provides the link to the kernel and the kernel crypto API
> that can be compiled with the regular compile options of the kernel.
>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>

Thanks, the warnings I saw before with m68k-linux-gnu-gcc-4.1.2
are gone.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds