From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 364A8C6FD1C for ; Wed, 22 Mar 2023 23:14:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbjCVXOK (ORCPT ); Wed, 22 Mar 2023 19:14:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbjCVXOJ (ORCPT ); Wed, 22 Mar 2023 19:14:09 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7287BCDDD for ; Wed, 22 Mar 2023 16:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679526805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W1bHDk0oP2JcVjcuUNUBU7qA6y9+VnS24Vk8VdGcjCM=; b=Eeib7cZO1eKis+CaTSwCCX2BncbEZWfTHExjSGt4Q3YDrpLcR0WtrQYzw1uRisDzfKwOTz zh+GGmeysJJIo2YjJVHSY3iN21rKbagJrLbWaB1SnNgsu9pkT2lquOvQ69QFw9mSGNW3EG 9EgsVZk2aFGwbWSG8E64uj+QatWYXFk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-DodOOScjMpCdlkG2APvX0A-1; Wed, 22 Mar 2023 19:13:22 -0400 X-MC-Unique: DodOOScjMpCdlkG2APvX0A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6CC00801206; Wed, 22 Mar 2023 23:13:21 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F9D41121314; Wed, 22 Mar 2023 23:13:20 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230323100204.0917cecf@canb.auug.org.au> References: <20230323100204.0917cecf@canb.auug.org.au> To: Stephen Rothwell Cc: dhowells@redhat.com, Jens Axboe , Andrew Morton , Linux Kernel Mailing List , Linux Next Mailing List , Lorenzo Stoakes Subject: Re: linux-next: manual merge of the block tree with the mm tree MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3431083.1679526799.1@warthog.procyon.org.uk> Date: Wed, 22 Mar 2023 23:13:19 +0000 Message-ID: <3431084.1679526799@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Stephen Rothwell wrote: > + if (unlikely(iov_iter_is_pipe(i))) { > + copied = copy_page_to_iter_pipe(page, offset, bytes, i); > + goto out; > + } This bit would need to be removed from copy_page_to_iter_atomic() as the two functions it calls should be removed by the patch in the block tree. David