From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32771EB64D9 for ; Thu, 15 Jun 2023 16:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233430AbjFOQFv (ORCPT ); Thu, 15 Jun 2023 12:05:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233511AbjFOQFs (ORCPT ); Thu, 15 Jun 2023 12:05:48 -0400 Received: from raptorengineering.com (mail.raptorengineering.com [23.155.224.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAC392962; Thu, 15 Jun 2023 09:05:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id C42558284ECA; Thu, 15 Jun 2023 11:05:33 -0500 (CDT) Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Hn_yqK1TZ49t; Thu, 15 Jun 2023 11:05:33 -0500 (CDT) Received: from localhost (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id 029168285373; Thu, 15 Jun 2023 11:05:33 -0500 (CDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rptsys.com 029168285373 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raptorengineering.com; s=B8E824E6-0BE2-11E6-931D-288C65937AAD; t=1686845133; bh=rFUIajOuH+FadwYEaFgNJ33Jl5ybknrMbERZj5HLtXE=; h=Date:From:To:Message-ID:MIME-Version; b=TRCOnV9vULN2EKIC6RkrYXQRMdSz224wIkjwnG2YD8ytSBUnnLhgLff59H382lPQy a+9hfpBHgw739/WXMmokYNnU2Y0IwwNNv6aYKeiV9po84870EW47zK6Rn55XXLKcFX HekRvKLI9PvKBbUbmOon3YXxTFtY52OUo0nGBfVo= X-Virus-Scanned: amavisd-new at rptsys.com Received: from mail.rptsys.com ([127.0.0.1]) by localhost (vali.starlink.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mK9YZwHZNAQ0; Thu, 15 Jun 2023 11:05:32 -0500 (CDT) Received: from vali.starlink.edu (localhost [127.0.0.1]) by mail.rptsys.com (Postfix) with ESMTP id B273B8284ECA; Thu, 15 Jun 2023 11:05:32 -0500 (CDT) Date: Thu, 15 Jun 2023 11:05:30 -0500 (CDT) From: Timothy Pearson To: Randy Dunlap Cc: Timothy Pearson , Michael Ellerman , Stephen Rothwell , Linux Next Mailing List , linux-kernel , linuxppc-dev , Alexey Kardashevskiy Message-ID: <373175504.6295209.1686845130893.JavaMail.zimbra@raptorengineeringinc.com> In-Reply-To: References: <20230602140143.0af52cee@canb.auug.org.au> <2d188c87-ef34-3812-7330-a985f756d959@infradead.org> <87h6rogjok.fsf@mail.lhotse> <586983120.3136676.1685851048873.JavaMail.zimbra@raptorengineeringinc.com> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.5.0_GA_3042 (ZimbraWebClient - GC112 (Linux)/8.5.0_GA_3042) Thread-Topic: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) Thread-Index: GvseGKdjg/1HXFjWDleWSYOY8qMIcw== Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org ----- Original Message ----- > From: "Randy Dunlap" > To: "Timothy Pearson" , "Michael Ellerman" > Cc: "Stephen Rothwell" , "Linux Next Mailing List" , "linux-kernel" > , "linuxppc-dev" , "Alexey Kardashevskiy" > Sent: Thursday, June 15, 2023 11:00:08 AM > Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) > Hi Timothy, > > On 6/3/23 20:57, Timothy Pearson wrote: >> >> >> ----- Original Message ----- >>> From: "Michael Ellerman" >>> To: "Randy Dunlap" , "Stephen Rothwell" >>> , "Linux Next Mailing List" >>> >>> Cc: "linux-kernel" , "linuxppc-dev" >>> , "Alexey >>> Kardashevskiy" , "Timothy Pearson" >>> >>> Sent: Saturday, June 3, 2023 7:22:51 PM >>> Subject: Re: linux-next: Tree for Jun 2 (arch/powerpc/kernel/iommu.c) >> >>> Randy Dunlap writes: >>>> On 6/1/23 21:01, Stephen Rothwell wrote: >>>>> Hi all, >>>>> >>>>> Changes since 20230601: >>>>> >>>> >>>> On powerpc64, a randconfig failed with: >>>> >>>> In file included from ../include/linux/list.h:5, >>>> from ../include/linux/preempt.h:11, >>>> from ../include/linux/spinlock.h:56, >>>> from ../include/linux/mmzone.h:8, >>>> from ../include/linux/gfp.h:7, >>>> from ../include/linux/slab.h:15, >>>> from ../arch/powerpc/kernel/iommu.c:15: >>>> ../arch/powerpc/kernel/iommu.c: In function >>>> 'spapr_tce_setup_phb_iommus_initcall': >>>> ../arch/powerpc/kernel/iommu.c:1391:36: error: 'hose_list' undeclared (first use >>>> in this function); did you mean 'zonelist'? >>>> 1391 | list_for_each_entry(hose, &hose_list, list_node) { >>>> | ^~~~~~~~~ >>> ... >>> >>> hose_list is in pci-common.c which is built when PCI=y. >>> >>> PSERIES and POWERNV force PCI=y. >>> >>> But this config has neither: >>> >>> # CONFIG_PPC_POWERNV is not set >>> # CONFIG_PPC_PSERIES is not set >>> CONFIG_HAVE_PCI=y >>> # CONFIG_PCI is not set >>> # CONFIG_COMMON_CLK_RS9_PCIE is not set >>> >>> >>> Probably the spapr_tce code should be wrapped in an #ifdef that is only >>> enabled when POWERNV || PSERIES is enabled. >>> >>> cheers >> >> Sounds reasonable, I was going to look into this further over the weekend. I >> can put together a patch for Monday if that works? > > Did you prepare a patch for this? I am still seeing this build error. > > thanks. > -- > ~Randy Yes, it was sent in to the linuxppc-dev list some weeks ago. Did it not arrive?