Re: [PATCH v2] tsm-mr: Fix init breakage after bin_attrs constification by scoping non-const pointers to init phase

["Thomas Weißschuh" <linux@weissschuh.net>]

On 2025-05-13 10:29:46-0700, dan.j.williams@intel.com wrote:
> dan.j.williams@ wrote:
> > Thomas Weißschuh wrote:
> > > On 2025-05-13 11:41:54-0500, Cedric Xing wrote:
> > > > Commit 9bec944506fa ("sysfs: constify attribute_group::bin_attrs") enforced
> > > > the ro-after-init principle by making elements of bin_attrs_new pointing to
> > > > const.
> > > > 
> > > > To align with this change, introduce a temporary variable `bap` within the
> > > > initialization loop. This improves code clarity by explicitly marking the
> > > > initialization scope and eliminates the need for type casts when assigning
> > > > to bin_attrs_new.
> > > > 
> > > > Signed-off-by: Cedric Xing <cedric.xing@intel.com>
> > > > ---
> > > >  drivers/virt/coco/tsm-mr.c | 30 +++++++++++++++---------------
> > > >  1 file changed, 15 insertions(+), 15 deletions(-)
> > > 
> > > <snip>
> > > 
> > > > @@ -244,7 +244,7 @@ EXPORT_SYMBOL_GPL(tsm_mr_create_attribute_group);
> > > >  void tsm_mr_free_attribute_group(const struct attribute_group *attr_grp)
> > > >  {
> > > >  	if (!IS_ERR_OR_NULL(attr_grp)) {
> > > > -		kfree(attr_grp->bin_attrs);
> > > > +		kfree(attr_grp->bin_attrs_new);
> > > 
> > > This is good, but the assignment also needs to be done to .bin_attrs_new.
> > > That is the code I can find on LKML:
> > > https://lore.kernel.org/lkml/20250506-tdx-rtmr-v6-1-ac6ff5e9d58a@intel.com/
> > 
> > Oh, the latest fixup that preceded this only went to linux-coco:
> > 
> > http://lore.kernel.org/20250509010104.669669-1-dan.j.williams@intel.com
> 
> Sorry, this one:
> 
> http://lore.kernel.org/20250509020739.882913-1-dan.j.williams@intel.com

Thanks for the pointer!

For this patch:

Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>