From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
"Brahmajit Das" <listout@listout.xyz>
Cc: "Amadeusz Sławiński" <amade@asmblr.net>,
linux-sound@vger.kernel.org, linux-next@vger.kernel.org,
liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
tiwai@suse.com
Subject: Re: [PATCH] ASoC: Intel: avs: replace strcmp with sysfs_streq
Date: Mon, 29 Dec 2025 11:03:05 +0100 [thread overview]
Message-ID: <3cd18fd0-6fef-4804-9474-41a500329e6f@intel.com> (raw)
In-Reply-To: <aUvP7FL6c1snBc_S@sirena.co.uk>
On 2025-12-24 12:35 PM, Mark Brown wrote:
> On Wed, Dec 24, 2025 at 11:05:56AM +0100, Takashi Iwai wrote:
>
>> I believe it's a false positive, too.
>> Or is it about potentially unterminated strings?
>
> Regardless of the warning being spurious or not the cleanup seems like a
> sensible one.
Right now I leaning towards Amadeusz' opinion - looks like we're masking
an issue. id->tplg_name is being used in strcmp() context few times in
this file yet compiler complains about one particular location.
gcc-16 is quite recent. It's good that we get the kernel building but
after the Christmas break some digging may be in order : )
Brahmajit,
While I'm sure you did, just to be sure - did you try clean-rebuild with
the 44-hardcode proposed by Amadeusz? We wouldn't want any old-artifacts
to get in the way.
Kind regards,
Czarek
next prev parent reply other threads:[~2025-12-29 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 18:55 [PATCH] ASoC: Intel: avs: replace strcmp with sysfs_streq Brahmajit Das
2025-12-23 17:07 ` Mark Brown
2025-12-23 18:24 ` Amadeusz Sławiński
2025-12-23 20:57 ` Brahmajit Das
2025-12-24 10:05 ` Takashi Iwai
2025-12-24 11:35 ` Mark Brown
2025-12-29 10:03 ` Cezary Rojewski [this message]
2025-12-30 7:59 ` Brahmajit Das
2025-12-30 8:32 ` Brahmajit Das
2025-12-30 9:36 ` Cezary Rojewski
2025-12-30 12:25 ` Amadeusz Sławiński
2025-12-30 14:47 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd18fd0-6fef-4804-9474-41a500329e6f@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-next@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=listout@listout.xyz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox