Re: [PATCH] powerpc/pseries: Include linux/types.h in papr-platform-dump.h

[Venkat Rao Bagalkote <venkat88@linux.ibm.com>]

On 30/04/25 2:44 am, Haren Myneni wrote:
> Fix the following build warning:
> usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Fixes: 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval")
> Closes: https://lore.kernel.org/linux-next/20250429185735.034ba678@canb.auug.org.au/
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Haren Myneni <haren@linux.ibm.com>
> ---
>   arch/powerpc/include/uapi/asm/papr-platform-dump.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/include/uapi/asm/papr-platform-dump.h b/arch/powerpc/include/uapi/asm/papr-platform-dump.h
> index a1d89c290dab..8a1c060e89a9 100644
> --- a/arch/powerpc/include/uapi/asm/papr-platform-dump.h
> +++ b/arch/powerpc/include/uapi/asm/papr-platform-dump.h
> @@ -2,6 +2,7 @@
>   #ifndef _UAPI_PAPR_PLATFORM_DUMP_H_
>   #define _UAPI_PAPR_PLATFORM_DUMP_H_
>   
> +#include <linux/types.h>
>   #include <asm/ioctl.h>
>   #include <asm/papr-miscdev.h>
>   


Tested this patch by applying on top of 6.15.0-rc4-next-20250429 and it 
fixes the reported warning. Hence,


Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>


Before Patch:


make -j 17 -s && make modules_install && make install
usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type 
without #include <linux/types.h>
   SYMLINK /lib/modules/6.15.0-rc4-next-20250429-auto/build
   INSTALL /lib/modules/6.15.0-rc4-next-20250429-auto/modules.order


After Patch:

  make -j 17 -s && make modules_install && make install
   SYMLINK 
/lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/build
   INSTALL 
/lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/modules.order
   INSTALL 
/lib/modules/6.15.0-rc4-next-20250429-auto-00001-g5f4677f96288/modules.builti


Regards,

Venkat.