From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type Date: Fri, 1 Dec 2017 21:35:16 +0100 Message-ID: <44fd0b17-67af-63cf-cca9-da64daad40a3@gmail.com> References: <20171130113516.42c8bde2@canb.auug.org.au> <20171130030543.1071-1-bjorn.andersson@linaro.org> <20171130082940.5mzslaxv53dlu3t2@dell> <20171130083131.kjgehcutqsbkjxr5@dell> <661e011e-d7d2-4947-6648-8e76e3426aaa@gmail.com> <20171201075613.vvwvrkl73pd7rg62@dell> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20171201075613.vvwvrkl73pd7rg62@dell> Sender: linux-leds-owner@vger.kernel.org To: Lee Jones Cc: Bjorn Andersson , Richard Purdie , Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Stephen Rothwell , Linux-Next Mailing List List-Id: linux-next.vger.kernel.org On 12/01/2017 08:56 AM, Lee Jones wrote: > On Thu, 30 Nov 2017, Jacek Anaszewski wrote: > >> On 11/30/2017 09:31 AM, Lee Jones wrote: >>> On Thu, 30 Nov 2017, Lee Jones wrote: >>> >>>> On Wed, 29 Nov 2017, Bjorn Andersson wrote: >>>> >>>>> The pointer returned by of_device_get_match_data() doesn't have the same >>>>> size as u32 on 64-bit architectures, causing issues when compile testing >>>>> the driver on such platform. Make ledtype unsigned long instead, to >>>>> solve this problem. >>>>> >>>>> Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver") >>>>> Cc: Linus Walleij >>>>> Signed-off-by: Bjorn Andersson >>>>> --- >>>>> drivers/leds/leds-pm8058.c | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> Hi Bjorn, >>>> >>>> (Nice to see you) :) >>>> >>>> I'm going to apply this *before* Linus' fix. >>>> >>>> Applied, thanks. >>> >>> After I rx an Ack from Richard, Jacek or Pavel of course. :) >>> >>> Will send a pull-request. >> >> Huh? This is for LED subsystem AFAICS. > > Right, hence why I said I'd sent out a pull-request. > > The problem, however, arose due to a change in its parent driver's > Kconfig entry, which has been applied to the MFD tree. We need to > ensure this patch is applied *before* the other 'fix' to quash the > warning before it starts, so to speak. Ah, I hadn't seen the MFD patch and understood that you was talking about pull request for 4.15-rc2, which looked a bit strange out of context. For v2: Acked-by: Jacek Anaszewski -- Best regards, Jacek Anaszewski