From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Rob Clark <robdclark@gmail.com>,
Sean Paul <seanpaul@chromium.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kalyan Thota <kalyan_t@codeaurora.org>
Subject: Re: inux-next: build failure after merge of the drm-msm tree
Date: Wed, 27 May 2020 22:33:21 -0400 [thread overview]
Message-ID: <453780.1590633201@turing-police> (raw)
In-Reply-To: <20200527041618.GA3137030@ubuntu-s3-xlarge-x86>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Tue, 26 May 2020 21:16:18 -0700, Nathan Chancellor said:
> Additionally, I see a failure with clang due to the use of Bps_to_icc,
> which does a straight division by 1000, which is treated as an integer
> literal, with avg_bw as the dividend, which is a u64.
>
> Below is the "hack" in my tree.
Also needed with gcc 8.3 for arm allmodconfig.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> index 85c2a4190840..5ea725d8da6c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> @@ -250,7 +250,7 @@ static int _dpu_core_perf_crtc_update_bus(struct dpu_kms *kms,
>
> for (i = 0; i < kms->num_paths; i++)
> icc_set_bw(kms->path[i],
> - Bps_to_icc(avg_bw), (perf.max_per_pipe_ib));
> + div_u64(avg_bw, 1000), (perf.max_per_pipe_ib));
>
> return ret;
> }
>
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-05-28 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 5:09 inux-next: build failure after merge of the drm-msm tree Stephen Rothwell
2020-05-26 4:08 ` Stephen Rothwell
2020-05-27 4:16 ` Nathan Chancellor
2020-05-28 2:33 ` Valdis Klētnieks [this message]
2020-05-29 4:10 ` Stephen Rothwell
2020-06-01 22:15 ` Stephen Rothwell
2020-06-02 3:15 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453780.1590633201@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=kalyan_t@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox