From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH -next] acpi utmisc: use WARN_ON() instead of warn_on_slowpath() Date: Wed, 02 Jul 2008 20:50:04 +0200 Message-ID: <486BCDDC.1000709@firstfloor.org> References: <20080701103339.b5acc1f3.randy.dunlap@oracle.com> <20080701131714.5093fa49.akpm@linux-foundation.org> <23433248.1214943818230.JavaMail.oracle@acsmt302.oracle.com> <20080701133535.f92a673c.akpm@linux-foundation.org> <20080702112852.05f30950.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from one.firstfloor.org ([213.235.205.2]:37738 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbYGBSuL (ORCPT ); Wed, 2 Jul 2008 14:50:11 -0400 In-Reply-To: <20080702112852.05f30950.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Randy Dunlap Cc: Andrew Morton , Len Brown , linux-acpi@vger.kernel.org, linux-next@vger.kernel.org Randy Dunlap wrote: > From: Randy Dunlap > > utmisc.c needs to include asm-generic/bug.h for warn()/WARN() functions, > but it should use WARN_ON() instead of warn_on_slowpath() since > arches can provide their own implementation of WARN_ON(), which does > not have to use/provide/implement warn_on_slowpath() at all. > Just use the front door (WARN_ON). > > linux-next-20080702/drivers/acpi/utilities/utmisc.c:1027: error: implicit declaration of function 'warn_on_slowpath' On what architecture did you see that? It might be be better to just provide it on all architectures supported by ACPI (x86, ia64). I suppose it was ia64? -Andi