From: Jeff Garzik <jeff@garzik.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Laurent Pinchart <laurentp@cse-semaphore.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH linux-next-20080704] Fix missing exports for net/phy/mdio-bitbang.c
Date: Fri, 11 Jul 2008 01:22:31 -0400 [thread overview]
Message-ID: <4876EE17.5050800@garzik.org> (raw)
In-Reply-To: <s5hlk0dwxvi.wl%tiwai@suse.de>
Takashi Iwai wrote:
> {alloc,free}_mdio_bitbang() are not exported while they are used in
> mdio-ofgpio driver.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
> ---
> diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
> index 2747b1f..c01b780 100644
> --- a/drivers/net/phy/mdio-bitbang.c
> +++ b/drivers/net/phy/mdio-bitbang.c
> @@ -177,6 +177,7 @@ struct mii_bus *alloc_mdio_bitbang(struct mdiobb_ctrl *ctrl)
>
> return bus;
> }
> +EXPORT_SYMBOL(alloc_mdio_bitbang);
>
> void free_mdio_bitbang(struct mii_bus *bus)
> {
> @@ -185,5 +186,6 @@ void free_mdio_bitbang(struct mii_bus *bus)
> module_put(ctrl->ops->owner);
> kfree(bus);
> }
> +EXPORT_SYMBOL(free_mdio_bitbang);
>
> MODULE_LICENSE("GPL");
applied
prev parent reply other threads:[~2008-07-11 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 14:51 [PATCH linux-next-20080704] Fix missing exports for net/phy/mdio-bitbang.c Takashi Iwai
2008-07-11 5:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876EE17.5050800@garzik.org \
--to=jeff@garzik.org \
--cc=laurentp@cse-semaphore.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).