linux-next: build warning

linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Hi Jason,

The current linux-next build (x86_64 allmodconfig) gives this warning:

drivers/char/tty_io.c: In function 'tty_find_polling_driver':
drivers/char/tty_io.c:307: warning: passing argument 2 of 'strict_strtoul' makes integer from pointer without a cast
drivers/char/tty_io.c:307: warning: passing argument 3 of 'strict_strtoul' makes pointer from integer without a cast

Which points to an actual bug introduced by commit
8a89d640448c261c248594511c72db0569725058 ("kgdboc,tty: Fix tty polling
search to use name correctly") from the kgdb tree.

simple_strtol() and strict_strtoul() take different parameters and have
different return values.

Warnings are important!  Please take a more care.

I will revert that commit from linux-next for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: build warning

[Jason Wessel]

Thanks Stephen,

My apologies for introducing the error.  This particular patch had not
undergone, final testing before making it to the linux-next tree (IE
checkpatch, boot regression, sparse, code inspection sanity).  It
accidentally got pushed while testing all the script changes from
"git-foo" to "git foo".

As a side note, checkpatch tells one to use strict_strtoul instead of
simple_strtoul, but they are obviously not "pin compatible". :-)

Cheers,
Jason.

Stephen Rothwell wrote:
> Hi Jason,
>
> The current linux-next build (x86_64 allmodconfig) gives this warning:
>
> drivers/char/tty_io.c: In function 'tty_find_polling_driver':
> drivers/char/tty_io.c:307: warning: passing argument 2 of 'strict_strtoul' makes integer from pointer without a cast
> drivers/char/tty_io.c:307: warning: passing argument 3 of 'strict_strtoul' makes pointer from integer without a cast
>
> Which points to an actual bug introduced by commit
> 8a89d640448c261c248594511c72db0569725058 ("kgdboc,tty: Fix tty polling
> search to use name correctly") from the kgdb tree.
>
> simple_strtol() and strict_strtoul() take different parameters and have
> different return values.
>
> Warnings are important!  Please take a more care.
>
> I will revert that commit from linux-next for today.
>   

linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

In file included from kernel/trace/trace_stack.c:6:
include/linux/stacktrace.h:13: warning: 'struct task_struct' declared inside parameter list
include/linux/stacktrace.h:13: warning: its scope is only this definition or declaration, which is probably not what you want

I just noticed this in passing.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: build warning

[Steven Rostedt]

On Fri, 19 Sep 2008, Stephen Rothwell wrote:

> Hi all,
> 
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
> 
> In file included from kernel/trace/trace_stack.c:6:
> include/linux/stacktrace.h:13: warning: 'struct task_struct' declared inside parameter list
> include/linux/stacktrace.h:13: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> I just noticed this in passing.

Ah, I've seen this too. If it is not already fixed, I'll have to send Ingo 
a patch.

Thanks,

-- Steve

linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi Greg,

Today's linux-next build gives this warning:

drivers/net/wireless/iwlwifi/iwl3945-base.c: In function 'iwl3945_pci_probe':
drivers/net/wireless/iwlwifi/iwl3945-base.c:7871: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type

Git blame points at commit 64d3bd686e868597694bb3088bdfe2de362c8358
("Driver core: Use dev_get_drvdata() accessors").  I suspect that the
conversion in iwl3945_pci_probe should not have been done.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: build warning

[Greg KH]

On Thu, Oct 16, 2008 at 05:04:10PM +1100, Stephen Rothwell wrote:
> Hi Greg,
> 
> Today's linux-next build gives this warning:
> 
> drivers/net/wireless/iwlwifi/iwl3945-base.c: In function 'iwl3945_pci_probe':
> drivers/net/wireless/iwlwifi/iwl3945-base.c:7871: warning: passing argument 1 of 'dev_get_drvdata' from incompatible pointer type
> 
> Git blame points at commit 64d3bd686e868597694bb3088bdfe2de362c8358
> ("Driver core: Use dev_get_drvdata() accessors").  I suspect that the
> conversion in iwl3945_pci_probe should not have been done.

Yes, I'm going to drop that patch and split it up into the proper
pieces, like it should have in the first place :(

thanks,

greg k-h

linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi Neil,

Today's linux-next build (i386 defconfig) produced these warnings:

drivers/md/md.c: In function 'print_sb_1':
drivers/md/md.c:1678: warning: left shift count >= width of type
drivers/md/md.c:1702: warning: left shift count >= width of type

Caused by commit 8a11632aeb9ad49bbda3e2c6978b207c6aff1aa8 ("md: need
another print_sb for mdp_superblock_1").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: build warning

[NeilBrown]

On Mon, November 24, 2008 5:38 pm, Stephen Rothwell wrote:
> Hi Neil,
>
> Today's linux-next build (i386 defconfig) produced these warnings:
>
> drivers/md/md.c: In function 'print_sb_1':
> drivers/md/md.c:1678: warning: left shift count >= width of type
> drivers/md/md.c:1702: warning: left shift count >= width of type
>
> Caused by commit 8a11632aeb9ad49bbda3e2c6978b207c6aff1aa8 ("md: need
> another print_sb for mdp_superblock_1").

Thanks.  That's now fixed in my tree - you should see happiness tomorrow.

NeilBrown

Re: linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

Hi Neil,

On Mon, 24 Nov 2008 18:53:46 +1100 (EST) "NeilBrown" <neilb@suse.de> wrote:
>
> Thanks.  That's now fixed in my tree - you should see happiness tomorrow.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi all,

My linux-next builds have started producing these warnings:

ld: warning: .tmp_vmlinux.kallsyms1 has a LOAD segment with RWX permissions
ld: warning: .tmp_vmlinux.kallsyms2 has a LOAD segment with RWX permissions
ld: warning: vmlinux has a LOAD segment with RWX permissions

I assume that these turned up now because I upgraded my binutils to 2.39
but I have no idea what the root cause is.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi all,

On Mon, 10 Oct 2022 14:41:34 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> My linux-next builds have started producing these warnings:
> 
> ld: warning: .tmp_vmlinux.kallsyms1 has a LOAD segment with RWX permissions
> ld: warning: .tmp_vmlinux.kallsyms2 has a LOAD segment with RWX permissions
> ld: warning: vmlinux has a LOAD segment with RWX permissions
> 
> I assume that these turned up now because I upgraded my binutils to 2.39
> but I have no idea what the root cause is.

Probably a false alarm due to me upgrading binutils while the builds
were in progress :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]