* [PATCH] kvm: x86.c make kvm_load_realmode_segment static
@ 2008-08-22 20:29 Harvey Harrison
2008-09-20 2:06 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-08-22 20:29 UTC (permalink / raw)
To: Avi Kivity; +Cc: Ingo Molnar, linux-next
Noticed by sparse:
arch/x86/kvm/x86.c:3591:5: warning: symbol 'kvm_load_realmode_segment' was not declared. Should it be static?
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
Appeared between next-20080820 and next-20080821
arch/x86/kvm/x86.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index bfc7c33..639843c 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -3588,7 +3588,7 @@ static int load_segment_descriptor_to_kvm_desct(struct kvm_vcpu *vcpu,
return 0;
}
-int kvm_load_realmode_segment(struct kvm_vcpu *vcpu, u16 selector, int seg)
+static int kvm_load_realmode_segment(struct kvm_vcpu *vcpu, u16 selector, int seg)
{
struct kvm_segment segvar = {
.base = selector << 4,
--
1.6.0.340.g84854
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: x86.c make kvm_load_realmode_segment static
2008-08-22 20:29 [PATCH] kvm: x86.c make kvm_load_realmode_segment static Harvey Harrison
@ 2008-09-20 2:06 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-09-20 2:06 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Ingo Molnar, linux-next
Harvey Harrison wrote:
> Noticed by sparse:
> arch/x86/kvm/x86.c:3591:5: warning: symbol 'kvm_load_realmode_segment' was not declared. Should it be static?
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> Appeared between next-20080820 and next-20080821
>
Applied, thanks.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-20 2:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-22 20:29 [PATCH] kvm: x86.c make kvm_load_realmode_segment static Harvey Harrison
2008-09-20 2:06 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).