* pci_ioremap_bar() breaks s390 build
@ 2008-10-20 17:45 Heiko Carstens
2008-10-20 17:47 ` Arjan van de Ven
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2008-10-20 17:45 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Jesse Barnes, linux-next
Hi Arjan,
your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks s390:
CC fs/compat_ioctl.o
In file included from fs/compat_ioctl.c:52:
include/linux/pci.h: In function 'pci_ioremap_bar':
include/linux/pci.h:1136: error: implicit declaration of function 'ioremap_nocache'
include/linux/pci.h:1137: warning: return makes pointer from integer without a cast
make[1]: *** [fs/compat_ioctl.o] Error 1
make: *** [fs] Error 2
please fix :)
maybe something like this:
---
include/linux/pci.h | 2 ++
1 file changed, 2 insertions(+)
Index: linux-next/include/linux/pci.h
===================================================================
--- linux-next.orig/include/linux/pci.h
+++ linux-next/include/linux/pci.h
@@ -1124,6 +1124,7 @@ static inline void pci_mmcfg_early_init(
static inline void pci_mmcfg_late_init(void) { }
#endif
+#ifdef CONFIG_HAS_IOMEM
static inline void * pci_ioremap_bar(struct pci_dev *pdev, int bar)
{
/*
@@ -1136,6 +1137,7 @@ static inline void * pci_ioremap_bar(str
return ioremap_nocache(pci_resource_start(pdev, bar),
pci_resource_len(pdev, bar));
}
+#endif
#endif /* __KERNEL__ */
#endif /* LINUX_PCI_H */
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: pci_ioremap_bar() breaks s390 build
2008-10-20 17:45 pci_ioremap_bar() breaks s390 build Heiko Carstens
@ 2008-10-20 17:47 ` Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
0 siblings, 2 replies; 6+ messages in thread
From: Arjan van de Ven @ 2008-10-20 17:47 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Jesse Barnes, linux-next
Heiko Carstens wrote:
> Hi Arjan,
>
> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks s390:
>
> CC fs/compat_ioctl.o
> In file included from fs/compat_ioctl.c:52:
> include/linux/pci.h: In function 'pci_ioremap_bar':
> include/linux/pci.h:1136: error: implicit declaration of function 'ioremap_nocache'
> include/linux/pci.h:1137: warning: return makes pointer from integer without a cast
> make[1]: *** [fs/compat_ioctl.o] Error 1
> make: *** [fs] Error 2
hmm does s390 have ioremap ?
since that'd be the most useful solution, to add an ioremap_nocache().
if it doesn't have ioremap.. wtf is it doing using pci.h then ??
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pci_ioremap_bar() breaks s390 build
2008-10-20 17:47 ` Arjan van de Ven
@ 2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
1 sibling, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2008-10-20 18:12 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Heiko Carstens, linux-next
On Monday, October 20, 2008 10:47 am Arjan van de Ven wrote:
> Heiko Carstens wrote:
> > Hi Arjan,
> >
> > your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks
> > s390:
> >
> > CC fs/compat_ioctl.o
> > In file included from fs/compat_ioctl.c:52:
> > include/linux/pci.h: In function 'pci_ioremap_bar':
> > include/linux/pci.h:1136: error: implicit declaration of function
> > 'ioremap_nocache' include/linux/pci.h:1137: warning: return makes pointer
> > from integer without a cast make[1]: *** [fs/compat_ioctl.o] Error 1
> > make: *** [fs] Error 2
>
> hmm does s390 have ioremap ?
> since that'd be the most useful solution, to add an ioremap_nocache().
>
> if it doesn't have ioremap.. wtf is it doing using pci.h then ??
Yeah, adding ioremap_nocache to s390 would be the simplest solution. Would
you like me to include such a patch as part of my pull request to Linus?
Thanks,
Jesse
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pci_ioremap_bar() breaks s390 build
2008-10-20 17:47 ` Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
@ 2008-10-20 18:12 ` Heiko Carstens
2008-10-20 18:14 ` Jesse Barnes
1 sibling, 1 reply; 6+ messages in thread
From: Heiko Carstens @ 2008-10-20 18:12 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Jesse Barnes, linux-next
On Mon, Oct 20, 2008 at 10:47:41AM -0700, Arjan van de Ven wrote:
> Heiko Carstens wrote:
>> Hi Arjan,
>>
>> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks s390:
>>
>> CC fs/compat_ioctl.o
>> In file included from fs/compat_ioctl.c:52:
>> include/linux/pci.h: In function 'pci_ioremap_bar':
>> include/linux/pci.h:1136: error: implicit declaration of function 'ioremap_nocache'
>> include/linux/pci.h:1137: warning: return makes pointer from integer without a cast
>> make[1]: *** [fs/compat_ioctl.o] Error 1
>> make: *** [fs] Error 2
>
> hmm does s390 have ioremap ?
> since that'd be the most useful solution, to add an ioremap_nocache().
s390 doesn't have ioremap.
> if it doesn't have ioremap.. wtf is it doing using pci.h then ??
Several common code parts pull pci.h, not s390.
fs/compat_ioctl.c is one, drivers/scsi/scsi_lib.c is another one.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pci_ioremap_bar() breaks s390 build
2008-10-20 18:12 ` Heiko Carstens
@ 2008-10-20 18:14 ` Jesse Barnes
2008-10-20 18:22 ` Heiko Carstens
0 siblings, 1 reply; 6+ messages in thread
From: Jesse Barnes @ 2008-10-20 18:14 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Arjan van de Ven, linux-next
On Monday, October 20, 2008 11:12 am Heiko Carstens wrote:
> On Mon, Oct 20, 2008 at 10:47:41AM -0700, Arjan van de Ven wrote:
> > Heiko Carstens wrote:
> >> Hi Arjan,
> >>
> >> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks
> >> s390:
> >>
> >> CC fs/compat_ioctl.o
> >> In file included from fs/compat_ioctl.c:52:
> >> include/linux/pci.h: In function 'pci_ioremap_bar':
> >> include/linux/pci.h:1136: error: implicit declaration of function
> >> 'ioremap_nocache' include/linux/pci.h:1137: warning: return makes
> >> pointer from integer without a cast make[1]: *** [fs/compat_ioctl.o]
> >> Error 1
> >> make: *** [fs] Error 2
> >
> > hmm does s390 have ioremap ?
> > since that'd be the most useful solution, to add an ioremap_nocache().
>
> s390 doesn't have ioremap.
>
> > if it doesn't have ioremap.. wtf is it doing using pci.h then ??
>
> Several common code parts pull pci.h, not s390.
> fs/compat_ioctl.c is one, drivers/scsi/scsi_lib.c is another one.
Hm, well it would probably be best to fix those (maybe add some #ifdef
CONFIG_PCI to them or somesuch), but that could get ugly. I'll go ahead and
apply your initial patch.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: pci_ioremap_bar() breaks s390 build
2008-10-20 18:14 ` Jesse Barnes
@ 2008-10-20 18:22 ` Heiko Carstens
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Carstens @ 2008-10-20 18:22 UTC (permalink / raw)
To: Jesse Barnes; +Cc: Arjan van de Ven, linux-next
On Mon, Oct 20, 2008 at 11:14:55AM -0700, Jesse Barnes wrote:
> On Monday, October 20, 2008 11:12 am Heiko Carstens wrote:
> > On Mon, Oct 20, 2008 at 10:47:41AM -0700, Arjan van de Ven wrote:
> > > Heiko Carstens wrote:
> > >> Hi Arjan,
> > >>
> > >> your patch "PCI: introduce an pci_ioremap(pdev, barnr) function" breaks
> > >> s390:
> > >>
> > >> CC fs/compat_ioctl.o
> > >> In file included from fs/compat_ioctl.c:52:
> > >> include/linux/pci.h: In function 'pci_ioremap_bar':
> > >> include/linux/pci.h:1136: error: implicit declaration of function
> > >> 'ioremap_nocache' include/linux/pci.h:1137: warning: return makes
> > >> pointer from integer without a cast make[1]: *** [fs/compat_ioctl.o]
> > >> Error 1
> > >> make: *** [fs] Error 2
> > >
> > > hmm does s390 have ioremap ?
> > > since that'd be the most useful solution, to add an ioremap_nocache().
> >
> > s390 doesn't have ioremap.
> >
> > > if it doesn't have ioremap.. wtf is it doing using pci.h then ??
> >
> > Several common code parts pull pci.h, not s390.
> > fs/compat_ioctl.c is one, drivers/scsi/scsi_lib.c is another one.
>
> Hm, well it would probably be best to fix those (maybe add some #ifdef
> CONFIG_PCI to them or somesuch), but that could get ugly. I'll go ahead and
> apply your initial patch.
Thanks! Patch was Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
in case you need that.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-10-20 18:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20 17:45 pci_ioremap_bar() breaks s390 build Heiko Carstens
2008-10-20 17:47 ` Arjan van de Ven
2008-10-20 18:12 ` Jesse Barnes
2008-10-20 18:12 ` Heiko Carstens
2008-10-20 18:14 ` Jesse Barnes
2008-10-20 18:22 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).