From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: linux-next: kernel/trace/trace.c:658: error: Date: Thu, 23 Oct 2008 16:41:22 +0200 Message-ID: <49008D12.5090204@gmail.com> References: <20081023213637.eff9b414.sfr@canb.auug.org.au> <20081023121145.GB27984@x200.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from yw-out-2324.google.com ([74.125.46.29]:3781 "EHLO yw-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751890AbYJWNfc (ORCPT ); Thu, 23 Oct 2008 09:35:32 -0400 Received: by yw-out-2324.google.com with SMTP id 9so77424ywe.1 for ; Thu, 23 Oct 2008 06:35:31 -0700 (PDT) In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Alexey Dobriyan Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar =46r=E9d=E9ric Weisbecker wrote: > 2008/10/23 Fr=E9d=E9ric Weisbecker : >> 2008/10/23 Alexey Dobriyan : >>> On alpha-smp-n-debug-y: >>> >>> kernel/trace/trace.c: In function 'tracing_generic_entry_update': >>> kernel/trace/trace.c:658: error: implicit declaration of function '= irqs_disabled_flags' >>> kernel/trace/trace.c: In function 'tracing_cpumask_write': >>> kernel/trace/trace.c:2145: error: implicit declaration of function = 'raw_local_irq_disable' >>> kernel/trace/trace.c:2162: error: implicit declaration of function = 'raw_local_irq_enable' >>> kernel/trace/trace.c: In function 'trace_die_handler': >>> kernel/trace/trace.c:3039: error: 'DIE_OOPS' undeclared (first use = in this function) >>> >>> This has something with config dependencies, because adding include= doesn't fix it. >>> >> A lot of arch have an asm/irqflags.h but not alpha. >> In linux/irqflags, raw_local_irq_* functions are defined to be >> local_irq_* function if they don't support >> CONFIG_TRACE_IRQFLAGS_SUPPORT. >> It seems the error is here, alpha may turn this option off. >> >=20 > Hmm no actually your CONFIG_TRACE_IRFLAGS_SUPPORT is not set. > So that's because the linux/irqflags.h is not included in the > asm/system.h on alpha (other archs do). >=20 Does this patch correct the issue? It applies on last -tip --- =46rom: Frederic Weisbecker Subject: [PATCH] alpha: include irqflags.h to enable use of tracing asm/system.h should include linux/irqflags.h to enable the use of traci= ng which needs raw_local_irq_* functions. Signed-off-by: Frederic Weisbecker --- diff --git a/arch/alpha/include/asm/system.h b/arch/alpha/include/asm/s= ystem.h index afe20fa..c1e6dc5 100644 --- a/arch/alpha/include/asm/system.h +++ b/arch/alpha/include/asm/system.h @@ -48,6 +48,7 @@ =20 #ifndef __ASSEMBLY__ #include +#include #define AT_VECTOR_SIZE_ARCH 4 /* entries in ARCH_DLINFO */ =20 /*