* linux-next: scsi tree build warnings
@ 2008-12-11 2:25 Stephen Rothwell
2008-12-11 14:35 ` James Smart
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2008-12-11 2:25 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-next, James Smart
[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]
Hi James,
Today's linux-next build (powerpc ppc64_defconfig) produced these
warnings:
drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_parse_bg_err':
drivers/scsi/lpfc/lpfc_scsi.c:1319: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'sector_t'
drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_queuecommand':
drivers/scsi/lpfc/lpfc_scsi.c:2376: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
drivers/scsi/lpfc/lpfc_scsi.c:2382: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
drivers/scsi/lpfc/lpfc_scsi.c:2404: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
drivers/scsi/lpfc/lpfc_scsi.c:2409: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_guard_err_show':
drivers/scsi/lpfc/lpfc_attr.c:126: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_apptag_err_show':
drivers/scsi/lpfc/lpfc_attr.c:137: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_reftag_err_show':
drivers/scsi/lpfc/lpfc_attr.c:148: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
Introduced by commit 46c6a5eabb0284b10c0377bd78c04edcb4163ee0 ("[SCSI] lpfc 8.3.0 : Add BlockGuard support (T10-DIF) code").
I guess sector_t and uint64_t should be cast to "unsigned long long"
for printing as u64 is "unsigned long" on some architectures and
"unsigned long long" on others.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: scsi tree build warnings
2008-12-11 2:25 linux-next: scsi tree build warnings Stephen Rothwell
@ 2008-12-11 14:35 ` James Smart
2008-12-11 23:30 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: James Smart @ 2008-12-11 14:35 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: James Bottomley, linux-next@vger.kernel.org
we're cleaning this up now...
-- james s
Stephen Rothwell wrote:
> Hi James,
>
> Today's linux-next build (powerpc ppc64_defconfig) produced these
> warnings:
>
> drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_parse_bg_err':
> drivers/scsi/lpfc/lpfc_scsi.c:1319: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'sector_t'
> drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_queuecommand':
> drivers/scsi/lpfc/lpfc_scsi.c:2376: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
> drivers/scsi/lpfc/lpfc_scsi.c:2382: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
> drivers/scsi/lpfc/lpfc_scsi.c:2404: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
> drivers/scsi/lpfc/lpfc_scsi.c:2409: warning: format '%llu' expects type 'long long unsigned int', but argument 6 has type 'sector_t'
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_guard_err_show':
> drivers/scsi/lpfc/lpfc_attr.c:126: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_apptag_err_show':
> drivers/scsi/lpfc/lpfc_attr.c:137: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
> drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_bg_reftag_err_show':
> drivers/scsi/lpfc/lpfc_attr.c:148: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'uint64_t'
>
> Introduced by commit 46c6a5eabb0284b10c0377bd78c04edcb4163ee0 ("[SCSI] lpfc 8.3.0 : Add BlockGuard support (T10-DIF) code").
>
> I guess sector_t and uint64_t should be cast to "unsigned long long"
> for printing as u64 is "unsigned long" on some architectures and
> "unsigned long long" on others.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: scsi tree build warnings
2008-12-11 14:35 ` James Smart
@ 2008-12-11 23:30 ` Stephen Rothwell
2008-12-16 18:44 ` James Smart
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2008-12-11 23:30 UTC (permalink / raw)
To: James Smart; +Cc: James Bottomley, linux-next@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
Hi James,
On Thu, 11 Dec 2008 09:35:48 -0500 James Smart <James.Smart@Emulex.Com> wrote:
>
> we're cleaning this up now...
Thanks.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: scsi tree build warnings
2008-12-11 23:30 ` Stephen Rothwell
@ 2008-12-16 18:44 ` James Smart
0 siblings, 0 replies; 7+ messages in thread
From: James Smart @ 2008-12-16 18:44 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: James Bottomley, linux-next@vger.kernel.org
fyi - patch for this was posted:
http://marc.info/?l=linux-scsi&m=122944234826143&w=2
-- james s
Stephen Rothwell wrote:
> Hi James,
>
> On Thu, 11 Dec 2008 09:35:48 -0500 James Smart <James.Smart@Emulex.Com> wrote:
>> we're cleaning this up now...
>
> Thanks.
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: scsi tree build warnings
@ 2009-09-07 3:00 Stephen Rothwell
2009-09-10 17:08 ` James Bottomley
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2009-09-07 3:00 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-next, linux-kernel, Robert Love
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
Hi James,
Today's linux-next build (x86_64 allmodconfig) produced these warnings:
usr/include/scsi/fc/fc_els.h:165: found __[us]{8,16,32,64} type without #include <linux/types.h>
usr/include/scsi/fc/fc_fs.h:32: found __[us]{8,16,32,64} type without #include <linux/types.h>
usr/include/scsi/fc/fc_gs.h:29: found __[us]{8,16,32,64} type without #include <linux/types.h>
usr/include/scsi/fc/fc_ns.h:71: found __[us]{8,16,32,64} type without #include <linux/types.h>
Introduced by commit 171bb4f9f6a20d405a3cb5111ce92ad83aae2302 ("[SCSI]
libfc: Export FC headers").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: scsi tree build warnings
2009-09-07 3:00 Stephen Rothwell
@ 2009-09-10 17:08 ` James Bottomley
2009-09-10 19:58 ` Robert Love
0 siblings, 1 reply; 7+ messages in thread
From: James Bottomley @ 2009-09-10 17:08 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Robert Love, linux-scsi
On Mon, 2009-09-07 at 13:00 +1000, Stephen Rothwell wrote:
> Hi James,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> usr/include/scsi/fc/fc_els.h:165: found __[us]{8,16,32,64} type without #include <linux/types.h>
> usr/include/scsi/fc/fc_fs.h:32: found __[us]{8,16,32,64} type without #include <linux/types.h>
> usr/include/scsi/fc/fc_gs.h:29: found __[us]{8,16,32,64} type without #include <linux/types.h>
> usr/include/scsi/fc/fc_ns.h:71: found __[us]{8,16,32,64} type without #include <linux/types.h>
>
> Introduced by commit 171bb4f9f6a20d405a3cb5111ce92ad83aae2302 ("[SCSI]
> libfc: Export FC headers").
OK, I've dropped this patch ... Robert, can you resubmit it when you've
verified it all works.
James
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: scsi tree build warnings
2009-09-10 17:08 ` James Bottomley
@ 2009-09-10 19:58 ` Robert Love
0 siblings, 0 replies; 7+ messages in thread
From: Robert Love @ 2009-09-10 19:58 UTC (permalink / raw)
To: James Bottomley
Cc: Stephen Rothwell, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi
On Thu, 2009-09-10 at 10:08 -0700, James Bottomley wrote:
> On Mon, 2009-09-07 at 13:00 +1000, Stephen Rothwell wrote:
> > Hi James,
> >
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> >
> > usr/include/scsi/fc/fc_els.h:165: found __[us]{8,16,32,64} type without #include <linux/types.h>
> > usr/include/scsi/fc/fc_fs.h:32: found __[us]{8,16,32,64} type without #include <linux/types.h>
> > usr/include/scsi/fc/fc_gs.h:29: found __[us]{8,16,32,64} type without #include <linux/types.h>
> > usr/include/scsi/fc/fc_ns.h:71: found __[us]{8,16,32,64} type without #include <linux/types.h>
> >
> > Introduced by commit 171bb4f9f6a20d405a3cb5111ce92ad83aae2302 ("[SCSI]
> > libfc: Export FC headers").
>
> OK, I've dropped this patch ... Robert, can you resubmit it when you've
> verified it all works.
>
Yes, I'll fix this and resubmit.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-09-10 19:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-11 2:25 linux-next: scsi tree build warnings Stephen Rothwell
2008-12-11 14:35 ` James Smart
2008-12-11 23:30 ` Stephen Rothwell
2008-12-16 18:44 ` James Smart
-- strict thread matches above, loose matches on Subject: below --
2009-09-07 3:00 Stephen Rothwell
2009-09-10 17:08 ` James Bottomley
2009-09-10 19:58 ` Robert Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).