From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments
Date: Fri, 19 Dec 2008 13:48:34 -0800 [thread overview]
Message-ID: <494C16B2.9000005@kernel.org> (raw)
In-Reply-To: <20081219214221.GE2351@elte.hu>
Impact: clean up
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> pointed out config and comments
are not right.
update it depend to NUMA, and fix some comments
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/Kconfig | 2 +-
arch/x86/kernel/io_apic.c | 2 +-
kernel/irq/numa_migrate.c | 11 +++--------
3 files changed, 5 insertions(+), 10 deletions(-)
Index: linux-2.6/arch/x86/Kconfig
===================================================================
--- linux-2.6.orig/arch/x86/Kconfig
+++ linux-2.6/arch/x86/Kconfig
@@ -259,7 +259,7 @@ config SPARSE_IRQ
config NUMA_MIGRATE_IRQ_DESC
bool "Move irq desc when changing irq smp_affinity"
- depends on SPARSE_IRQ && SMP
+ depends on SPARSE_IRQ && NUMA
default n
help
This enables moving irq_desc to cpu/node that irq will use handled.
Index: linux-2.6/arch/x86/kernel/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/io_apic.c
+++ linux-2.6/arch/x86/kernel/io_apic.c
@@ -2519,7 +2519,7 @@ static void irq_complete_move(struct irq
if (likely(!cfg->move_desc_pending))
return;
- /* domain is not change, but affinity is changed */
+ /* domain has not changed, but affinity did */
me = smp_processor_id();
if (cpu_isset(me, desc->affinity)) {
*descp = desc = move_irq_desc(desc, me);
Index: linux-2.6/kernel/irq/numa_migrate.c
===================================================================
--- linux-2.6.orig/kernel/irq/numa_migrate.c
+++ linux-2.6/kernel/irq/numa_migrate.c
@@ -1,13 +1,8 @@
/*
- * linux/kernel/irq/handle.c
- *
- * Copyright (C) 1992, 1998-2006 Linus Torvalds, Ingo Molnar
- * Copyright (C) 2005-2006, Thomas Gleixner, Russell King
- *
- * This file contains the core interrupt handling code.
- *
- * Detailed information is available in Documentation/DocBook/genericirq
+ * NUMA irq-desc migration code
*
+ * Migrate IRQ data structures (irq_desc, chip_data, etc.) over to
+ * the new "home node" of the IRQ.
*/
#include <linux/irq.h>
next prev parent reply other threads:[~2008-12-19 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 12:57 linux-next: Tree for December 19 Stephen Rothwell
2008-12-19 21:01 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Bartlomiej Zolnierkiewicz
2008-12-19 21:07 ` Yinghai Lu
2008-12-19 21:42 ` Ingo Molnar
2008-12-19 21:48 ` Yinghai Lu [this message]
2008-12-19 21:57 ` [PATCH] sparseirq: fix numa_migrate_irq_desc dependency and comments Ingo Molnar
2008-12-19 21:40 ` linux-next: Tree for December 19 (new CONFIG_NUMA_MIGRATE_IRQ_DESC option) Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494C16B2.9000005@kernel.org \
--to=yinghai@kernel.org \
--cc=bzolnier@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).