From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for January 6 (MTD) Date: Tue, 06 Jan 2009 13:16:18 -0800 Message-ID: <4963CA22.2080200@oracle.com> References: <20090106182311.525e4b14.sfr@canb.auug.org.au> <496386DB.8090606@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:47998 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752161AbZAFVQg (ORCPT ); Tue, 6 Jan 2009 16:16:36 -0500 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Alexey Korolev Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , David Woodhouse , Vasiliy Leonenko Alexey Korolev wrote: > Hi Randy, > >> # CONFIG_MTD_LPDDR is not set >> CONFIG_MTD_QINFO_PROBE=y >> >> There appears to be too little control/coordination between those >> two kconfig symbols. Surely one of them (MTD_QINFO_PROBE) should >> depend on the other (MTD_LPDDR). And why even build 2 modules >> when MTD_QINFO_PROBE is enabled? Why not combine the code into >> one module? > Thanks a lot for good finding. Here is a fix for the problem. > > About combining: it is assumed to have one QINFO probing module for several > kinds of LPDDR command set drivers. If we combine two modules into > one it would make further extension rather hard. So it is better to have > two modules. > To fix a problem I just added dependency in Kconfig file. > This temporary fix which will work until we have just one cmdset module. > In near future we will make a fix which parse command set types > and select proper driver according to device type. > > Thanks, > Alexey > > Signed-off-by: Alexey Korolev Acked-by: Randy Dunlap Thanks. > --- > diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig > index acd4ea9..5a401d8 100644 > --- a/drivers/mtd/lpddr/Kconfig > +++ b/drivers/mtd/lpddr/Kconfig > @@ -12,6 +12,7 @@ config MTD_LPDDR > DDR memories, intended for battery-operated systems. > > config MTD_QINFO_PROBE > + depends on MTD_LPDDR > tristate "Detect flash chips by QINFO probe" > help > Device Information for LPDDR chips is offered through the Overlay > > -- ~Randy