From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: schwidefsky@de.ibm.com
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com,
Mel Gorman <mel@csn.ul.ie>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: [Patch] [S390] Fix appldata build break with !NET
Date: Fri, 13 Feb 2009 16:58:05 +0530 [thread overview]
Message-ID: <49955945.2080809@in.ibm.com> (raw)
In-Reply-To: <49954589.9060604@in.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
With CONFIG_NET not set appldata build breaks on s390.
arch/s390/appldata/built-in.o: In function appldata_get_net_sum_data:
appldata_net_sum.c:(.text+0x2684): undefined reference to dev_get_stats
appldata_net_sum.c:(.text+0x2688): undefined reference to init_net
appldata_net_sum.c:(.text+0x268c): undefined reference to init_net
appldata_net_sum.c:(.text+0x2694): undefined reference to dev_base_lock
The following patch fixes the issue for me.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
----
[-- Attachment #2: fix-appldata-net-build-break.patch --]
[-- Type: text/x-patch, Size: 602 bytes --]
* Add CONFIG_NET dependancy for APPLDATA_NET_SUM.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---
diff -Naurp a/arch/s390/Kconfig b/arch/s390/Kconfig
--- a/arch/s390/Kconfig 2009-02-09 02:07:27.000000000 +0530
+++ b/arch/s390/Kconfig 2009-02-13 19:01:18.000000000 +0530
@@ -521,7 +521,7 @@ config APPLDATA_OS
config APPLDATA_NET_SUM
tristate "Monitor overall network statistics"
- depends on APPLDATA_BASE
+ depends on APPLDATA_BASE && NET
help
This provides network related data to the Linux - VM Monitor Stream,
currently there is only a total sum of network I/O statistics, no
next prev parent reply other threads:[~2009-02-13 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-13 6:55 linux-next: Tree for February 13 Stephen Rothwell
2009-02-13 10:03 ` [S390] next Feb13 build break appldata/built-in.o Sachin P. Sant
2009-02-13 11:28 ` Sachin P. Sant [this message]
2009-02-13 13:43 ` [Patch] [S390] Fix appldata build break with !NET Heiko Carstens
2009-02-13 11:44 ` next Feb 13 drivers/scsi/aha1542.ko build break Sachin P. Sant
2009-02-13 18:22 ` Randy Dunlap
2009-02-13 18:52 ` James Bottomley
2009-02-13 20:03 ` Ingo Molnar
2009-02-13 19:13 ` Joe Eykholt
2009-02-13 19:34 ` Al Viro
2009-02-13 19:35 ` Bart Van Assche
2009-02-13 19:22 ` [PATCH -next] usb: fix ehci printk formats Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49955945.2080809@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).