From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH -next] exofs: fix printk format warnings
Date: Mon, 30 Mar 2009 11:14:03 +0300 [thread overview]
Message-ID: <49D07F4B.8060203@panasas.com> (raw)
In-Reply-To: <49CBF73E.2010808@oracle.com>
On 03/26/2009 11:44 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix exofs printk format warnings:
>
> fs/exofs/inode.c:184: warning: format '%zx' expects type 'size_t', but argument 6 has type 'long unsigned int'
> fs/exofs/inode.c:291: warning: format '%zx' expects type 'size_t', but argument 6 has type 'long unsigned int'
> fs/exofs/inode.c:373: warning: format '%zx' expects type 'size_t', but argument 7 has type 'long unsigned int'
> fs/exofs/inode.c:461: warning: format '%zx' expects type 'size_t', but argument 6 has type 'long unsigned int'
> fs/exofs/inode.c:534: warning: format '%zx' expects type 'size_t', but argument 7 has type 'long unsigned int'
> fs/exofs/inode.c:610: warning: format '%zx' expects type 'size_t', but argument 5 has type 'long unsigned int'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Boaz Harrosh <bharrosh@panasas.com>
Thanks, much obliged.
Applied, it will be pushed to linux-next and for-linus branches as part of the
2.6.30 patchset. (Later today)
Boaz
> ---
> fs/exofs/inode.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-next-20090325.orig/fs/exofs/inode.c
> +++ linux-next-20090325/fs/exofs/inode.c
> @@ -182,7 +182,7 @@ static int __readpages_done(struct osd_r
> good_bytes = pcol->length - resid;
>
> EXOFS_DBGMSG("readpages_done(%ld) good_bytes=%llx"
> - " length=%zx nr_pages=%u\n",
> + " length=%lx nr_pages=%u\n",
> pcol->inode->i_ino, _LLU(good_bytes), pcol->length,
> pcol->nr_pages);
>
> @@ -288,7 +288,7 @@ static int read_exec(struct page_collect
>
> atomic_inc(&pcol->sbi->s_curr_pending);
>
> - EXOFS_DBGMSG("read_exec obj=%llx start=%llx length=%zx\n",
> + EXOFS_DBGMSG("read_exec obj=%llx start=%llx length=%lx\n",
> obj.id, _LLU(i_start), pcol->length);
>
> /* pages ownership was passed to pcol_copy */
> @@ -371,7 +371,7 @@ try_again:
> ret = pcol_add_page(pcol, page, len);
> if (ret) {
> EXOFS_DBGMSG("Failed pcol_add_page pages[i]=%p "
> - "len=%zx nr_pages=%u length=%zx\n",
> + "len=%zx nr_pages=%u length=%lx\n",
> page, len, pcol->nr_pages, pcol->length);
>
> /* split the request, and start again with current page */
> @@ -459,7 +459,7 @@ static void writepages_done(struct osd_r
> good_bytes = pcol->length - resid;
>
> EXOFS_DBGMSG("writepages_done(%lx) good_bytes=%llx"
> - " length=%zx nr_pages=%u\n",
> + " length=%lx nr_pages=%u\n",
> pcol->inode->i_ino, _LLU(good_bytes), pcol->length,
> pcol->nr_pages);
>
> @@ -531,7 +531,7 @@ static int write_exec(struct page_collec
> }
>
> atomic_inc(&pcol->sbi->s_curr_pending);
> - EXOFS_DBGMSG("write_exec(%lx, %lx) start=%llx length=%zx\n",
> + EXOFS_DBGMSG("write_exec(%lx, %lx) start=%llx length=%lx\n",
> pcol->inode->i_ino, pcol->pg_first, _LLU(i_start),
> pcol->length);
> /* pages ownership was passed to pcol_copy */
> @@ -608,7 +608,7 @@ try_again:
> ret = pcol_add_page(pcol, page, len);
> if (unlikely(ret)) {
> EXOFS_DBGMSG("Failed pcol_add_page "
> - "nr_pages=%u total_length=%zx\n",
> + "nr_pages=%u total_length=%lx\n",
> pcol->nr_pages, pcol->length);
>
> /* split the request, next loop will start again */
next prev parent reply other threads:[~2009-03-30 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 8:01 linux-next: Tree for March 26 Stephen Rothwell
2009-03-26 9:56 ` Next March 26: s390 allnoconfig build failure still exists Sachin Sant
2009-03-26 10:12 ` Heiko Carstens
2009-03-26 21:57 ` Stephen Rothwell
2009-03-26 15:46 ` linux-next: Tree for March 26 (benet) Randy Dunlap
2009-03-26 19:30 ` [PATCH] benet: use do_div() for 64 bit divide Stephen Hemminger
2009-03-26 20:10 ` Randy Dunlap
2009-03-27 7:26 ` David Miller
2009-03-26 21:44 ` [PATCH -next] exofs: fix printk format warnings Randy Dunlap
2009-03-30 8:14 ` Boaz Harrosh [this message]
2009-03-30 16:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D07F4B.8060203@panasas.com \
--to=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).