From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [BUILD FAILURE 11/12] Next April 21 : PPC64 randconfig [drivers/usb/host/ohci-hcd.o] Date: Tue, 21 Apr 2009 15:05:53 -0700 Message-ID: <49EE4341.50701@oracle.com> References: <1240340081.9110.144.camel@subratamodak.linux.ibm.com> <200904211203.36969.david-b@pacbell.net> <5A202317-5104-4784-845B-B8C46E0A3C48@kernel.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5A202317-5104-4784-845B-B8C46E0A3C48@kernel.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Kumar Gala Cc: David Brownell , subrata@linux.vnet.ibm.com, linux-usb@vger.kernel.org, Linuxppc-dev , Stephen Rothwell , linux-next , sachinp , linux-kernel , Alexander Beregalov List-Id: linux-next.vger.kernel.org Kumar Gala wrote: > > On Apr 21, 2009, at 2:03 PM, David Brownell wrote: > >> On Tuesday 21 April 2009, Subrata Modak wrote: >>> Observing this for the first time: >>> >>> CC drivers/usb/host/ohci-hcd.o >>> In file included from drivers/usb/host/ohci-hcd.c:1060: >>> drivers/usb/host/ohci-ppc-of.c:242:2: error: #error "No endianess >> >> Hmm, scripts/get_maintainer.pl doesn't report >> the PPC folk who maintain that file and its >> kbuild infrastructure. >> >> Can we have some PPC folk look at (and fix) this? > > The problem is in the drivers/usb/host/Kconfig: > > config USB_OHCI_HCD_PPC_OF_BE > bool "Support big endian HC" > depends on USB_OHCI_HCD_PPC_OF > default y > select USB_OHCI_BIG_ENDIAN_DESC > select USB_OHCI_BIG_ENDIAN_MMIO > > config USB_OHCI_HCD_PPC_OF_LE > bool "Support little endian HC" > depends on USB_OHCI_HCD_PPC_OF > default n > select USB_OHCI_LITTLE_ENDIAN > > Since its feasible to say 'n' to both we get the compile error. How do > we enforce having at least one set? Looks like using "choice" without "optional" would do it. See Documentation/kbuild/kconfig-language.txt and various examples in Kconfig* files. -- ~Randy