linux-next: origin tree build warnings

linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Hi Neil,

Today's linux-next build (powerpc ppc64_defconfig) produced these new
warnings:

drivers/net/pasemi_mac.c: In function 'pasemi_mac_rx_intr':
drivers/net/pasemi_mac.c:957: warning: unused variable 'dev'
drivers/net/pasemi_mac.c: In function 'pasemi_mac_poll':
drivers/net/pasemi_mac.c:1637: warning: unused variable 'dev'
drivers/net/spider_net.c: In function 'spider_net_poll':
drivers/net/spider_net.c:1280: warning: unused variable 'netdev'

Probably caused by commit 908a7a16b852ffd618a9127be8d62432182d81b4 ("net:
Remove unused netdev arg from some NAPI interfaces").

Please fix these up.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: origin tree build warnings

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Dec 2008 11:35:25 +1100

> Hi Neil,
> 
> Today's linux-next build (powerpc ppc64_defconfig) produced these new
> warnings:
> 
> drivers/net/pasemi_mac.c: In function 'pasemi_mac_rx_intr':
> drivers/net/pasemi_mac.c:957: warning: unused variable 'dev'
> drivers/net/pasemi_mac.c: In function 'pasemi_mac_poll':
> drivers/net/pasemi_mac.c:1637: warning: unused variable 'dev'
> drivers/net/spider_net.c: In function 'spider_net_poll':
> drivers/net/spider_net.c:1280: warning: unused variable 'netdev'
> 
> Probably caused by commit 908a7a16b852ffd618a9127be8d62432182d81b4 ("net:
> Remove unused netdev arg from some NAPI interfaces").
> 
> Please fix these up.

I'll take care of all of these issues, along with the
ibmveth et al. ones you reported seperately.

Thanks Stephen.

Re: linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

Hi Dave,

On Sun, 28 Dec 2008 20:01:45 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> I'll take care of all of these issues, along with the

Thanks.

> ibmveth et al. ones you reported seperately.

Linus already took my patches for cifs, ibmveth and ehea (probably
assuming that they were trivial).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: origin tree build warnings

[David Miller]

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 29 Dec 2008 15:17:49 +1100

> On Sun, 28 Dec 2008 20:01:45 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> >
> > I'll take care of all of these issues, along with the
> 
> Thanks.
> 
> > ibmveth et al. ones you reported seperately.
> 
> Linus already took my patches for cifs, ibmveth and ehea (probably
> assuming that they were trivial).

Yep I noticed that, thanks a lot Stephen.

linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

Hi Tyler,

Today's linux-next build (x86_64 allmodconfig) generated these warnings:

fs/ecryptfs/inode.c: In function 'ecryptfs_readlink':
fs/ecryptfs/inode.c:670: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
fs/ecryptfs/inode.c:693: warning: comparison of distinct pointer types lacks a cast

Caused by commit 3a6b42cadc112b01daf0525e5fcd90bb333a5bb3 ("eCryptfs:
Larger buffer for encrypted symlink targets").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: origin tree build warnings

[Andrew Morton]

On Wed, 29 Apr 2009 14:44:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Tyler,
> 
> Today's linux-next build (x86_64 allmodconfig) generated these warnings:
> 
> fs/ecryptfs/inode.c: In function 'ecryptfs_readlink':
> fs/ecryptfs/inode.c:670: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
> fs/ecryptfs/inode.c:693: warning: comparison of distinct pointer types lacks a cast
> 
> Caused by commit 3a6b42cadc112b01daf0525e5fcd90bb333a5bb3 ("eCryptfs:
> Larger buffer for encrypted symlink targets").

yup, Randy sent a fix for this today.

I merged that patch and put it into my "to be merged into 2.6.30 via
the ecryptfs tree" pile.

Tyler, if you can't be bothered setting up a git pull for a one-liner
then feel free to tell me to merge it.

If you don't do that then I tend to end up sitting on the patch for
rather a while, sending it at the tree maintainer once every couple of
weeks.  Sometimes I end up sitting on them after the major kernel
release, after having sent them to the maintainer several times, which
is all very sad.  Sometimes I'll get bored of sending them at the
maintainer and I'll just merge them anyway, depending upon how frisky
I'm feeling.

Re: linux-next: origin tree build warnings

[Tyler Hicks]

Andrew Morton wrote:
> On Wed, 29 Apr 2009 14:44:36 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>> Hi Tyler,
>>
>> Today's linux-next build (x86_64 allmodconfig) generated these warnings:
>>
>> fs/ecryptfs/inode.c: In function 'ecryptfs_readlink':
>> fs/ecryptfs/inode.c:670: warning: format '%d' expects type 'int', but argument 3 has type 'size_t'
>> fs/ecryptfs/inode.c:693: warning: comparison of distinct pointer types lacks a cast
>>
>> Caused by commit 3a6b42cadc112b01daf0525e5fcd90bb333a5bb3 ("eCryptfs:
>> Larger buffer for encrypted symlink targets").
> 
> yup, Randy sent a fix for this today.
> 
> I merged that patch and put it into my "to be merged into 2.6.30 via
> the ecryptfs tree" pile.
> 
> Tyler, if you can't be bothered setting up a git pull for a one-liner
> then feel free to tell me to merge it.
> 
> If you don't do that then I tend to end up sitting on the patch for
> rather a while, sending it at the tree maintainer once every couple of
> weeks.  Sometimes I end up sitting on them after the major kernel
> release, after having sent them to the maintainer several times, which
> is all very sad.  Sometimes I'll get bored of sending them at the
> maintainer and I'll just merge them anyway, depending upon how frisky
> I'm feeling.

Hi Andrew - I see another warning in Stephen's email that should be
addressed, too.  I'll fix that and set up a git pull containing both
fixes a little later today.

Tyler

linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

Hi all,

Today's linux-next build (powerpc allyesconfig) produced these warnings:

drivers/mfd/twl4030-irq.c: In function 'twl4030_sih_do_edge':
drivers/mfd/twl4030-irq.c:571: warning: passing argument 1 of 'spin_lock_irq' from incompatible pointer type
include/linux/spinlock.h:304: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
drivers/mfd/twl4030-irq.c:576: warning: passing argument 1 of 'spin_unlock_irq' from incompatible pointer type
include/linux/spinlock.h:329: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'

Introduced by commit 239007b8440abff689632f50cdf0f2b9e895b534 ("genirq:
Convert irq_desc.lock to raw_spinlock").  I guess that this file was
missed in the conversion.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: origin tree build warnings

[Linus Torvalds]

On Fri, 1 Jan 2010, Stephen Rothwell wrote:
>
> Today's linux-next build (powerpc allyesconfig) produced these warnings:
> 
> drivers/mfd/twl4030-irq.c: In function 'twl4030_sih_do_edge':
> drivers/mfd/twl4030-irq.c:571: warning: passing argument 1 of 'spin_lock_irq' from incompatible pointer type
> include/linux/spinlock.h:304: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
> drivers/mfd/twl4030-irq.c:576: warning: passing argument 1 of 'spin_unlock_irq' from incompatible pointer type
> include/linux/spinlock.h:329: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
> 
> Introduced by commit 239007b8440abff689632f50cdf0f2b9e895b534 ("genirq:
> Convert irq_desc.lock to raw_spinlock").  I guess that this file was
> missed in the conversion.

Ok, I tested and committed the other warning you pointed out, but this one 
I can't test since I no longer do powerpc builds. I assume the trivial fix 
below fixes it, but without testing I won't be committing it.

		Linus
---
 drivers/mfd/twl4030-irq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 20d29ba..9df9a5a 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work)
 
 		bytes[byte] &= ~(0x03 << off);
 
-		spin_lock_irq(&d->lock);
+		raw_spin_lock_irq(&d->lock);
 		if (d->status & IRQ_TYPE_EDGE_RISING)
 			bytes[byte] |= BIT(off + 1);
 		if (d->status & IRQ_TYPE_EDGE_FALLING)
 			bytes[byte] |= BIT(off + 0);
-		spin_unlock_irq(&d->lock);
+		raw_spin_unlock_irq(&d->lock);
 
 		edge_change &= ~BIT(i);
 	}

Re: linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

Hi Linus,

On Thu, 31 Dec 2009 16:50:39 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> Ok, I tested and committed the other warning you pointed out, but this one 
> I can't test since I no longer do powerpc builds. I assume the trivial fix 
> below fixes it, but without testing I won't be committing it.

I have built drivers/mfd/twl4030-irq.o the same way as before but after
applying your patch and the warnings are fixed.  I do not have the
hardware and so cannot do a runtime test.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: origin tree build warnings

[Linus Torvalds]

On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> 
> I have built drivers/mfd/twl4030-irq.o the same way as before but after
> applying your patch and the warnings are fixed.  I do not have the
> hardware and so cannot do a runtime test.

Ok, committed as "Reported-and-compile-tested-by:" you.

Somebody should probably test it on real hardware, but I doubt the patch 
makes anything worse, and it _probably_ makes things better.

			Linus

Re: linux-next: origin tree build warnings

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi Linus,

On Thu, 31 Dec 2009 17:32:11 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> > 
> > I have built drivers/mfd/twl4030-irq.o the same way as before but after
> > applying your patch and the warnings are fixed.  I do not have the
> > hardware and so cannot do a runtime test.
> 
> Ok, committed as "Reported-and-compile-tested-by:" you.

Thanks.

> Somebody should probably test it on real hardware, but I doubt the patch 
> makes anything worse, and it _probably_ makes things better.

With any luck :-)

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

RE: linux-next: origin tree build warnings

[Shilimkar, Santosh]

Stephen,Linus,

> -----Original Message-----
> From: Stephen Rothwell [mailto:sfr@canb.auug.org.au]
> Sent: Friday, January 01, 2010 7:21 AM
> To: Linus Torvalds
> Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Thomas Gleixner; Samuel Ortiz; Tony
> Lindgren; Shilimkar, Santosh; Krishnamoorthy, Balaji T; Nayak, Rajendra
> Subject: Re: linux-next: origin tree build warnings
> 
> Hi Linus,
> 
> On Thu, 31 Dec 2009 17:32:11 -0800 (PST) Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> > >
> > > I have built drivers/mfd/twl4030-irq.o the same way as before but after
> > > applying your patch and the warnings are fixed.  I do not have the
> > > hardware and so cannot do a runtime test.
> >
> > Ok, committed as "Reported-and-compile-tested-by:" you.
> 
> Thanks.
> 
> > Somebody should probably test it on real hardware, but I doubt the patch
> > makes anything worse, and it _probably_ makes things better.
> 
> With any luck :-)
Have tested this patch on OMAP3430 and works as expected. 

Regards,
Santosh

Re: linux-next: origin tree build warnings

[Samuel Ortiz]

Hi Linus,

On Thu, Dec 31, 2009 at 05:32:11PM -0800, Linus Torvalds wrote:
> 
> 
> On Fri, 1 Jan 2010, Stephen Rothwell wrote:
> > 
> > I have built drivers/mfd/twl4030-irq.o the same way as before but after
> > applying your patch and the warnings are fixed.  I do not have the
> > hardware and so cannot do a runtime test.
> 
> Ok, committed as "Reported-and-compile-tested-by:" you.
> 
> Somebody should probably test it on real hardware, but I doubt the patch 
> makes anything worse, and it _probably_ makes things better.
Thanks for the fix.
I got the same fix from Felipe and Tony during the holidays, so I assume they
tested it on real hardware.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/